coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: util/nvramtool: Fix typos
by build bot (Jenkins) (Code Review) 24 Aug '18

24 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28290 ) Change subject: util/nvramtool: Fix typos ...................................................................... Patch Set 4: (4 comments) https://review.coreboot.org/#/c/28290/4/util/nvramtool/coreboot_tables.h File util/nvramtool/coreboot_tables.h: https://review.coreboot.org/#/c/28290/4/util/nvramtool/coreboot_tables.h@168 PS4, Line 168: This record has a variable length. The name field may be code indent should use tabs where possible https://review.coreboot.org/#/c/28290/4/util/nvramtool/coreboot_tables.h@171 PS4, Line 171: starts at the beginning of the byte and the length code indent should use tabs where possible https://review.coreboot.org/#/c/28290/4/util/nvramtool/coreboot_tables.h@188 PS4, Line 188: This record has a variable length. The text field may be code indent should use tabs where possible https://review.coreboot.org/#/c/28290/4/util/nvramtool/coreboot_tables.h@203 PS4, Line 203: This record contains default settings for the CMOS RAM. code indent should use tabs where possible -- To view, visit https://review.coreboot.org/28290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a704cba80d0439ae95db34a6b73df7be5b3b862 Gerrit-Change-Number: 28290 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 24 Aug 2018 13:37:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Add dynamic dtb support
by Philipp Deppenwiese (Code Review) 24 Aug '18

24 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28336 to look at the new patch set (#2). Change subject: soc/cavium: Add dynamic dtb support ...................................................................... soc/cavium: Add dynamic dtb support * Add a kconfig variable containing the per board dts name. * Add auto generation of device tree (DTB) file if kconfig option is set in the mainboard implementation. * Fix cavium/cn81xx for dynamic device tree loading. Change-Id: Ie470092e424b86e04141b8e2bd2b080a5aadcf58 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M Makefile.inc M src/mainboard/Kconfig M src/soc/cavium/cn81xx/soc.c 3 files changed, 27 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/28336/2 -- To view, visit https://review.coreboot.org/28336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie470092e424b86e04141b8e2bd2b080a5aadcf58 Gerrit-Change-Number: 28336 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/nvramtool: Fix typos
by build bot (Jenkins) (Code Review) 24 Aug '18

24 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28290 ) Change subject: util/nvramtool: Fix typos ...................................................................... Patch Set 3: (4 comments) https://review.coreboot.org/#/c/28290/3/util/nvramtool/coreboot_tables.h File util/nvramtool/coreboot_tables.h: https://review.coreboot.org/#/c/28290/3/util/nvramtool/coreboot_tables.h@168 PS3, Line 168: This record fas a variable length. The name field may be code indent should use tabs where possible https://review.coreboot.org/#/c/28290/3/util/nvramtool/coreboot_tables.h@171 PS3, Line 171: starts at the beginning of the byte and the length code indent should use tabs where possible https://review.coreboot.org/#/c/28290/3/util/nvramtool/coreboot_tables.h@188 PS3, Line 188: This record has a variable length. The text field may be code indent should use tabs where possible https://review.coreboot.org/#/c/28290/3/util/nvramtool/coreboot_tables.h@203 PS3, Line 203: This record contains default settings for the CMOS RAM. code indent should use tabs where possible -- To view, visit https://review.coreboot.org/28290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a704cba80d0439ae95db34a6b73df7be5b3b862 Gerrit-Change-Number: 28290 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 24 Aug 2018 13:35:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba
by Justin TerAvest (Code Review) 24 Aug '18

24 Aug '18

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/28332 ) Change subject: mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0bf8ebab6d9cb9c8fe42a500efaa3d11ae359db Gerrit-Change-Number: 28332 Gerrit-PatchSet: 1 Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Aug 2018 13:34:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Add dynamic dtb support
by Philipp Deppenwiese (Code Review) 24 Aug '18

24 Aug '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/28336 Change subject: soc/cavium: Add dynamic dtb support ...................................................................... soc/cavium: Add dynamic dtb support * Add a kconfig variable containing the per board dts name. * Add auto generation of device tree (DTB) file if kconfig option is set in the mainboard implementation. * Fix cavium/cn81xx for dynamic device tree loading. Change-Id: Ie470092e424b86e04141b8e2bd2b080a5aadcf58 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M Makefile.inc M src/mainboard/Kconfig M src/soc/cavium/cn81xx/soc.c 3 files changed, 26 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/28336/1 diff --git a/Makefile.inc b/Makefile.inc index 7ce2360..455e058 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -568,6 +568,26 @@ smm-y+=$(DEVICETREE_STATIC_C) ####################################################################### +# needed objects that every mainboard uses +# Creation of these is architecture and mainboard independent +FIT_DEVICETREE_NAME := $(call strip_quotes,$(CONFIG_MAINBOARD_FIT_DTS)) +FIT_DEVICETREE_FILE := $(src)/mainboard/$(MAINBOARDDIR)/$(FIT_DEVICETREE_NAME) + +ifneq ($(FIT_DEVICETREE_NAME),) + +FIT_DEVICETREE := $(obj)/fit.dtb + +$(FIT_DEVICETREE): $(FIT_DEVICETREE_FILE) + @printf " DTC $(subst $(src)/,,$(<))\n" + dtc -I dts -O dtb -o $@ -i $(src)/mainboard/$(MAINBOARDDIR) -i $(src)/mainboard/$(VARIANT_DIR) $< + +cbfs-files-y += $(FIT_DEVICETREE_NAME) +$(FIT_DEVICETREE_NAME)-file := $(FIT_DEVICETREE) +$(FIT_DEVICETREE_NAME)-type := raw + +endif + +####################################################################### # Clean up rules clean-abuild: rm -rf coreboot-builds diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index 04dca4a..f8f3bff 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -180,3 +180,8 @@ config ENABLE_POWER_BUTTON def_bool y if !POWER_BUTTON_IS_OPTIONAL && POWER_BUTTON_FORCE_ENABLE def_bool n if !POWER_BUTTON_IS_OPTIONAL && POWER_BUTTON_FORCE_DISABLE + +config MAINBOARD_FIT_DTS + string + help + Set the FIT payload supported FIT device tree per mainboard. diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c index 8efcb13..0d10f4e 100644 --- a/src/soc/cavium/cn81xx/soc.c +++ b/src/soc/cavium/cn81xx/soc.c @@ -327,7 +327,7 @@ size_t size = 0; - void *ptr = cbfs_boot_map_with_leak("sff8104-linux.dtb", + void *ptr = cbfs_boot_map_with_leak(CONFIG_MAINBOARD_FIT_DTS, CBFS_TYPE_RAW, &size); if (ptr) memcpy(_sff8104, ptr, size); -- To view, visit https://review.coreboot.org/28336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie470092e424b86e04141b8e2bd2b080a5aadcf58 Gerrit-Change-Number: 28336 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: mainboard/opencellular/elgon: Add mainboard support
by build bot (Jenkins) (Code Review) 24 Aug '18

24 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28024 ) Change subject: mainboard/opencellular/elgon: Add mainboard support ...................................................................... Patch Set 8: (129 comments) https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… File src/mainboard/opencellular/elgon/gbcv2.dts: https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 20: compatible = "cavium,thunder-81xx"; DT compatible string "cavium,thunder-81xx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 20: compatible = "cavium,thunder-81xx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 26: compatible = "arm,psci-0.2"; DT compatible string "arm,psci-0.2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 26: compatible = "arm,psci-0.2"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 58: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 58: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 58: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 58: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 69: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 69: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 69: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 69: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 80: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 80: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 80: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 80: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 91: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 91: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 91: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 91: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 102: compatible = "cache"; DT compatible string "cache" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 109: compatible = "arm,armv8-timer"; DT compatible string "arm,armv8-timer" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 109: compatible = "arm,armv8-timer"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 114: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "cavium,thunder-pmu" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 114: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 114: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "arm,armv8-pmuv3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 114: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 119: compatible = "regulator-fixed"; DT compatible string "regulator-fixed" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 130: compatible = "arm,gic-v3"; DT compatible string "arm,gic-v3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 130: compatible = "arm,gic-v3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 143: compatible = "arm,gic-v3-its"; DT compatible string "arm,gic-v3-its" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 143: compatible = "arm,gic-v3-its"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 153: compatible = "simple-bus"; DT compatible string "simple-bus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 160: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 169: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 178: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 178: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 178: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 178: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 187: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 187: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 187: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 187: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 196: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 196: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 196: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 196: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 205: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 205: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 205: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 205: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 214: compatible = "arm,sbsa-gwdt"; DT compatible string "arm,sbsa-gwdt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 214: compatible = "arm,sbsa-gwdt"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 215: reg = <0x8440 0xa0000 0x0 0x1000 0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 220: compatible = "cavium,smmu-v2"; DT compatible string "cavium,smmu-v2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 220: compatible = "cavium,smmu-v2"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 223: interrupts = <0x0 0x44 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 228: compatible = "pci-host-ecam-generic"; DT compatible string "pci-host-ecam-generic" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 238: ranges = <0x3000000 0x8010 0x0 0x8010 0x0 0x80 0x0 0x3000000 0x8100 0x0 0x8100 0x0 0x80 0x0 0x3000000 0x8680 0x0 0x8680 0x0 0x160 0x28000000 0x3000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x0 0x94000000 0x3000000 0x8400 0x0 0x8400 0x0 0x10 0x0 0x3000000 0x8430 0x0 0x8430 0x0 0x2 0x0 0x3000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x1f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "pci-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "cavium,thunder-8890-mrml-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 246: ranges = <0x3000000 0x87e0 0x0 0x3000000 0x87e0 0x0 0x10 0x0>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string "cavium,thunder-8890-mdio-nexus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 255: assigned-addresses = <0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 256: ranges = <0x87e0 0x5000000 0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 259: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 259: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 259: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 262: reg = <0x87e0 0x5003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 266: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 266: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 266: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 269: reg = <0x87e0 0x5003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 274: compatible = "cavium,thunder-8890-mmc"; DT compatible string "cavium,thunder-8890-mmc" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 274: compatible = "cavium,thunder-8890-mmc"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 281: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 301: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 301: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 307: compatible = "idt,82p33914-1"; DT compatible string "idt,82p33914-1" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 307: compatible = "idt,82p33914-1"; DT compatible string vendor "idt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 321: compatible = "atmel,24c256"; DT compatible string "atmel,24c256" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 321: compatible = "atmel,24c256"; DT compatible string vendor "atmel" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 327: compatible = "isil,isl12057"; DT compatible string "isil,isl12057" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 327: compatible = "isil,isl12057"; DT compatible string vendor "isil" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 332: compatible = "infineon,slb9645tt"; DT compatible string "infineon,slb9645tt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 332: compatible = "infineon,slb9645tt"; DT compatible string vendor "infineon" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 332: compatible = "infineon,slb9645tt"; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 340: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 340: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 345: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 352: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 352: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 358: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 366: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 366: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 372: compatible = "cavium,thunder-8190-spi"; DT compatible string "cavium,thunder-8190-spi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 372: compatible = "cavium,thunder-8190-spi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; DT compatible string "winbond,w25q128" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; DT compatible string vendor "winbond" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; DT compatible string "jedec,spi-nor" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; DT compatible string vendor "jedec" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 389: compatible = "cavium,thunder-8890-gpio"; DT compatible string "cavium,thunder-8890-gpio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 389: compatible = "cavium,thunder-8890-gpio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 399: compatible = "cavium,cn8130-nand"; DT compatible string "cavium,cn8130-nand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 399: compatible = "cavium,cn8130-nand"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 406: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 406: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 415: reg = <0x8800 0x1f000000 0x0 0x39000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 416: ranges = <0x1000000 0x0 0x0 0x8830 0x0 0x0 0x10000 0x3000000 0x0 0x10000000 0x8810 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8820 0x0 0x10 0x0 0x3000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 419: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x10 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x11 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x13 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 425: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 425: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 434: reg = <0x8840 0x57000000 0x0 0x39000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 435: ranges = <0x1000000 0x0 0x10000 0x8870 0x10000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8850 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8860 0x0 0x10 0x0 0x3000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 438: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x14 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x15 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x16 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x17 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 444: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 444: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 453: reg = <0x8880 0x8f000000 0x0 0x39000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 454: ranges = <0x1000000 0x0 0x20000 0x88b0 0x20000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8890 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x88a0 0x0 0x10 0x0 0x3000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 457: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x18 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x19 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x1a 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x1b 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 465: compatible = "cavium,thunder-8190-tdm"; DT compatible string "cavium,thunder-8190-tdm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/8/src/mainboard/opencellular/elgon/gb… PS8, Line 465: compatible = "cavium,thunder-8190-tdm"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt -- To view, visit https://review.coreboot.org/28024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b809306cc48facbade5dc63846c4532b397e0b5 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 24 Aug 2018 12:37:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cn81xx: Add vboot support
by Philipp Deppenwiese (Code Review) 24 Aug '18

24 Aug '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28022 ) Change subject: soc/cn81xx: Add vboot support ...................................................................... soc/cn81xx: Add vboot support * Add VERSTAGE and VBOOT_WORK to memlayout. * Add hard and soft reset. * Add missing makefile and kconfig includes. Change-Id: I0d7e3c220f5c2c50c4ffe59ac929cb865bfac0ad Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Reviewed-on: https://review.coreboot.org/28022 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/soc/cavium/cn81xx/Kconfig M src/soc/cavium/cn81xx/Makefile.inc M src/soc/cavium/cn81xx/include/soc/addressmap.h M src/soc/cavium/cn81xx/include/soc/memlayout.ld A src/soc/cavium/cn81xx/reset.c 5 files changed, 49 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved diff --git a/src/soc/cavium/cn81xx/Kconfig b/src/soc/cavium/cn81xx/Kconfig index edc9480..24d386c 100644 --- a/src/soc/cavium/cn81xx/Kconfig +++ b/src/soc/cavium/cn81xx/Kconfig @@ -17,6 +17,11 @@ if SOC_CAVIUM_CN81XX +config VBOOT + select VBOOT_SEPARATE_VERSTAGE + select VBOOT_RETURN_FROM_VERSTAGE + select VBOOT_STARTS_IN_BOOTBLOCK + config ARM64_BL31_EXTERNAL_FILE string default "3rdparty/blobs/soc/cavium/cn81xx/bl31.elf" diff --git a/src/soc/cavium/cn81xx/Makefile.inc b/src/soc/cavium/cn81xx/Makefile.inc index 2179bc7..d212715 100644 --- a/src/soc/cavium/cn81xx/Makefile.inc +++ b/src/soc/cavium/cn81xx/Makefile.inc @@ -25,11 +25,24 @@ bootblock-y += spi.c bootblock-y += uart.c bootblock-y += cpu.c +bootblock-y += reset.c ifeq ($(CONFIG_BOOTBLOCK_CONSOLE),y) bootblock-$(CONFIG_DRIVERS_UART) += uart.c endif ################################################################################ +# verstage + +verstage-y += twsi.c +verstage-y += clock.c +verstage-y += gpio.c +verstage-y += timer.c +verstage-y += spi.c +verstage-$(CONFIG_DRIVERS_UART) += uart.c +verstage-y += cbmem.c +verstage-y += reset.c + +################################################################################ # romstage romstage-y += twsi.c @@ -40,6 +53,7 @@ romstage-y += uart.c romstage-$(CONFIG_DRIVERS_UART) += uart.c romstage-y += cbmem.c +romstage-y += reset.c romstage-y += sdram.c romstage-y += mmu.c @@ -60,6 +74,7 @@ ramstage-y += cpu_secondary.S ramstage-y += ecam0.c ramstage-y += cbmem.c +ramstage-y += reset.c ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += bl31_plat_params.c diff --git a/src/soc/cavium/cn81xx/include/soc/addressmap.h b/src/soc/cavium/cn81xx/include/soc/addressmap.h index f698306..f188961 100644 --- a/src/soc/cavium/cn81xx/include/soc/addressmap.h +++ b/src/soc/cavium/cn81xx/include/soc/addressmap.h @@ -62,6 +62,7 @@ /* RST */ #define RST_PF_BAR0 (0x87E006000000ULL + 0x1600) +#define RST_SOFT_RESET (RST_PF_BAR0 + 0x80ULL) #define RST_PP_AVAILABLE (RST_PF_BAR0 + 0x138ULL) #define RST_PP_RESET (RST_PF_BAR0 + 0x140ULL) #define RST_PP_PENDING (RST_PF_BAR0 + 0x148ULL) diff --git a/src/soc/cavium/cn81xx/include/soc/memlayout.ld b/src/soc/cavium/cn81xx/include/soc/memlayout.ld index b80d152..e3bf61f 100644 --- a/src/soc/cavium/cn81xx/include/soc/memlayout.ld +++ b/src/soc/cavium/cn81xx/include/soc/memlayout.ld @@ -28,14 +28,18 @@ /* Insecure region 1MiB - TOP OF DRAM */ /* bootblock-custom.S does setup CAR from SRAM_START to SRAM_END */ SRAM_START(BOOTROM_OFFSET) + STACK(BOOTROM_OFFSET, 16K) TIMESTAMP(BOOTROM_OFFSET + 0x4000, 4K) PRERAM_CBFS_CACHE(BOOTROM_OFFSET + 0x6000, 8K) PRERAM_CBMEM_CONSOLE(BOOTROM_OFFSET + 0x8000, 8K) - BOOTBLOCK(BOOTROM_OFFSET + 0x20000, 64K) + VBOOT2_WORK(BOOTROM_OFFSET + 0x30000, 12K) + VERSTAGE(BOOTROM_OFFSET + 0x33000, 52K) ROMSTAGE(BOOTROM_OFFSET + 0x40000, 256K) + SRAM_END(BOOTROM_OFFSET + 0x80000) + TTB(BOOTROM_OFFSET + 0x80000, 512K) RAMSTAGE(BOOTROM_OFFSET + 0x100000, 512K) /* Stack for secondary CPUs */ diff --git a/src/soc/cavium/cn81xx/reset.c b/src/soc/cavium/cn81xx/reset.c new file mode 100644 index 0000000..d3be7c9 --- /dev/null +++ b/src/soc/cavium/cn81xx/reset.c @@ -0,0 +1,23 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018-present Facebook, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <arch/io.h> +#include <soc/addressmap.h> +#include <reset.h> + +void do_soft_reset(void) +{ + write64((void *)RST_SOFT_RESET, 1); +} -- To view, visit https://review.coreboot.org/28022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0d7e3c220f5c2c50c4ffe59ac929cb865bfac0ad Gerrit-Change-Number: 28022 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/opencellular/elgon: Add mainboard support
by build bot (Jenkins) (Code Review) 24 Aug '18

24 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28024 ) Change subject: mainboard/opencellular/elgon: Add mainboard support ...................................................................... Patch Set 7: (129 comments) https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… File src/mainboard/opencellular/elgon/gbcv2.dts: https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 20: compatible = "cavium,thunder-81xx"; DT compatible string "cavium,thunder-81xx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 20: compatible = "cavium,thunder-81xx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 26: compatible = "arm,psci-0.2"; DT compatible string "arm,psci-0.2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 26: compatible = "arm,psci-0.2"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 58: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 58: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 58: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 58: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 69: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 69: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 69: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 69: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 80: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 80: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 80: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 80: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 91: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 91: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 91: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 91: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 102: compatible = "cache"; DT compatible string "cache" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 109: compatible = "arm,armv8-timer"; DT compatible string "arm,armv8-timer" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 109: compatible = "arm,armv8-timer"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 114: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "cavium,thunder-pmu" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 114: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 114: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "arm,armv8-pmuv3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 114: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 119: compatible = "regulator-fixed"; DT compatible string "regulator-fixed" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 130: compatible = "arm,gic-v3"; DT compatible string "arm,gic-v3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 130: compatible = "arm,gic-v3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 143: compatible = "arm,gic-v3-its"; DT compatible string "arm,gic-v3-its" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 143: compatible = "arm,gic-v3-its"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 153: compatible = "simple-bus"; DT compatible string "simple-bus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 160: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 169: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 178: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 178: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 178: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 178: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 187: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 187: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 187: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 187: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 196: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 196: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 196: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 196: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 205: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 205: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 205: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 205: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 214: compatible = "arm,sbsa-gwdt"; DT compatible string "arm,sbsa-gwdt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 214: compatible = "arm,sbsa-gwdt"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 215: reg = <0x8440 0xa0000 0x0 0x1000 0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 220: compatible = "cavium,smmu-v2"; DT compatible string "cavium,smmu-v2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 220: compatible = "cavium,smmu-v2"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 223: interrupts = <0x0 0x44 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 228: compatible = "pci-host-ecam-generic"; DT compatible string "pci-host-ecam-generic" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 238: ranges = <0x3000000 0x8010 0x0 0x8010 0x0 0x80 0x0 0x3000000 0x8100 0x0 0x8100 0x0 0x80 0x0 0x3000000 0x8680 0x0 0x8680 0x0 0x160 0x28000000 0x3000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x0 0x94000000 0x3000000 0x8400 0x0 0x8400 0x0 0x10 0x0 0x3000000 0x8430 0x0 0x8430 0x0 0x2 0x0 0x3000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x1f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "pci-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "cavium,thunder-8890-mrml-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 246: ranges = <0x3000000 0x87e0 0x0 0x3000000 0x87e0 0x0 0x10 0x0>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string "cavium,thunder-8890-mdio-nexus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 255: assigned-addresses = <0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 256: ranges = <0x87e0 0x5000000 0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 259: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 259: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 259: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 262: reg = <0x87e0 0x5003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 266: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 266: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 266: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 269: reg = <0x87e0 0x5003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 274: compatible = "cavium,thunder-8890-mmc"; DT compatible string "cavium,thunder-8890-mmc" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 274: compatible = "cavium,thunder-8890-mmc"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 281: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 301: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 301: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 307: compatible = "idt,82p33914-1"; DT compatible string "idt,82p33914-1" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 307: compatible = "idt,82p33914-1"; DT compatible string vendor "idt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 321: compatible = "atmel,24c256"; DT compatible string "atmel,24c256" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 321: compatible = "atmel,24c256"; DT compatible string vendor "atmel" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 327: compatible = "isil,isl12057"; DT compatible string "isil,isl12057" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 327: compatible = "isil,isl12057"; DT compatible string vendor "isil" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 332: compatible = "infineon,slb9645tt"; DT compatible string "infineon,slb9645tt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 332: compatible = "infineon,slb9645tt"; DT compatible string vendor "infineon" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 332: compatible = "infineon,slb9645tt"; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 340: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 340: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 345: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 352: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 352: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 358: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 366: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 366: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 372: compatible = "cavium,thunder-8190-spi"; DT compatible string "cavium,thunder-8190-spi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 372: compatible = "cavium,thunder-8190-spi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; DT compatible string "winbond,w25q128" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; DT compatible string vendor "winbond" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; DT compatible string "jedec,spi-nor" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; DT compatible string vendor "jedec" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 389: compatible = "cavium,thunder-8890-gpio"; DT compatible string "cavium,thunder-8890-gpio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 389: compatible = "cavium,thunder-8890-gpio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 399: compatible = "cavium,cn8130-nand"; DT compatible string "cavium,cn8130-nand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 399: compatible = "cavium,cn8130-nand"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 406: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 406: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 415: reg = <0x8800 0x1f000000 0x0 0x39000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 416: ranges = <0x1000000 0x0 0x0 0x8830 0x0 0x0 0x10000 0x3000000 0x0 0x10000000 0x8810 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8820 0x0 0x10 0x0 0x3000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 419: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x10 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x11 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x13 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 425: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 425: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 434: reg = <0x8840 0x57000000 0x0 0x39000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 435: ranges = <0x1000000 0x0 0x10000 0x8870 0x10000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8850 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8860 0x0 0x10 0x0 0x3000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 438: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x14 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x15 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x16 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x17 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 444: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 444: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 453: reg = <0x8880 0x8f000000 0x0 0x39000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 454: ranges = <0x1000000 0x0 0x20000 0x88b0 0x20000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8890 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x88a0 0x0 0x10 0x0 0x3000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 457: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x18 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x19 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x1a 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x1b 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 465: compatible = "cavium,thunder-8190-tdm"; DT compatible string "cavium,thunder-8190-tdm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/28024/7/src/mainboard/opencellular/elgon/gb… PS7, Line 465: compatible = "cavium,thunder-8190-tdm"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt -- To view, visit https://review.coreboot.org/28024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b809306cc48facbade5dc63846c4532b397e0b5 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 7 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 24 Aug 2018 12:08:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: payloads/tianocore: ignore whitespace change when applying patches
by Patrick Rudolph (Code Review) 24 Aug '18

24 Aug '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/27616 ) Change subject: payloads/tianocore: ignore whitespace change when applying patches ...................................................................... Patch Set 1: Code-Review+1 Please change the order of the patches. Make this one the first, to make sure patch 06 applies on the following patches. -- To view, visit https://review.coreboot.org/27616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38f7d46925cc00a2b5c5400e3fbf3579990f3fa5 Gerrit-Change-Number: 27616 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Aug 2018 11:46:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: OC fixes WIP
by Philipp Deppenwiese (Code Review) 24 Aug '18

24 Aug '18

Philipp Deppenwiese has uploaded a new patch set (#2). ( https://review.coreboot.org/28335 ) Change subject: OC fixes WIP ...................................................................... OC fixes WIP Change-Id: I1ccd0c28e05f5d57f0c2a7575021efbe4ba1c570 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/mainboard/Kconfig M src/mainboard/opencellular/Kconfig M src/mainboard/opencellular/Kconfig.name M src/mainboard/opencellular/elgon/Kconfig M src/mainboard/opencellular/elgon/Kconfig.name M src/mainboard/opencellular/elgon/Makefile.inc M src/mainboard/opencellular/rotundu/Kconfig M src/mainboard/opencellular/rotundu/Kconfig.name M src/soc/cavium/cn81xx/soc.c 9 files changed, 15 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/28335/2 -- To view, visit https://review.coreboot.org/28335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1ccd0c28e05f5d57f0c2a7575021efbe4ba1c570 Gerrit-Change-Number: 28335 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018