coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: cbfstool: Use endian.h and functions from commonlib
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27116 ) Change subject: cbfstool: Use endian.h and functions from commonlib ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29077/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74979/ : SUCCESS -- To view, visit https://review.coreboot.org/27116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I106274cf9c69e1849f848920d96a61188f895b36 Gerrit-Change-Number: 27116 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:24:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 ) Change subject: soc/intel/common/block: Move common uart function to block/uart ...................................................................... Patch Set 43: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74980/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29078/ : SUCCESS -- To view, visit https://review.coreboot.org/26164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 43 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:23:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 ) Change subject: soc/intel/common/block: Move common uart function to block/uart ...................................................................... Patch Set 42: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74978/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29076/ : SUCCESS -- To view, visit https://review.coreboot.org/26164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 42 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:16:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 ) Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ...................................................................... Patch Set 40: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29075/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74977/ : SUCCESS -- To view, visit https://review.coreboot.org/26132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a Gerrit-Change-Number: 26132 Gerrit-PatchSet: 40 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:15:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cbfstool: Use endian.h and functions from commonlib
by Werner Zeh (Code Review) 15 Jun '18

15 Jun '18

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/27116 Change subject: cbfstool: Use endian.h and functions from commonlib ...................................................................... cbfstool: Use endian.h and functions from commonlib The endian conversion function be32toh() is defined in src/include/endian.h, however this file is not used for cbfstool compilation. Currently the one provided by the host is used and if the host does not provide this endian.h file, the build will fail. However, we do have endian conversion functions in commonlib/endian.h which is available for cbfstool compilation. Switch from be32toh() to read_be32() in order to avoid relying on a host provided include file. We use functions from commonlib/endian.h already in cbfstool. Change-Id: I106274cf9c69e1849f848920d96a61188f895b36 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M util/cbfstool/cbfs-mkpayload.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/27116/1 diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index 6dc1634..e26c530 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -18,6 +18,7 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <commonlib/endian.h> #include "elfparsing.h" #include "common.h" @@ -426,7 +427,7 @@ DEBUG("start: parse_fit_to_payload\n"); fdt_h = buffer_get(input); - if (be32toh(fdt_h->magic) != FDT_HEADER_MAGIC) { + if (read_be32(&fdt_h->magic) != FDT_HEADER_MAGIC) { INFO("Not a FIT payload.\n"); return -1; } -- To view, visit https://review.coreboot.org/27116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I106274cf9c69e1849f848920d96a61188f895b36 Gerrit-Change-Number: 27116 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: [WIP]cbfstool: Always add compression attribute
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27115 ) Change subject: [WIP]cbfstool: Always add compression attribute ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29074/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74976/ : SUCCESS -- To view, visit https://review.coreboot.org/27115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03927dcbd486602f54210a344d5cc7af2265c965 Gerrit-Change-Number: 27115 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 09:44:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]cbfstool: Always add compression attribute
by Patrick Rudolph (Code Review) 15 Jun '18

15 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27115 to look at the new patch set (#2). Change subject: [WIP]cbfstool: Always add compression attribute ...................................................................... [WIP]cbfstool: Always add compression attribute Add the compression attribute to all sections. Fill in uncompressed size from original file. Test: The compression is shown in cbfstool coreboot.rom print instead of "none". Change-Id: I03927dcbd486602f54210a344d5cc7af2265c965 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M util/cbfstool/cbfstool.c 1 file changed, 14 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/27115/2 -- To view, visit https://review.coreboot.org/27115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03927dcbd486602f54210a344d5cc7af2265c965 Gerrit-Change-Number: 27115 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 ) Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ...................................................................... Patch Set 39: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29073/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74975/ : SUCCESS -- To view, visit https://review.coreboot.org/26132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a Gerrit-Change-Number: 26132 Gerrit-PatchSet: 39 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 09:37:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]cbfstool: Add compression attribute
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27115 ) Change subject: [WIP]cbfstool: Add compression attribute ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29072/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/74974/ : SUCCESS -- To view, visit https://review.coreboot.org/27115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03927dcbd486602f54210a344d5cc7af2265c965 Gerrit-Change-Number: 27115 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 09:36:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]vboot: Fix linking error with USE_OPTION_TABLE enabled
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26863 ) Change subject: [WIP]vboot: Fix linking error with USE_OPTION_TABLE enabled ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29071/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74973/ : SUCCESS -- To view, visit https://review.coreboot.org/26863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10ae94d7936581bbb5ea49384122062bd4934ea5 Gerrit-Change-Number: 26863 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 09:30:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018