coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in libgfxinit[master]: gma config: Introduce Has_New_FDI_(Sink|Source)
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/27051 ) Change subject: gma config: Introduce Has_New_FDI_(Sink|Source) ...................................................................... gma config: Introduce Has_New_FDI_(Sink|Source) Change-Id: Ib9a5951abf62ed01583ad028bc944c0135744457 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-pch-fdi.adb M common/hw-gfx-gma-pch.ads M common/ironlake/hw-gfx-gma-connectors-fdi.adb 4 files changed, 6 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/51/27051/2 -- To view, visit https://review.coreboot.org/27051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib9a5951abf62ed01583ad028bc944c0135744457 Gerrit-Change-Number: 27051 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma config: Introduce Have_HDMI_Buf_Override
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/27049 ) Change subject: gma config: Introduce Have_HDMI_Buf_Override ...................................................................... gma config: Introduce Have_HDMI_Buf_Override Change-Id: Id00ae200cc8d08ce245d57b2886a40f0fea10167 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/haswell/hw-gfx-gma-connectors-ddi-buffers.adb M common/haswell_shared/hw-gfx-gma-connectors-ddi.adb M common/hw-gfx-gma-config.ads.template 3 files changed, 3 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/49/27049/2 -- To view, visit https://review.coreboot.org/27049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id00ae200cc8d08ce245d57b2886a40f0fea10167 Gerrit-Change-Number: 27049 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: soc/amd/stoneyridge/southbridge.c: Store PM related registers in cbmem
by build bot (Jenkins) (Code Review) 14 Jun '18

14 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27109 ) Change subject: soc/amd/stoneyridge/southbridge.c: Store PM related registers in cbmem ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29059/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74960/ : SUCCESS -- To view, visit https://review.coreboot.org/27109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib27a743b7e7f8c94918caf7ba5efd473f4054986 Gerrit-Change-Number: 27109 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 22:02:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge/southbridge.c: Store PM related registers in cbmem
by Richard Spiegel (Code Review) 14 Jun '18

14 Jun '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27109 Change subject: soc/amd/stoneyridge/southbridge.c: Store PM related registers in cbmem ...................................................................... soc/amd/stoneyridge/southbridge.c: Store PM related registers in cbmem PM registers used for generating SWS values are being stored in a static variable within southbridge.c. In order to have it available for any source involved in building the platform, move the storage to cbmem, using id CBMEM_ID_POWER_STATE. Also add a variable that informs from which state the system is waking from, extracted from register ACPI_PM1_CNT_BLK. This variable will later be useful in detecting failed S3 resume. BUG=b:80119811 TEST=Add code to print SWS parameters and state it's waking from. Build and boot grunt, suspend and resume, check output for valid values. Remove the print code. Change-Id: Ib27a743b7e7f8c94918caf7ba5efd473f4054986 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/stoneyridge/include/soc/southbridge.h M src/soc/amd/stoneyridge/southbridge.c 2 files changed, 28 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/27109/1 diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h index 1750547..40cf621 100644 --- a/src/soc/amd/stoneyridge/include/soc/southbridge.h +++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h @@ -68,6 +68,8 @@ #define GBL_EN BIT(5) #define TIMER_STS BIT(0) #define PM1_CNT_BLK 0x62 +#define PM1_WAKE_SHIFT 10 +#define PM1_WAKE_MASK (7 << PM1_WAKE_SHIFT) #define PM_TMR_BLK 0x64 #define PM_CPU_CTRL 0x66 #define PM_GPE0_BLK 0x68 @@ -361,6 +363,14 @@ int status; }; +struct soc_power_reg { + uint16_t pm1_sts; + uint16_t pm1_en; + uint32_t gpe0_sts; + uint32_t gpe0_en; + uint16_t wake_from; +}; + void enable_aoac_devices(void); void sb_enable_rom(void); void configure_stoneyridge_i2c(void); diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index 02daa260..0f69e5b 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -662,25 +662,24 @@ elog_add_event_wake(ELOG_WAKE_SOURCE_PCIE, 0); } -struct soc_amd_sws { - uint16_t pm1_sts; - uint16_t pm1_en; - uint32_t gpe0_sts; - uint32_t gpe0_en; -}; - -static struct soc_amd_sws sws; - static void sb_save_sws(uint16_t pm1_status) { + struct soc_power_reg *sws; uint32_t reg32; + uint16_t reg16; - sws.pm1_sts = pm1_status; - sws.pm1_en = inw(ACPI_PM1_EN); + sws = cbmem_add(CBMEM_ID_POWER_STATE, sizeof(struct soc_power_reg)); + if (sws == NULL) + return; + sws->pm1_sts = pm1_status; + sws->pm1_en = inw(ACPI_PM1_EN); reg32 = inl(ACPI_GPE0_STS); outl(ACPI_GPE0_STS, reg32); - sws.gpe0_sts = reg32; - sws.gpe0_en = inl(ACPI_GPE0_EN); + sws->gpe0_sts = reg32; + sws->gpe0_en = inl(ACPI_GPE0_EN); + reg16 = inw(ACPI_PM1_CNT_BLK); + reg16 &= PM1_WAKE_MASK; + sws->wake_from = reg16 >> PM1_WAKE_SHIFT; } static void sb_clear_pm1_status(void) @@ -715,20 +714,24 @@ static void set_nvs_sws(void *unused) { + struct soc_power_reg *sws; struct global_nvs_t *gnvs; int index; + sws = cbmem_find(CBMEM_ID_POWER_STATE); + if (sws == NULL) + return; gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS); if (gnvs == NULL) return; - index = get_index_bit(sws.pm1_sts & sws.pm1_en, PM1_LIMIT); + index = get_index_bit(sws->pm1_sts & sws->pm1_en, PM1_LIMIT); if (index < 0) gnvs->pm1i = ~0ULL; else gnvs->pm1i = index; - index = get_index_bit(sws.gpe0_sts & sws.gpe0_en, GPE0_LIMIT); + index = get_index_bit(sws->gpe0_sts & sws->gpe0_en, GPE0_LIMIT); if (index < 0) gnvs->gpei = ~0ULL; else -- To view, visit https://review.coreboot.org/27109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib27a743b7e7f8c94918caf7ba5efd473f4054986 Gerrit-Change-Number: 27109 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in libgfxinit[master]: gma config: Introduce Has_Broadwell_DDI_Bufs
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has abandoned this change. ( https://review.coreboot.org/27050 ) Change subject: gma config: Introduce Has_Broadwell_DDI_Bufs ...................................................................... Abandoned squashed into 27060 -- To view, visit https://review.coreboot.org/27050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I8b17825006d35ec19ebf3e5a276aefa4d326fd73 Gerrit-Change-Number: 27050 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma config: Fix CPU range for Has_PCH_DAC
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27046 ) Change subject: gma config: Fix CPU range for Has_PCH_DAC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f6f8e3897c55aa5978e9403d14f103458c89cac Gerrit-Change-Number: 27046 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 14 Jun 2018 20:08:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma config, port detection: Scatter Valid_Port initialization
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27047 ) Change subject: gma config, port detection: Scatter Valid_Port initialization ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17df08de0aa1ffb303646ea564c100bb702407f5 Gerrit-Change-Number: 27047 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 14 Jun 2018 20:06:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma config: Introduce Has_Tertiary_Pipe
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27048 ) Change subject: gma config: Introduce Has_Tertiary_Pipe ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3c4bdaf0d6b6c6126692b00cbabaf7d3f85b4bf Gerrit-Change-Number: 27048 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 14 Jun 2018 20:04:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/pcengines: Remove unneeded includes and fix coding style
by build bot (Jenkins) (Code Review) 14 Jun '18

14 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26633 ) Change subject: mb/pcengines: Remove unneeded includes and fix coding style ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29056/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74957/ : SUCCESS -- To view, visit https://review.coreboot.org/26633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id13c0ee284293c0c06d46c75c850bc7e81cfc1f6 Gerrit-Change-Number: 26633 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 19:45:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Create fleex variant
by build bot (Jenkins) (Code Review) 14 Jun '18

14 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27105 ) Change subject: mb/google/octopus: Create fleex variant ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74954/ : SUCCESS -- To view, visit https://review.coreboot.org/27105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8b8bb757f67bea997b7f43489c38cac62f7682d Gerrit-Change-Number: 27105 Gerrit-PatchSet: 2 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 16:11:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018