coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: mediatek/mt8183: Remove DRAM_DMA section.
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27113 ) Change subject: mediatek/mt8183: Remove DRAM_DMA section. ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/74966/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29065/ : SUCCESS -- To view, visit https://review.coreboot.org/27113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ba0757adbf4f1f8d2688e5ab1a36007e4e0d0fd Gerrit-Change-Number: 27113 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 06:40:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mediatek/mt8183: Remove DRAM_DMA section.
by Tristan Hsieh (Code Review) 15 Jun '18

15 Jun '18

Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/27113 Change subject: mediatek/mt8183: Remove DRAM_DMA section. ...................................................................... mediatek/mt8183: Remove DRAM_DMA section. BUG=b:80501386 BRANCH=none TEST=work fine on Kukui Change-Id: I6ba0757adbf4f1f8d2688e5ab1a36007e4e0d0fd Signed-off-by: Tristan Shieh <tristan.shieh(a)mediatek.com> --- M src/soc/mediatek/mt8183/include/soc/memlayout.ld 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/27113/1 diff --git a/src/soc/mediatek/mt8183/include/soc/memlayout.ld b/src/soc/mediatek/mt8183/include/soc/memlayout.ld index 541f21e..f44c74b 100644 --- a/src/soc/mediatek/mt8183/include/soc/memlayout.ld +++ b/src/soc/mediatek/mt8183/include/soc/memlayout.ld @@ -25,11 +25,6 @@ #define SRAM_L2C_START(addr) SYMBOL(sram_l2c, addr) #define SRAM_L2C_END(addr) SYMBOL(esram_l2c, addr) -#define DRAM_DMA(addr, size) \ - REGION(dram_dma, addr, size, 4K) \ - _ = ASSERT(size % 4K == 0, \ - "DRAM DMA buffer should be multiple of smallest page size (4K)!"); - SECTIONS { SRAM_START(0x00100000) @@ -50,7 +45,6 @@ SRAM_L2C_END(0x00280000) DRAM_START(0x40000000) - DRAM_DMA(0x40000000, 1M) - POSTRAM_CBFS_CACHE(0x40100000, 1M) + POSTRAM_CBFS_CACHE(0x40000000, 2M) RAMSTAGE(0x40200000, 256K) } -- To view, visit https://review.coreboot.org/27113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6ba0757adbf4f1f8d2688e5ab1a36007e4e0d0fd Gerrit-Change-Number: 27113 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge/southbridge.c: Log failed S3 resume
by build bot (Jenkins) (Code Review) 14 Jun '18

14 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27110 ) Change subject: soc/amd/stoneyridge/southbridge.c: Log failed S3 resume ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29060/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74961/ : SUCCESS -- To view, visit https://review.coreboot.org/27110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77e13ff30a0ca0e9b21fca47c9b60400129365a7 Gerrit-Change-Number: 27110 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 23:36:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge/southbridge.c: Log failed S3 resume
by Richard Spiegel (Code Review) 14 Jun '18

14 Jun '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27110 Change subject: soc/amd/stoneyridge/southbridge.c: Log failed S3 resume ...................................................................... soc/amd/stoneyridge/southbridge.c: Log failed S3 resume Newly defined structure soc_power_reg includes information on last sleep type (S3/S5) extracted from power management control register. If the last sleep type was S3, but code is about to load an OS (normal boot), we have a situation in which S3 resume failed and was converted into a regular boot. We need to log this event. BUG=b:110225041 TEST=The fact that wake_from variable is working was proved in parent commit. So add code to fake S3 resume in a normal boot. Build and boot grunt, verify failed S3 resume was logged. Remove fake S3 resume. Change-Id: I77e13ff30a0ca0e9b21fca47c9b60400129365a7 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/include/elog.h M src/soc/amd/stoneyridge/include/soc/southbridge.h M src/soc/amd/stoneyridge/southbridge.c 3 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/27110/1 diff --git a/src/include/elog.h b/src/include/elog.h index 0776c36..03ec9a7 100644 --- a/src/include/elog.h +++ b/src/include/elog.h @@ -219,6 +219,11 @@ #define ELOG_TYPE_S0IX_ENTER 0xaf #define ELOG_TYPE_S0IX_EXIT 0xb0 +/* Detected errors */ +#define ELOG_TYPE_DETECTED_ERROR 0xb1 +#define ELOG_ERROR_S3_RESUME 0x00 /* failed resume, normal boot */ +#define ELOG_ERROR_SECURITY 0x01 /* ex: failed TPM */ + #if IS_ENABLED(CONFIG_ELOG) /* Eventlog backing storage must be initialized before calling elog_init(). */ extern int elog_init(void); diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h index 40cf621..ac5033d 100644 --- a/src/soc/amd/stoneyridge/include/soc/southbridge.h +++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h @@ -416,6 +416,7 @@ void xhci_pm_write32(uint8_t reg, uint32_t value); uint32_t xhci_pm_read32(uint8_t reg); void bootblock_fch_early_init(void); +void sb_log_error(uint8_t error); /** * @brief Save the UMA bize returned by AGESA * diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index 0f69e5b..651809c 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -514,6 +514,14 @@ pci_write_config16(SOC_LPC_DEV, ROM_ADDRESS_RANGE2_END, 0xffff); } +void sb_log_error(uint8_t error) +{ + if (!IS_ENABLED(CONFIG_ELOG)) + return; + + elog_add_event_byte(ELOG_TYPE_DETECTED_ERROR, error); +} + static void sb_lpc_early_setup(void) { uint32_t dword; @@ -748,8 +756,14 @@ void southbridge_final(void *chip_info) { + struct soc_power_reg *sws; uint8_t restored_power = PM_S5_AT_POWER_RECOVERY; + sws = cbmem_find(CBMEM_ID_POWER_STATE); + if (sws != NULL) { + if (sws->wake_from == 3) + sb_log_error(ELOG_ERROR_S3_RESUME); + } if (IS_ENABLED(CONFIG_STONEYRIDGE_IMC_FWM)) { agesawrapper_fchecfancontrolservice(); if (!IS_ENABLED(CONFIG_ACPI_ENABLE_THERMAL_ZONE)) -- To view, visit https://review.coreboot.org/27110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I77e13ff30a0ca0e9b21fca47c9b60400129365a7 Gerrit-Change-Number: 27110 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in libgfxinit[master]: gma config: Introduce Has_New_FDI_(Sink|Source)
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27051 ) Change subject: gma config: Introduce Has_New_FDI_(Sink|Source) ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://review.coreboot.org/27051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a5951abf62ed01583ad028bc944c0135744457 Gerrit-Change-Number: 27051 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 14 Jun 2018 22:42:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma config: Introduce Has_Ivy_Bridge_FDI
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has abandoned this change. ( https://review.coreboot.org/27052 ) Change subject: gma config: Introduce Has_Ivy_Bridge_FDI ...................................................................... Abandoned squashed into parent -- To view, visit https://review.coreboot.org/27052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I2adeaef88fb79c40e999d0857f927ffe82a9c41b Gerrit-Change-Number: 27052 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma config: Introduce Have_HDMI_Buf_Override
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27049 ) Change subject: gma config: Introduce Have_HDMI_Buf_Override ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://review.coreboot.org/27049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id00ae200cc8d08ce245d57b2886a40f0fea10167 Gerrit-Change-Number: 27049 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 14 Jun 2018 22:40:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma: Turn constants depending on Config.CPU* into functions
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/27062 ) Change subject: gma: Turn constants depending on Config.CPU* into functions ...................................................................... gma: Turn constants depending on Config.CPU* into functions To reduce elaboration time dependencies, turn constants at package level into functions. This will allow us to use the same code for configurations with constant and non-constant `GMA.Config.CPU*`. Change-Id: I0522f5c63c63080bf9633f3d1b6019f35e52d226 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-pch-fdi.adb M common/hw-gfx-gma-pch-vga.adb M common/hw-gfx-gma-pch.ads M common/ironlake/hw-gfx-gma-connectors-fdi.adb M common/ironlake/hw-gfx-gma-pch-hdmi.adb 5 files changed, 57 insertions(+), 45 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/62/27062/2 -- To view, visit https://review.coreboot.org/27062 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0522f5c63c63080bf9633f3d1b6019f35e52d226 Gerrit-Change-Number: 27062 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma config: Introduce per generation/CPU booleans
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/27060 ) Change subject: gma config: Introduce per generation/CPU booleans ...................................................................... gma config: Introduce per generation/CPU booleans The per CPU booleans are additionally guarded by the respective generation so that the compiler may decide purely on the generation. Also use the new booleans to get rid of all direct references to `Config.CPU` and `Config.CPU_Var`. Change-Id: I307d1dd56f480fdb4fbc6e2e25fc5f413c4158f8 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/haswell/hw-gfx-gma-connectors-ddi-buffers.adb M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma.adb 3 files changed, 137 insertions(+), 132 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/60/27060/2 -- To view, visit https://review.coreboot.org/27060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I307d1dd56f480fdb4fbc6e2e25fc5f413c4158f8 Gerrit-Change-Number: 27060 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma: Introduce Generation type
by Nico Huber (Code Review) 14 Jun '18

14 Jun '18

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/27059 ) Change subject: gma: Introduce Generation type ...................................................................... gma: Introduce Generation type It's the subset of `CPU_Type` that we have different compilation units for. Also use it in the `Config` wherever we can decide something purely on the `Generation` (i.e. don't mix `Gen` and `CPU` in expressions). Change-Id: I5061021a80cd75ee3d7996ca343e6388b22bf341 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/Makefile.inc M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads M configs/broadwell M configs/broadwell_ult M configs/broxton M configs/g45 M configs/haswell M configs/haswell_ult M configs/ironlake M configs/ivybridge_edp M configs/ivybridge_lvds M configs/sandybridge M configs/skylake M configs/skylake_ult 17 files changed, 67 insertions(+), 61 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/59/27059/2 -- To view, visit https://review.coreboot.org/27059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5061021a80cd75ee3d7996ca343e6388b22bf341 Gerrit-Change-Number: 27059 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018