coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS
by Patrick Georgi (Code Review) 15 Jun '18

15 Jun '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27117 ) Change subject: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf254149fbec9551d9220018d6d6a0a1be741538 Gerrit-Change-Number: 27117 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 14:42:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27117 ) Change subject: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29082/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74984/ : SUCCESS -- To view, visit https://review.coreboot.org/27117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf254149fbec9551d9220018d6d6a0a1be741538 Gerrit-Change-Number: 27117 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 14:30:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS
by Simon Glass (Code Review) 15 Jun '18

15 Jun '18

Simon Glass has posted comments on this change. ( https://review.coreboot.org/27117 ) Change subject: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf254149fbec9551d9220018d6d6a0a1be741538 Gerrit-Change-Number: 27117 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 14:27:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS
by Simon Glass (Code Review) 15 Jun '18

15 Jun '18

Simon Glass has posted comments on this change. ( https://review.coreboot.org/27117 ) Change subject: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/27117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf254149fbec9551d9220018d6d6a0a1be741538 Gerrit-Change-Number: 27117 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 14:27:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS
by Martin Roth (Code Review) 15 Jun '18

15 Jun '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/27117 Change subject: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS ...................................................................... mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS All Grunt variants should identify as grunt in SMBIOS so that they're recognized correctly as a unibuild Grunt variant. BUG=b:110244268 TEST=Careena identifies as grunt Change-Id: Iaf254149fbec9551d9220018d6d6a0a1be741538 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/27117/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index f5ae3fb..fd43ed6 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -54,8 +54,7 @@ config MAINBOARD_PART_NUMBER string - default "Careena" if BOARD_GOOGLE_CAREENA - default "Grunt" if BOARD_GOOGLE_GRUNT + default "Grunt" config DEVICETREE string -- To view, visit https://review.coreboot.org/27117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf254149fbec9551d9220018d6d6a0a1be741538 Gerrit-Change-Number: 27117 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 ) Change subject: soc/intel/common/block: Move common uart function to block/uart ...................................................................... Patch Set 46: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29081/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74983/ : SUCCESS -- To view, visit https://review.coreboot.org/26164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 46 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 13:21:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 ) Change subject: soc/intel/common/block: Move common uart function to block/uart ...................................................................... Patch Set 45: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74982/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29080/ : SUCCESS -- To view, visit https://review.coreboot.org/26164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 45 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:52:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 ) Change subject: soc/intel/common/block: Move common uart function to block/uart ...................................................................... Patch Set 44: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74981/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29079/ : SUCCESS -- To view, visit https://review.coreboot.org/26164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 44 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:43:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cbfstool: Use endian.h and functions from commonlib
by Patrick Georgi (Code Review) 15 Jun '18

15 Jun '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27116 ) Change subject: cbfstool: Use endian.h and functions from commonlib ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I106274cf9c69e1849f848920d96a61188f895b36 Gerrit-Change-Number: 27116 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:32:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cbfstool: Use endian.h and functions from commonlib
by Nico Huber (Code Review) 15 Jun '18

15 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27116 ) Change subject: cbfstool: Use endian.h and functions from commonlib ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/27116/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27116/1//COMMIT_MSG@18 PS1, Line 18: We use functions from commonlib/endian.h already in cbfstool. Superfluous to say, as commonlib was introduced exactly for that. -- To view, visit https://review.coreboot.org/27116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I106274cf9c69e1849f848920d96a61188f895b36 Gerrit-Change-Number: 27116 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:25:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018