coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in libgfxinit[master]: gma config: Enable Restrictions (No_Elaboration_Code)
by Nico Huber (Code Review) 17 Jun '18

17 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27143 ) Change subject: gma config: Enable Restrictions (No_Elaboration_Code) ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eea973836a05eefcc2c98de75e6721ef3cd278b Gerrit-Change-Number: 27143 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 17 Jun 2018 22:24:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma: Implement automatic CPU detection
by Nico Huber (Code Review) 17 Jun '18

17 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27138 ) Change subject: gma: Implement automatic CPU detection ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/27138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ce31c867f97c8d6ef99ca096cb45f7719e78a19 Gerrit-Change-Number: 27138 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 17 Jun 2018 22:24:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] Update libgfxinit for dynamic CPU detection
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27145 ) Change subject: [WIP] Update libgfxinit for dynamic CPU detection ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29128/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75034/ : SUCCESS -- To view, visit https://review.coreboot.org/27145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c349f0ee42c7b201ef0c7461c39c82dede823a9 Gerrit-Change-Number: 27145 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Jun 2018 22:13:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] Update libgfxinit for dynamic CPU detection
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27145 ) Change subject: [WIP] Update libgfxinit for dynamic CPU detection ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27145/1/src/drivers/intel/gma/Kconfig File src/drivers/intel/gma/Kconfig: https://review.coreboot.org/#/c/27145/1/src/drivers/intel/gma/Kconfig@86 PS1, Line 86: boolean Use of boolean is deprecated, please use bool instead. -- To view, visit https://review.coreboot.org/27145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c349f0ee42c7b201ef0c7461c39c82dede823a9 Gerrit-Change-Number: 27145 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Jun 2018 22:04:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] Update libgfxinit for dynamic CPU detection
by Nico Huber (Code Review) 17 Jun '18

17 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27145 Change subject: [WIP] Update libgfxinit for dynamic CPU detection ...................................................................... [WIP] Update libgfxinit for dynamic CPU detection Change-Id: I8c349f0ee42c7b201ef0c7461c39c82dede823a9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 3rdparty/libgfxinit M 3rdparty/libhwbase M src/drivers/intel/gma/Kconfig M src/drivers/intel/gma/hires_fb/gma.adb 4 files changed, 22 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/27145/1 diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 718c79b..26d68ca 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 718c79bb0713b5b90c9cc44e03197dc777066e3d +Subproject commit 26d68ca84e2e7bae1387e06c55e9b7b9d5230282 diff --git a/3rdparty/libhwbase b/3rdparty/libhwbase index 637f2a4..b38f4b2 160000 --- a/3rdparty/libhwbase +++ b/3rdparty/libhwbase @@ -1 +1 @@ -Subproject commit 637f2a4f21ead8ccc45d5256834eb27ce72088db +Subproject commit b38f4b254801aa0c30b25d7f4cd383cac7b04fb5 diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index 1b9c2a6..6e4a875 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -73,6 +73,22 @@ if GFX_GMA +config GFX_GMA_GENERATION + string + default "Skylake" if SOC_INTEL_SKYLAKE + default "Haswell" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL + default "Ironlake" if NORTHBRIDGE_INTEL_NEHALEM || \ + NORTHBRIDGE_INTEL_SANDYBRIDGE || \ + NORTHBRIDGE_INTEL_IVYBRIDGE + default "G45" if NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X + +config GFX_GMA_DYN_CPU + boolean + default y if NORTHBRIDGE_INTEL_SANDYBRIDGE || \ + NORTHBRIDGE_INTEL_IVYBRIDGE || \ + (NORTHBRIDGE_INTEL_HASWELL && !INTEL_LYNXPOINT_LP) || \ + (SOC_INTEL_SKYLAKE && SKYLAKE_SOC_PCH_H) + config GFX_GMA_CPU string default "Skylake" if SOC_INTEL_SKYLAKE diff --git a/src/drivers/intel/gma/hires_fb/gma.adb b/src/drivers/intel/gma/hires_fb/gma.adb index ca0f708..bd14132 100644 --- a/src/drivers/intel/gma/hires_fb/gma.adb +++ b/src/drivers/intel/gma/hires_fb/gma.adb @@ -60,8 +60,8 @@ success : boolean; - min_h : pos16 := pos16'last; - min_v : pos16 := pos16'last; + min_h : pos32 := pos32'last; + min_v : pos32 := pos32'last; begin lightup_ok := 0; @@ -75,8 +75,8 @@ for i in Pipe_Index loop exit when configs (i).Port = Disabled; - min_h := pos16'min (min_h, configs (i).Mode.H_Visible); - min_v := pos16'min (min_v, configs (i).Mode.V_Visible); + min_h := pos32'min (min_h, configs (i).Mode.H_Visible); + min_v := pos32'min (min_v, configs (i).Mode.V_Visible); end loop; fb := configs (Primary).Framebuffer; -- To view, visit https://review.coreboot.org/27145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8c349f0ee42c7b201ef0c7461c39c82dede823a9 Gerrit-Change-Number: 27145 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libhwbase[master]: Makefile: Add bincompare target
by Nico Huber (Code Review) 17 Jun '18

17 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27144 Change subject: Makefile: Add bincompare target ...................................................................... Makefile: Add bincompare target Change-Id: I7d2dfc7a2e34851fe01a9d72e0d90db00a284eaf Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile A Makefile.compare 2 files changed, 30 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/44/27144/1 diff --git a/Makefile b/Makefile index a25deb6..8b9ff08 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ DESTDIR ?= dest name ?= hw -hw-install = Makefile Makefile.proof debug.adc gnat.adc spark.adc +hw-install = Makefile Makefile.compare Makefile.proof debug.adc gnat.adc spark.adc top := $(CURDIR) cnf := .config @@ -32,6 +32,7 @@ $(eval -include $($(dep)-dir)/config)) -include $(cnf) +include $(libhw-dir)/Makefile.compare include $(libhw-dir)/Makefile.proof ifeq ($(DEBUG),1) diff --git a/Makefile.compare b/Makefile.compare new file mode 100644 index 0000000..7a707c8 --- /dev/null +++ b/Makefile.compare @@ -0,0 +1,28 @@ +bincompare-configs := $(wildcard configs/*) +bincompare-targets := $(addprefix bincompare-,$(notdir $(bincompare-configs))) + +$(bincompare-targets): bincompare-%: configs/% + $(MAKE) CFLAGS=-Os obj=$(objprefix)/$* cnf=configs/$* + +bincompare: ref := HEAD^ +bincompare: + rm -rf bincmp.ref/ bincmp.head/ + [ "$$(git rev-parse $(ref))" = "$$(git rev-parse HEAD)" ] || { \ + git checkout $(ref) && \ + $(MAKE) objprefix=bincmp.ref $(bincompare-targets) || \ + { git checkout HEAD@{1}; exit 1; } && \ + git checkout HEAD@{1} && \ + $(MAKE) objprefix=bincmp.head $(bincompare-targets) && \ + res=0 && \ + for t in $(patsubst bincompare-%,%,$(bincompare-targets)); \ + do \ + b=$$t/$(notdir $(binary)); \ + r=$$(objdump -d bincmp.ref/$$b | grep -v bincmp); \ + h=$$(objdump -d bincmp.head/$$b | grep -v bincmp); \ + if [ "$$r" != "$$h" ]; then \ + printf "Binaries for %s differ.\n" "$$t"; \ + res=1; \ + fi; \ + done; exit $$res; } + +.PHONY: bincompare $(bincompare-targets) -- To view, visit https://review.coreboot.org/27144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7d2dfc7a2e34851fe01a9d72e0d90db00a284eaf Gerrit-Change-Number: 27144 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma config: Enable Restrictions (No_Elaboration_Code)
by Nico Huber (Code Review) 17 Jun '18

17 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27143 Change subject: gma config: Enable Restrictions (No_Elaboration_Code) ...................................................................... gma config: Enable Restrictions (No_Elaboration_Code) Forcing compile-time evaluation seems to be the right thing and works well now. It also helps to compare binaries after refactorizations. Change-Id: I4eea973836a05eefcc2c98de75e6721ef3cd278b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/43/27143/1 diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 1977742..c4f68ea 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -12,6 +12,8 @@ -- GNU General Public License for more details. -- +pragma Restrictions (No_Elaboration_Code); + private package HW.GFX.GMA.Config is Gen : constant Generation := <<GEN>>; -- To view, visit https://review.coreboot.org/27143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4eea973836a05eefcc2c98de75e6721ef3cd278b Gerrit-Change-Number: 27143 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: soc/intel: Remove the user selectable FSP_CAR option
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27142 ) Change subject: soc/intel: Remove the user selectable FSP_CAR option ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75033/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29127/ : SUCCESS -- To view, visit https://review.coreboot.org/27142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85d46fdb41e4bac478009eeb2fa3853de7e67205 Gerrit-Change-Number: 27142 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Jun 2018 21:10:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel: Remove the user selectable FSP_CAR option
by Arthur Heymans (Code Review) 17 Jun '18

17 Jun '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/27142 Change subject: soc/intel: Remove the user selectable FSP_CAR option ...................................................................... soc/intel: Remove the user selectable FSP_CAR option This is always selected by other Kconfig options so don't make it an option. Change-Id: I85d46fdb41e4bac478009eeb2fa3853de7e67205 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/27142/1 diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig index f149544..aa9e476 100644 --- a/src/drivers/intel/fsp2_0/Kconfig +++ b/src/drivers/intel/fsp2_0/Kconfig @@ -85,7 +85,7 @@ The path and filename of the Intel FSP-S binary for this platform. config FSP_CAR - bool "Use FSP TempRamInit & TempRamExit APIs" + bool depends on ADD_FSP_BINARIES default n help -- To view, visit https://review.coreboot.org/27142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I85d46fdb41e4bac478009eeb2fa3853de7e67205 Gerrit-Change-Number: 27142 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: soc/intel/skylake: Improve Kconfig
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27141 ) Change subject: soc/intel/skylake: Improve Kconfig ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75032/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29126/ : SUCCESS -- To view, visit https://review.coreboot.org/27141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3868b7688322cc7c0099058fc64106468aa82c32 Gerrit-Change-Number: 27141 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Jun 2018 21:01:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018