coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in libhwbase[master]: Makefile: Revise support for generated sources
by Nico Huber (Code Review) 17 Jun '18

17 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27139 Change subject: Makefile: Revise support for generated sources ...................................................................... Makefile: Revise support for generated sources Handle generated source files more independently from normal source files. This allows mixing of generated specs with existing source bodies. Change-Id: I5479c436f39088ae9d0ebddf9a97446be0f191f3 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M Makefile.proof 2 files changed, 16 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/39/27139/1 diff --git a/Makefile b/Makefile index 09881e5..a25deb6 100644 --- a/Makefile +++ b/Makefile @@ -190,12 +190,16 @@ # *-srcs. Extract / filter all specification files that have a matching # body (.adb) file here (specifications without a body are valid sources # in Ada). -$(name)-extra-specs := \ +# $1 source list +filter_extra_specs = \ $(filter \ - $(addprefix %/,$(patsubst %.adb,%.ads,$(notdir $(filter %.adb,$($(name)-srcs))))), \ - $(filter %.ads,$($(name)-srcs) $($(name)-gens))) + $(addprefix %/,$(patsubst %.adb,%.ads, \ + $(notdir $(filter %.adb,$($(name)-srcs) $($(name)-gens))))), \ + $(filter %.ads,$(1))) +$(name)-extra-specs := $(call filter_extra_specs,$($(name)-srcs)) $(name)-srcs := $(filter-out $($(name)-extra-specs),$($(name)-srcs)) -$(name)-gens := $(filter-out $($(name)-extra-specs),$($(name)-gens)) +$(name)-extra-gens := $(call filter_extra_specs,$($(name)-gens)) +$(name)-gens := $(filter-out $($(name)-extra-gens),$($(name)-gens)) $(name)-objs := $(call src-to-obj,,$($(name)-srcs) $($(name)-gens)) $(name)-alis := $(call src-to-ali,,$($(name)-srcs) $($(name)-gens)) @@ -216,8 +220,8 @@ $(if $(wildcard $(1)),\ $(filter \ $(addprefix %/,$(shell sed -ne's/^D $[^\t]\+$.*$$/\1/p' $(1) 2>/dev/null)), \ - $($(name)-srcs) $($(name)-gens) $($(name)-extra-specs)), \ - $($(name)-gens)) + $($(name)-srcs) $($(name)-gens) $($(name)-extra-specs) $($(name)-extra-gens)), \ + $($(name)-gens) $($(name)-extra-gens)) # Adds dependency rules # $1 source file @@ -283,7 +287,7 @@ $(shell mkdir -p $(alldirs)) $(name)-install-srcs = $(sort \ - $($(name)-extra-specs) $(filter %.ads,$($(name)-srcs) $($(name)-gens)) \ + $($(name)-extra-specs) $($(name)-extra-gens) $(filter %.ads,$($(name)-srcs) $($(name)-gens)) \ $(foreach adb,$(filter %.adb,$($(name)-srcs)), \ $(shell grep -q '^U .*\<BN\>' $(call src-to-ali,,$(adb)) 2>/dev/null && echo $(adb)))) diff --git a/Makefile.proof b/Makefile.proof index 45523c3..3d30c2b 100644 --- a/Makefile.proof +++ b/Makefile.proof @@ -17,7 +17,8 @@ $(name)-exclude-srcs = \ $(filter-out \ - $(sort $(notdir $($(name)-proof) $($(name)-srcs) $($(name)-gens) $($(name)-extra-specs))), \ + $(sort $(notdir $($(name)-proof) \ + $($(name)-srcs) $($(name)-gens) $($(name)-extra-specs) $($(name)-extra-gens))), \ $(sort $(notdir \ $(wildcard $(addsuffix *.ad[sb],$($(name)-proof-dirs)))))) @@ -62,7 +63,9 @@ echo ' for Object_Dir use external ("obj", "build");' >>$@ echo 'end lib$(name);' >>$@ -$(obj)/gnatprove/gnatprove.out: $(gpr) $$($(name)-srcs) $$($(name)-gens) $(obj)/proofmode +$(obj)/gnatprove/gnatprove.out: $$($(name)-srcs) $$($(name)-gens) +$(obj)/gnatprove/gnatprove.out: $$($(name)-extra-specs) $$($(name)-extra-gens) +$(obj)/gnatprove/gnatprove.out: $(gpr) $(obj)/proofmode gnatprove -P$< $(SPARKFLAGS) -Xobj=$(abspath $(obj)) proof: -- To view, visit https://review.coreboot.org/27139 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5479c436f39088ae9d0ebddf9a97446be0f191f3 Gerrit-Change-Number: 27139 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma: Implement automatic CPU detection
by Nico Huber (Code Review) 17 Jun '18

17 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27138 Change subject: gma: Implement automatic CPU detection ...................................................................... gma: Implement automatic CPU detection In dynamic CPU configurations, Config.Detect_CPU() sets the CPU variables according to the given PCI device id. In static confi- gurations it does nothing. Change-Id: I8ce31c867f97c8d6ef99ca096cb45f7719e78a19 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/Makefile.inc A common/dyncpu/hw-gfx-gma-config.adb M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma.adb 4 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/38/27138/1 diff --git a/common/Makefile.inc b/common/Makefile.inc index 815de90..50834fd 100644 --- a/common/Makefile.inc +++ b/common/Makefile.inc @@ -79,6 +79,7 @@ -e's/<$ilk\|hsw\|skl$$...$\?var>/$(_GEN_CONST_TARGET)/' \ -e's/$.*: *<cpufunc>.*:=$ *$.*$;/\1\n (\2);/' \ -e's/$[^ ]\+$ *: *<cpufunc> \+$[^ ]*$ *:=/function \1 return \2 is/' \ + -e's/<cpunull>//' \ $< >$@ else $(hw-gfx-gma-config-ads): $(dir)/hw-gfx-gma-config.ads.template $(cnf) @@ -92,9 +93,11 @@ -e'/Dyn_CPU$_Var$\?/d' \ -e's/<$gen\|\(ilk\|hsw\|skl$$...$\?\)bool>/constant Boolean/' \ -e's/<$\(ilk\|hsw\|skl$$...$\?\)var>/constant/' \ + -e's/<cpunull>/ is null/' \ $< >$@ endif gfxinit-gen-y += $(hw-gfx-gma-config-ads) +gfxinit-$(CONFIG_GFX_GMA_DYN_CPU) += dyncpu/hw-gfx-gma-config.adb ifneq ($(filter G45,$(CONFIG_GFX_GMA_CPU)),) subdirs-y += g45 diff --git a/common/dyncpu/hw-gfx-gma-config.adb b/common/dyncpu/hw-gfx-gma-config.adb new file mode 100644 index 0000000..762ff6f --- /dev/null +++ b/common/dyncpu/hw-gfx-gma-config.adb @@ -0,0 +1,31 @@ +-- +-- Copyright (C) 2018 Nico Huber <nico.h(a)gmx.de> +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 2 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- + +package body HW.GFX.GMA.Config +is + + procedure Detect_CPU (Device : Word16) is + begin + for CPU in Gen_CPU_Type loop + for CPU_Var in Gen_CPU_Variant loop + if Is_GPU (Device, CPU, CPU_Var) then + Config.CPU := CPU; + Config.CPU_Var := CPU_Var; + exit; + end if; + end loop; + end loop; + end Detect_CPU; + +end HW.GFX.GMA.Config; diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 0cd1f89..c92f420 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -363,4 +363,8 @@ function Compatible_GPU (Device_Id : Word16) return Boolean is (Is_GPU (Device_Id, CPU, CPU_Var)); + pragma Warnings (GNATprove, Off, "subprogram ""Detect_CPU"" has no effect", + Reason => "only effective in dynamic cpu config"); + procedure Detect_CPU (Device : Word16)<cpunull>; + end HW.GFX.GMA.Config; diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 885072c..19eb42b 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -425,6 +425,7 @@ Dev.Read16 (Vendor, PCI.Vendor_Id); Dev.Read16 (Device, PCI.Device_Id); + Config.Detect_CPU (Device); Success := Vendor = 16#8086# and Config.Compatible_GPU (Device); end Check_Platform_PCI; begin -- To view, visit https://review.coreboot.org/27138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8ce31c867f97c8d6ef99ca096cb45f7719e78a19 Gerrit-Change-Number: 27138 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: sb/intel/i82801{g, j}x: Automatically generate ACPI PIRQ tables
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22981 ) Change subject: sb/intel/i82801{g,j}x: Automatically generate ACPI PIRQ tables ...................................................................... Patch Set 20: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29120/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75025/ : SUCCESS -- To view, visit https://review.coreboot.org/22981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I286d251ddf8fcae27dd07011a1cd62d8f4847683 Gerrit-Change-Number: 22981 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 17 Jun 2018 13:56:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/lars, lili: Add SPD mapping for Hynix 8GB config
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27135 ) Change subject: google/lars,lili: Add SPD mapping for Hynix 8GB config ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75024/ : SUCCESS -- To view, visit https://review.coreboot.org/27135 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf6588582da3b4a7861bced539d51a914b011dc4 Gerrit-Change-Number: 27135 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Jun 2018 13:23:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801{g, j}x: Automatically generate ACPI PIRQ tables
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22981 ) Change subject: sb/intel/i82801{g,j}x: Automatically generate ACPI PIRQ tables ...................................................................... Patch Set 19: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75023/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29119/ : SUCCESS -- To view, visit https://review.coreboot.org/22981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I286d251ddf8fcae27dd07011a1cd62d8f4847683 Gerrit-Change-Number: 22981 Gerrit-PatchSet: 19 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 17 Jun 2018 12:36:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: tianocore: Add more patches
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27137 ) Change subject: tianocore: Add more patches ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29118/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75022/ : SUCCESS -- To view, visit https://review.coreboot.org/27137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e2efea930b27749b1097607ab143ce2f91e79ec Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Jun 2018 09:16:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: tianocore: Fix RPM package name
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27136 ) Change subject: tianocore: Fix RPM package name ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29117/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75021/ : SUCCESS -- To view, visit https://review.coreboot.org/27136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61d537e4f1fca0d7172c129a75e13aa58452763f Gerrit-Change-Number: 27136 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Jun 2018 09:10:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: tianocore: Add more patches
by build bot (Jenkins) (Code Review) 17 Jun '18

17 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27137 ) Change subject: tianocore: Add more patches ...................................................................... Patch Set 1: (37 comments) https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… File payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch: https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 16: } else { DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 17: Length = strlen(Str); DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 18: if (Length < 4) { DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 19: - strncpy (TemStr + 4 - Length, Str, Length); DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 20: + memcpy (TemStr + 4 - Length, Str, Length); DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 21: } else { DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 22: - strncpy (TemStr, Str + Length - 4, 4); DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 23: + memcpy (TemStr, Str + Length - 4, 4); DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 24: } DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 25: DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 26: sscanf ( DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 28: // trailing whitespace https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 29: FitStartPtr = (FIT_TABLE *) RelativeAddress; DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 30: DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 31: - strncpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); // "_FIT_ " trailing whitespace https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 32: + memcpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); // "_FIT_ " trailing whitespace https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 33: assert (((VtfInfo->CompSize & 0x00FFFFFF) % 16) == 0); DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 34: FitStartPtr->CompSize = (VtfInfo->CompSize & 0x00FFFFFF) / 16; DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 35: FitStartPtr->CompVersion = MAKE_VERSION (VtfInfo->MajorVer, VtfInfo->MinorVer); DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 36: -- trailing whitespace https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… File payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch: https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 17: UINT8 BlockType; DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 18: EFI_HII_STRING_PACKAGE_HDR *PkgHeader; DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 19: DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 20: - if (mStringFileName == '\0' ) { DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 21: + if (mStringFileName == NULL ) { DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 22: return NULL; DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 23: } DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 24: DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 30: DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 31: StringPtr = ConfigAltResp; DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 32: DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 33: - while (StringPtr != L'\0') { DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 34: + while (StringPtr != NULL) { DOS line endings https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 35: // trailing whitespace https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 36: // 1. Find <ConfigHdr> GUID=...&NAME=...&PATH=... trailing whitespace https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 37: // trailing whitespace https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 38: -- trailing whitespace -- To view, visit https://review.coreboot.org/27137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e2efea930b27749b1097607ab143ce2f91e79ec Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Jun 2018 09:09:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: tianocore: Add more patches
by Patrick Rudolph (Code Review) 17 Jun '18

17 Jun '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27137 Change subject: tianocore: Add more patches ...................................................................... tianocore: Add more patches * Fix building BaseTools in hostgcc v8.1.0+ * Fix buidling tianocore on gcc v7.0.0+ Change-Id: I7e2efea930b27749b1097607ab143ce2f91e79ec Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- A payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch A payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch 2 files changed, 78 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/27137/1 diff --git a/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch b/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch new file mode 100644 index 0000000..06ddd56 --- /dev/null +++ b/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch @@ -0,0 +1,38 @@ +From b652262ed0dd554c44e7b1bf7134d3458f5edef1 Mon Sep 17 00:00:00 2001 +From: Patrick Rudolph <siro(a)das-labor.org> +Date: Sun, 17 Jun 2018 08:44:51 +0200 +Subject: [PATCH] BaseTools: Fix building with -Werror=stringop-truncation + +Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> +--- + BaseTools/Source/C/GenVtf/GenVtf.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/BaseTools/Source/C/GenVtf/GenVtf.c b/BaseTools/Source/C/GenVtf/GenVtf.c +index acc142a6d1..5d77016eba 100644 +--- a/BaseTools/Source/C/GenVtf/GenVtf.c ++++ b/BaseTools/Source/C/GenVtf/GenVtf.c +@@ -129,9 +129,9 @@ Returns: + } else { + Length = strlen(Str); + if (Length < 4) { +- strncpy (TemStr + 4 - Length, Str, Length); ++ memcpy (TemStr + 4 - Length, Str, Length); + } else { +- strncpy (TemStr, Str + Length - 4, 4); ++ memcpy (TemStr, Str + Length - 4, 4); + } + + sscanf ( +@@ -1529,7 +1529,7 @@ Returns: + // + FitStartPtr = (FIT_TABLE *) RelativeAddress; + +- strncpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); // "_FIT_ " ++ memcpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); // "_FIT_ " + assert (((VtfInfo->CompSize & 0x00FFFFFF) % 16) == 0); + FitStartPtr->CompSize = (VtfInfo->CompSize & 0x00FFFFFF) / 16; + FitStartPtr->CompVersion = MAKE_VERSION (VtfInfo->MajorVer, VtfInfo->MinorVer); +-- +2.17.0 + diff --git a/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch b/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch new file mode 100644 index 0000000..7016759 --- /dev/null +++ b/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch @@ -0,0 +1,40 @@ +From 5546ab29b2c0c2fc3a963bc71221918dc77b6152 Mon Sep 17 00:00:00 2001 +From: Patrick Rudolph <siro(a)das-labor.org> +Date: Sun, 17 Jun 2018 08:53:25 +0200 +Subject: [PATCH] gcc7: Fix building with -fpermissive + +Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> +--- + BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 2 +- + MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp +index 3ca57ed741..4fa066dd9f 100644 +--- a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp ++++ b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp +@@ -3372,7 +3372,7 @@ CVfrStringDB::GetVarStoreNameFormStringId ( + UINT8 BlockType; + EFI_HII_STRING_PACKAGE_HDR *PkgHeader; + +- if (mStringFileName == '\0' ) { ++ if (mStringFileName == NULL ) { + return NULL; + } + +diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c +index 857950118f..de0aa5f7bc 100644 +--- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c ++++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c +@@ -2181,7 +2181,7 @@ InternalHiiIfrValueAction ( + + StringPtr = ConfigAltResp; + +- while (StringPtr != L'\0') { ++ while (StringPtr != NULL) { + // + // 1. Find <ConfigHdr> GUID=...&NAME=...&PATH=... + // +-- +2.17.0 + -- To view, visit https://review.coreboot.org/27137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7e2efea930b27749b1097607ab143ce2f91e79ec Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: tianocore: Fix RPM package name
by Patrick Rudolph (Code Review) 17 Jun '18

17 Jun '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27136 Change subject: tianocore: Fix RPM package name ...................................................................... tianocore: Fix RPM package name The packge uuid-devel doesn't provide the required files, but libuuid-devel does. Change-Id: I61d537e4f1fca0d7172c129a75e13aa58452763f Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/external/tianocore/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/27136/1 diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index c942d30e..2f770d2 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -78,7 +78,7 @@ echo "#include <uuid/uuid.h>" > libtest.c echo "int main(int argc, char **argv) { (void) argc; (void) argv; return 0; }" >> libtest.c $(HOSTCC) $(HOSTCCFLAGS) libtest.c -o libtest >/dev/null 2>&1 && echo " found uuid-dev." || \ - ( echo " Not found."; echo "ERROR: please_install uuid-dev (uuid-devel)"; exit 1 ) + ( echo " Not found."; echo "ERROR: please_install uuid-dev (libuuid-devel)"; exit 1 ) rm -rf libtest.c libtest echo "Checking nasm..." type nasm > /dev/null 2>&1 && echo " found nasm." || \ -- To view, visit https://review.coreboot.org/27136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I61d537e4f1fca0d7172c129a75e13aa58452763f Gerrit-Change-Number: 27136 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018