coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: atlas: enable camera power and release reset
by build bot (Jenkins) (Code Review) 16 Jun '18

16 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27128 ) Change subject: atlas: enable camera power and release reset ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29104/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75008/ : SUCCESS -- To view, visit https://review.coreboot.org/27128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibaabf6c6f6a1dabaddd2fc47c820e090ca5984a5 Gerrit-Change-Number: 27128 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Sat, 16 Jun 2018 04:28:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: atlas: support i2c-hid trackpad
by build bot (Jenkins) (Code Review) 16 Jun '18

16 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27126 ) Change subject: atlas: support i2c-hid trackpad ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29102/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75006/ : SUCCESS -- To view, visit https://review.coreboot.org/27126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2702e61a6aa96250c0c09ea4bd15d0c671eedadc Gerrit-Change-Number: 27126 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Sat, 16 Jun 2018 04:26:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: atlas: enable touchscreen
by build bot (Jenkins) (Code Review) 16 Jun '18

16 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27127 ) Change subject: atlas: enable touchscreen ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29103/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75007/ : SUCCESS -- To view, visit https://review.coreboot.org/27127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21efafda3f2ae1dcea19e44f8d66f6dfaac1bb12 Gerrit-Change-Number: 27127 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Sat, 16 Jun 2018 04:24:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: atlas: enable touchscreen
by Caveh Jalali (Code Review) 16 Jun '18

16 Jun '18

Hello caveh jalali, I'd like you to do a code review. Please visit https://review.coreboot.org/27127 to review the following change. Change subject: atlas: enable touchscreen ...................................................................... atlas: enable touchscreen This adds the necessary config to enable touchscreen sensor in linux. BUG=b:110286344,b:110286345 BRANCH=none TEST=verified touch functionality using eval board Change-Id: I21efafda3f2ae1dcea19e44f8d66f6dfaac1bb12 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/atlas/gpio.c 2 files changed, 14 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/27127/1 diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 2789632..2de96a9 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -258,7 +258,18 @@ device pci 14.0 on end # USB xHCI device pci 14.1 on end # USB xDCI (OTG) device pci 14.2 on end # Thermal Subsystem - device pci 15.0 on end # I2C #0 - Touchscreen + device pci 15.0 on + chip drivers/i2c/hid + register "generic.hid" = ""ACPI0C50"" + register "generic.desc" = ""STM Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)" + register "generic.speed" = "I2C_SPEED_FAST" + register "generic.probed" = "1" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0xab" + device i2c 0x49 on end + end + end # I2C #0 - Touchscreen device pci 15.1 off end # I2C #1 device pci 15.2 on chip drivers/i2c/hid diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c index acaa225..3a7b722 100644 --- a/src/mainboard/google/poppy/variants/atlas/gpio.c +++ b/src/mainboard/google/poppy/variants/atlas/gpio.c @@ -156,7 +156,7 @@ /* C21 : UART2_TXD ==> PCHTX_SERVORX_UART */ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), /* C22 : UART2_RTS# ==> EN_PP3300_DX_TOUCHSCREEN */ - PAD_CFG_GPO(GPP_C22, 0, DEEP), + PAD_CFG_GPO(GPP_C22, 1, DEEP), /* C23 : UART2_CTS# ==> PCH_WP */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP), @@ -232,7 +232,7 @@ /* E10 : USB2_OC1# ==> USB_C1_OC_ODL */ PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1), /* E11 : USB2_OC2# ==> TOUCHSCREEN_RESET_L */ - PAD_CFG_GPO(GPP_E11, 0, DEEP), + PAD_CFG_GPO(GPP_E11, 1, DEEP), /* E12 : USB2_OC3# ==> NC */ PAD_CFG_NC(GPP_E12), /* E13 : DDPB_HPD0 ==> USB_C1_DP_HPD */ -- To view, visit https://review.coreboot.org/27127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I21efafda3f2ae1dcea19e44f8d66f6dfaac1bb12 Gerrit-Change-Number: 27127 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: atlas: enable camera power and release reset
by Caveh Jalali (Code Review) 16 Jun '18

16 Jun '18

Hello caveh jalali, I'd like you to do a code review. Please visit https://review.coreboot.org/27128 to review the following change. Change subject: atlas: enable camera power and release reset ...................................................................... atlas: enable camera power and release reset This is a temporary hack to test camera presence before we have full camera support implemented. Basically, we can now probe the camera over i2c to verify that it's connected and the camera LED turns on. BUG=b:80106316 BRANCH=none TEST=camera LED comes on and camera can be probed over i2c. Change-Id: Ibaabf6c6f6a1dabaddd2fc47c820e090ca5984a5 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/27128/1 diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c index 3a7b722..b374265 100644 --- a/src/mainboard/google/poppy/variants/atlas/gpio.c +++ b/src/mainboard/google/poppy/variants/atlas/gpio.c @@ -177,7 +177,7 @@ /* D7 : ISH_I2C1_SDA ==> SPKR_IRQ_L */ PAD_CFG_GPI_APIC(GPP_D7, NONE, PLTRST), /* D8 : ISH_I2C1_SCL ==> EN_CAMERA_PWR */ - PAD_CFG_GPO(GPP_D8, 0, DEEP), + PAD_CFG_GPO(GPP_D8, 1, DEEP), /* D9 : ISH_SPI_CS# ==> ISH_SPI_CS_L */ PAD_CFG_NF_1V8(GPP_D9, NONE, DEEP, NF1), /* D10 : ISH_SPI_CLK ==> ISH_SPI_CLK */ @@ -195,9 +195,9 @@ /* D16 : ISH_UART0_CTS# ==> NC */ PAD_CFG_NC(GPP_D16), /* D17 : DMIC_CLK1 ==> PCH_CAMERA_RESET */ - PAD_CFG_GPO(GPP_D17, 0, DEEP), + PAD_CFG_GPO(GPP_D17, 1, DEEP), /* D18 : DMIC_DATA1 ==> PCH_CAMERA_CLOCK_ENABLE */ - PAD_CFG_GPO(GPP_D18, 0, DEEP), + PAD_CFG_GPO(GPP_D18, 1, DEEP), /* D19 : DMIC_CLK0 ==> PCH_DMIC_CLK_OUT */ PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), /* D20 : DMIC_DATA0 ==> PCH_DMIC_DATA_IN */ -- To view, visit https://review.coreboot.org/27128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibaabf6c6f6a1dabaddd2fc47c820e090ca5984a5 Gerrit-Change-Number: 27128 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: atlas: support i2c-hid trackpad
by Caveh Jalali (Code Review) 16 Jun '18

16 Jun '18

Hello caveh jalali, I'd like you to do a code review. Please visit https://review.coreboot.org/27126 to review the following change. Change subject: atlas: support i2c-hid trackpad ...................................................................... atlas: support i2c-hid trackpad We plan to use i2c-hid compatible trackpads on atlas, so this switches the trackpad config to i2c-hid. BUG=b:80662079 BRANCH=none TEST=used trackpad to verify motion tracking Change-Id: I2702e61a6aa96250c0c09ea4bd15d0c671eedadc Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/27126/1 diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 7742a83..2789632 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -261,12 +261,12 @@ device pci 15.0 on end # I2C #0 - Touchscreen device pci 15.1 off end # I2C #1 device pci 15.2 on - chip drivers/i2c/generic - register "hid" = ""ELAN0000"" - register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)" - register "wake" = "GPE0_DW0_23" # GPP_A23 - register "probed" = "1" # may not be present + chip drivers/i2c/hid + register "generic.hid" = ""ACPI0C50"" + register "generic.desc" = ""ELAN Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)" + register "generic.wake" = "GPE0_DW0_23" # GPP_A23 + register "hid_desc_reg_offset" = "0x01" device i2c 0x15 on end end end # I2C #2 - Trackpad -- To view, visit https://review.coreboot.org/27126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2702e61a6aa96250c0c09ea4bd15d0c671eedadc Gerrit-Change-Number: 27126 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: mb/lenovo/t400: Enable PCIe port on dock
by Nico Huber (Code Review) 15 Jun '18

15 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27121 ) Change subject: mb/lenovo/t400: Enable PCIe port on dock ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27121/1/src/mainboard/lenovo/t400/devicetre… File src/mainboard/lenovo/t400/devicetree.cb: https://review.coreboot.org/#/c/27121/1/src/mainboard/lenovo/t400/devicetre… PS1, Line 76: register "pcie_power_limits" = "{ { 10, 0 }, { 10, 0 }, { 0, 0 }, { 10, 0 }, { 0, 0 }, { 0, 0 } }" : register "pcie_hotplug_map" = "{ 0, 0, 0, 1, 0, 0, 0, 0 }" what about these? -- To view, visit https://review.coreboot.org/27121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ad8a37988f2b6b5974ce0bdb565a7729e6dd15d Gerrit-Change-Number: 27121 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 16 Jun 2018 00:53:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/asus/p8h61-m_pro: Add new mainboard
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26419 ) Change subject: mb/asus/p8h61-m_pro: Add new mainboard ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29101/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75004/ : SUCCESS -- To view, visit https://review.coreboot.org/26419 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e89ebe43a2e1ff0308f4876e98bbf2f5a0d85f2 Gerrit-Change-Number: 26419 Gerrit-PatchSet: 7 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 16 Jun 2018 00:23:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/asus/p8h61-m_pro: Add new mainboard
by build bot (Jenkins) (Code Review) 15 Jun '18

15 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26419 ) Change subject: mb/asus/p8h61-m_pro: Add new mainboard ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29100/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75003/ : SUCCESS -- To view, visit https://review.coreboot.org/26419 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e89ebe43a2e1ff0308f4876e98bbf2f5a0d85f2 Gerrit-Change-Number: 26419 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 16 Jun 2018 00:13:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by Rajmohan Mani (Code Review) 15 Jun '18

15 Jun '18

Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl: https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants… PS3, Line 167: 1 > 32 […] This is applicable only when writing. We don't intend to write to the NVM. Please ignore this comment. https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl: https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants… PS3, Line 136: 1 > 32 […] This is applicable only when writing. We don't intend to write to the NVM. Please ignore this comment. -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 23:50:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018