coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in libgfxinit[master]: gma pipe setup: Refactor calculation to ease proof
by Nico Huber (Code Review) 18 Jun '18

18 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27152 Change subject: gma pipe setup: Refactor calculation to ease proof ...................................................................... gma pipe setup: Refactor calculation to ease proof Somehow GNATprove stumbles here when code changes elsewhere. Let's make him focus on the linear-offset calculation. Change-Id: Id5def319993b34144473984ca25c71d92c957180 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-pipe_setup.adb 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/52/27152/1 diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb index 10afbfd..647ba35 100644 --- a/common/hw-gfx-gma-pipe_setup.adb +++ b/common/hw-gfx-gma-pipe_setup.adb @@ -259,11 +259,16 @@ Registers.Write (Controller.DSPSTRIDE, Word32 (Pixel_To_Bytes (FB.Stride, FB))); if Config.Has_DSP_Linoff and then FB.Tiling = Linear then - Registers.Write - (Register => Controller.DSPLINOFF, - Value => Word32 (Pixel_To_Bytes - (FB.Start_Y * FB.Stride + FB.Start_X, FB))); - Registers.Write (Controller.DSPTILEOFF, 0); + pragma Assert_And_Cut (True); + declare + Linear_Offset : constant Pixel_Type := + FB.Start_Y * FB.Stride + FB.Start_X; + begin + Registers.Write + (Register => Controller.DSPLINOFF, + Value => Word32 (Pixel_To_Bytes (Linear_Offset, FB))); + Registers.Write (Controller.DSPTILEOFF, 0); + end; else if Config.Has_DSP_Linoff then Registers.Write (Controller.DSPLINOFF, 0); -- To view, visit https://review.coreboot.org/27152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id5def319993b34144473984ca25c71d92c957180 Gerrit-Change-Number: 27152 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: soc/intel/common: Add support to configure top swap feature
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25805 ) Change subject: soc/intel/common: Add support to configure top swap feature ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75050/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29143/ : SUCCESS -- To view, visit https://review.coreboot.org/25805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea31b891f81e76d4d623fcb68183c3ad3dcadbad Gerrit-Change-Number: 25805 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Mon, 18 Jun 2018 15:15:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: config to insert ucode address in second FIT
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27151 ) Change subject: Kconfig: config to insert ucode address in second FIT ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75049/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29142/ : SUCCESS -- To view, visit https://review.coreboot.org/27151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ee41d90bae34862aa68c9b8bd69288de1335585 Gerrit-Change-Number: 27151 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Jun 2018 15:12:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: config to insert ucode address in second FIT
by Rizwan Qureshi (Code Review) 18 Jun '18

18 Jun '18

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/27151 Change subject: Kconfig: config to insert ucode address in second FIT ...................................................................... Kconfig: config to insert ucode address in second FIT Add a config to insert the address of a FMAP region (which should hold a microcode) as the first entry in the second FIT. Change-Id: I4ee41d90bae34862aa68c9b8bd69288de1335585 Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> --- M Makefile.inc M src/soc/intel/Kconfig 2 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/27151/1 diff --git a/Makefile.inc b/Makefile.inc index 16d6f18..f8e134e 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1005,6 +1005,10 @@ $(RMODTOOL) -i $(CONFIG_REFCODE_BLOB_FILE) -o $@ endif +ifneq ($(CONFIG_TOP_SWAP_FIT_ENTRY),"") +FIT_OPTIONS := -j $(CONFIG_INTEL_TOP_SWAP_BOOTBLOCK_SIZE) -q $(CONFIG_TOP_SWAP_FIT_ENTRY) +endif + $(obj)/coreboot.rom: $(obj)/coreboot.pre $(objcbfs)/ramstage.elf $(CBFSTOOL) $$(INTERMEDIATE) @printf " CBFS $(subst $(obj)/,,$(@))\n" # The full ROM may be larger than the CBFS part, so create an empty @@ -1022,12 +1026,14 @@ ifeq ($(CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE),y) ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER),y) @printf " UPDATE-FIT\n" - $(CBFSTOOL) $@.tmp update-fit -n cpu_microcode_blob.bin -x $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) + $(CBFSTOOL) $@.tmp update-fit -n cpu_microcode_blob.bin -x $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ + $(FIT_OPTIONS) endif ifeq ($(CONFIG_CPU_MICROCODE_CBFS_GENERATE),y) @printf " UPDATE-FIT\n" - $(CBFSTOOL) $@.tmp update-fit -n cpu_microcode_blob.bin -x $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) + $(CBFSTOOL) $@.tmp update-fit -n cpu_microcode_blob.bin -x $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ + $(FIT_OPTIONS) endif endif mv $@.tmp $@ diff --git a/src/soc/intel/Kconfig b/src/soc/intel/Kconfig index a80101a..1e4b1c5 100644 --- a/src/soc/intel/Kconfig +++ b/src/soc/intel/Kconfig @@ -28,3 +28,10 @@ hex depends on INTEL_TOP_SWAP_BOOTBLOCK default C_ENV_BOOTBLOCK_SIZE if C_ENVIRONMENT_BOOTBLOCK + +config TOP_SWAP_FIT_ENTRY + string + depends on INTEL_TOP_SWAP_BOOTBLOCK + help + Use thi config to insert the address of a FMAP region (which should + hold a microcode) as the first entry in the second FIT. -- To view, visit https://review.coreboot.org/27151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4ee41d90bae34862aa68c9b8bd69288de1335585 Gerrit-Change-Number: 27151 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: lib/prog_loaders: Move argument selection into selfload
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25861 ) Change subject: lib/prog_loaders: Move argument selection into selfload ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29139/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75046/ : SUCCESS -- To view, visit https://review.coreboot.org/25861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I994f604fc4501e0e3b00165819f796b1b8275d8c Gerrit-Change-Number: 25861 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Jun 2018 13:28:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib: Add FIT payload support
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: lib: Add FIT payload support ...................................................................... Patch Set 35: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29140/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75047/ : SUCCESS -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 35 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph Gerrit-Comment-Date: Mon, 18 Jun 2018 13:25:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib: Raw import FIT parser
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25739 ) Change subject: lib: Raw import FIT parser ...................................................................... Patch Set 15: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29138/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75045/ : SUCCESS -- To view, visit https://review.coreboot.org/25739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 15 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Jun 2018 13:19:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib: Add FIT payload support
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: lib: Add FIT payload support ...................................................................... Patch Set 35: (4 comments) https://review.coreboot.org/#/c/25019/35/src/arch/arm64/fit_payload.c File src/arch/arm64/fit_payload.c: https://review.coreboot.org/#/c/25019/35/src/arch/arm64/fit_payload.c@102 PS35, Line 102: if (scratch.header.image_size) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25019/35/src/include/fit.h File src/include/fit.h: https://review.coreboot.org/#/c/25019/35/src/include/fit.h@49 PS35, Line 49: const char* compat_string; "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/25019/35/src/lib/fit.c File src/lib/fit.c: https://review.coreboot.org/#/c/25019/35/src/lib/fit.c@66 PS35, Line 66: if ((board_id() != UNDEFINED_STRAPPING_ID)) { Unnecessary parentheses https://review.coreboot.org/#/c/25019/35/src/lib/fit.c@284 PS35, Line 284: * Kernel likes its availabe memory areas at least 1MB 'availabe' may be misspelled - perhaps 'available'? -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 35 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph Gerrit-Comment-Date: Mon, 18 Jun 2018 13:15:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib: Raw import FIT parser
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25739 ) Change subject: lib: Raw import FIT parser ...................................................................... Patch Set 15: (13 comments) https://review.coreboot.org/#/c/25739/15/src/include/fit.h File src/include/fit.h: https://review.coreboot.org/#/c/25739/15/src/include/fit.h@28 PS15, Line 28: { open brace '{' following enum go on the same line https://review.coreboot.org/#/c/25739/15/src/include/fit.h@36 PS15, Line 36: { open brace '{' following struct go on the same line https://review.coreboot.org/#/c/25739/15/src/include/fit.h@46 PS15, Line 46: { open brace '{' following struct go on the same line https://review.coreboot.org/#/c/25739/15/src/lib/fit.c File src/lib/fit.c: https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@194 PS15, Line 194: const char *path[] = { "chosen", NULL }; char * array declaration might be better as static const https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@202 PS15, Line 202: const char *path[] = { "chosen", NULL }; char * array declaration might be better as static const https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@225 PS15, Line 225: { open brace '{' following struct go on the same line https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@226 PS15, Line 226: unsigned addr_cells; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@227 PS15, Line 227: unsigned size_cells; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@231 PS15, Line 231: static uint64_t max_range(unsigned size_cells) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@242 PS15, Line 242: unsigned *count = (unsigned *)params->data; Prefer 'unsigned int *' to bare use of 'unsigned *' https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@242 PS15, Line 242: unsigned *count = (unsigned *)params->data; Prefer 'unsigned int *' to bare use of 'unsigned *' https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@298 PS15, Line 298: * Kernel likes its availabe memory areas at least 1MB 'availabe' may be misspelled - perhaps 'available'? https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@323 PS15, Line 323: unsigned count = 0; Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/25739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 15 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Jun 2018 13:14:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Documentation: Add cavium SoC and mainboard
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27150 ) Change subject: Documentation: Add cavium SoC and mainboard ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29137/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75044/ : SUCCESS -- To view, visit https://review.coreboot.org/27150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfcd42788e31f684baed658dc3c4dfe1b8e4f354 Gerrit-Change-Number: 27150 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Jun 2018 12:24:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018