coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: WIP src/soc/intel/common/block/gpio: Add debug prints for gpio driver
by Bora Guvendik (Code Review) 18 Jun '18

18 Jun '18

Bora Guvendik has abandoned this change. ( https://review.coreboot.org/23199 ) Change subject: WIP src/soc/intel/common/block/gpio: Add debug prints for gpio driver ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/23199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Icee004e720883fb55e7b0e22a2d6bd0e76989073 Gerrit-Change-Number: 23199 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP]cbfstool: Always add compression attribute
by Julius Werner (Code Review) 18 Jun '18

18 Jun '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/27115 ) Change subject: [WIP]cbfstool: Always add compression attribute ...................................................................... Patch Set 2: Code-Review-1 I am not sure what you want to do with this, so I'm gonna go with cautious disagreement unless you convince me that this is really needed for some reason. Stage compression and full content compression are two different things. They use the same algorithms under the hood, but the way they're packaged is different and we'd better not confuse the two. The compression attribute is only used for the full content version, and it's more than informational... it actually tells coreboot how to treat the whole contents of that CBFS file. So if you set that on a stage or payload, that would mean that coreboot should try to decompress that full file content (including the stage or payload header) with the given algorithm, which will obviously not work. (Whether the current CBFS code would actually try to do that or not I'm not sure, but regardless I think that would be the most logical interpretation of the data.) cbfstool can already show you the stage and payload compression algorithms, you just have to call print with -v so it will show you individual stage/payload components. If your only gripe here is that cbfstool print without -v shows 'none' on those files, I'd be fine with just changing the output to use the algorithm from the stage or the biggest payload section there. (Still, technically, 'none' is correct because the stage or payload header is always uncompressed. Stages and especially payloads are essentially container formats. Parts of the container may be internally compressed, but we never compress the whole thing.) -- To view, visit https://review.coreboot.org/27115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03927dcbd486602f54210a344d5cc7af2265c965 Gerrit-Change-Number: 27115 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Jun 2018 23:43:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Enable camera sensors
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26283 ) Change subject: mainboard/google/nocturne: Enable camera sensors ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29146/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75053/ : SUCCESS -- To view, visit https://review.coreboot.org/26283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c877df8062d5c79e25ed27775ab58e977555db Gerrit-Change-Number: 26283 Gerrit-PatchSet: 8 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward #1002003 Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Mon, 18 Jun 2018 18:02:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29145/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75052/ : SUCCESS -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Comment-Date: Mon, 18 Jun 2018 17:54:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by Lijian Zhao (Code Review) 18 Jun '18

18 Jun '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl: https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants… PS3, Line 155: Name (_CRS, ResourceTemplate () > Since the NVM0 requires the IMX355 sensor module to be powered, we should also be adding the depende […] Done -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Comment-Date: Mon, 18 Jun 2018 17:51:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by Lijian Zhao (Code Review) 18 Jun '18

18 Jun '18

Hello build bot (Jenkins), Chiranjeevi Rapolu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27094 to look at the new patch set (#4). Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... mainboard/google/nocturne: Set camera power sequence To make image senor working, the intended power sequence need to applied. BUG=NONE TEST=NONE Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h 3 files changed, 82 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/27094/4 -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Rajmohan Mani <rajmohan.mani(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/common: Add support to configure top swap feature
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25805 ) Change subject: soc/intel/common: Add support to configure top swap feature ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75051/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29144/ : SUCCESS -- To view, visit https://review.coreboot.org/25805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea31b891f81e76d4d623fcb68183c3ad3dcadbad Gerrit-Change-Number: 25805 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Mon, 18 Jun 2018 17:27:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: Allow creating a second bootblock
by build bot (Jenkins) (Code Review) 18 Jun '18

18 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22533 ) Change subject: Kconfig: Allow creating a second bootblock ...................................................................... Patch Set 5: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75048/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29141/ : SUCCESS -- To view, visit https://review.coreboot.org/22533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bbd19c35871891b762a0673f840858d972e129e Gerrit-Change-Number: 22533 Gerrit-PatchSet: 5 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Mon, 18 Jun 2018 15:23:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma pipe setup: Fix secondary pipe cursors <= Sandy Bridge
by Nico Huber (Code Review) 18 Jun '18

18 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27154 Change subject: gma pipe setup: Fix secondary pipe cursors <= Sandy Bridge ...................................................................... gma pipe setup: Fix secondary pipe cursors <= Sandy Bridge The secondary cursor registers used to have a different offset. Change-Id: I4d79f59a8cb693d73d6da666525f091021efb4fd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-pipe_setup.adb M common/hw-gfx-gma-pipe_setup.ads M common/hw-gfx-gma-registers.ads M common/hw-gfx-gma.ads 5 files changed, 81 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/54/27154/1 diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index c4f68ea..f7eb59d 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -151,7 +151,7 @@ Has_Plane_Control : <genbool> := Broxton_On; Has_DSP_Linoff : <genbool> := Up_To_Ironlake; Has_PF_Pipe_Select : <ilkhswbool> := CPU_Ivybridge or CPU_Haswell; - Has_Cursor_FBC_Control : <ilkbool> := Ivybridge_On; + Has_Ivybridge_Cursors : <ilkbool> := Ivybridge_On; VGA_Plane_Workaround : <ilkbool> := CPU_Ivybridge; Has_GMCH_DP_Transcoder : <genbool> := Gen_G45; Has_GMCH_VGACNTRL : <genbool> := Gen_G45; diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb index 656eb13..93b5e05 100644 --- a/common/hw-gfx-gma-pipe_setup.adb +++ b/common/hw-gfx-gma-pipe_setup.adb @@ -15,7 +15,6 @@ with HW.Debug; with GNAT.Source_Info; -with HW.GFX.GMA.Config; with HW.GFX.GMA.Transcoder; package body HW.GFX.GMA.Pipe_Setup is @@ -352,7 +351,7 @@ -- on some platforms writing CUR_CTL disables self-arming of CUR_POS -- so keep it first Registers.Write - (Register => Controllers (Pipe).CUR_CTL, + (Register => Cursors (Pipe).CTL, Value => CUR_CTL_PIPE_SELECT (Pipe) or CUR_CTL_MODE (Cursor.Mode, Cursor.Size)); Place_Cursor (Pipe, FB, Cursor); @@ -376,11 +375,11 @@ Y := -Width; end if; Registers.Write - (Register => Controllers (Pipe).CUR_POS, + (Register => Cursors (Pipe).POS, Value => CUR_POS_Y (Y) or CUR_POS_X (X)); -- write to CUR_BASE always arms other CUR_* registers Registers.Write - (Register => Controllers (Pipe).CUR_BASE, + (Register => Cursors (Pipe).BASE, Value => Shift_Left (Word32 (Cursor.GTT_Offset), 12)); end Place_Cursor; @@ -692,11 +691,13 @@ ---------------------------------------------------------------------------- - procedure Planes_Off (Controller : Controller_Type) is + procedure Planes_Off (Controller : Controller_Type; CUR : Cursor_Regs) + is + use type Registers.Registers_Invalid_Index; begin - Registers.Write (Controller.CUR_CTL, 16#0000_0000#); - if Config.Has_Cursor_FBC_Control then - Registers.Write (Controller.CUR_FBC_CTL, 16#0000_0000#); + Registers.Write (CUR.CTL, 16#0000_0000#); + if CUR.FBC_CTL /= Registers.Invalid_Register then + Registers.Write (CUR.FBC_CTL, 16#0000_0000#); end if; Registers.Unset_Mask (Controller.SPCNTR, DSPCNTR_ENABLE); if Config.Has_Plane_Control then @@ -713,7 +714,7 @@ begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); - Planes_Off (Controllers (Pipe)); + Planes_Off (Controllers (Pipe), Cursors (Pipe)); Transcoder.Off (Pipe); Panel_Fitter_Off (Controllers (Pipe)); Transcoder.Clk_Off (Pipe); @@ -739,7 +740,7 @@ Legacy_VGA_Off; for Pipe in Pipe_Index loop - Planes_Off (Controllers (Pipe)); + Planes_Off (Controllers (Pipe), Cursors (Pipe)); Transcoder.Off (Pipe); Panel_Fitter_Off (Controllers (Pipe)); Transcoder.Clk_Off (Pipe); diff --git a/common/hw-gfx-gma-pipe_setup.ads b/common/hw-gfx-gma-pipe_setup.ads index fe877ad..0edb0c9 100644 --- a/common/hw-gfx-gma-pipe_setup.ads +++ b/common/hw-gfx-gma-pipe_setup.ads @@ -12,6 +12,7 @@ -- GNU General Public License for more details. -- +with HW.GFX.GMA.Config; with HW.GFX.GMA.Registers; use type HW.Int32; @@ -78,10 +79,6 @@ DSPSURF : Registers.Registers_Index; DSPTILEOFF : Registers.Registers_Index; SPCNTR : Registers.Registers_Index; - CUR_CTL : Registers.Registers_Index; - CUR_BASE : Registers.Registers_Index; - CUR_POS : Registers.Registers_Index; - CUR_FBC_CTL : Registers.Registers_Index; -- Skylake registers (partially aliased) PLANE_CTL : Registers.Registers_Index; PLANE_OFFSET : Registers.Registers_Index; @@ -117,10 +114,6 @@ DSPSURF => Registers.DSPASURF, DSPTILEOFF => Registers.DSPATILEOFF, SPCNTR => Registers.SPACNTR, - CUR_CTL => Registers.CUR_CTL_A, - CUR_BASE => Registers.CUR_BASE_A, - CUR_POS => Registers.CUR_POS_A, - CUR_FBC_CTL => Registers.CUR_FBC_CTL_A, PLANE_CTL => Registers.DSPACNTR, PLANE_OFFSET => Registers.DSPATILEOFF, PLANE_POS => Registers.PLANE_POS_1_A, @@ -166,10 +159,6 @@ DSPSURF => Registers.DSPBSURF, DSPTILEOFF => Registers.DSPBTILEOFF, SPCNTR => Registers.SPBCNTR, - CUR_CTL => Registers.CUR_CTL_B, - CUR_BASE => Registers.CUR_BASE_B, - CUR_POS => Registers.CUR_POS_B, - CUR_FBC_CTL => Registers.CUR_FBC_CTL_B, PLANE_CTL => Registers.DSPBCNTR, PLANE_OFFSET => Registers.DSPBTILEOFF, PLANE_POS => Registers.PLANE_POS_1_B, @@ -215,10 +204,6 @@ DSPSURF => Registers.DSPCSURF, DSPTILEOFF => Registers.DSPCTILEOFF, SPCNTR => Registers.SPCCNTR, - CUR_CTL => Registers.CUR_CTL_C, - CUR_BASE => Registers.CUR_BASE_C, - CUR_POS => Registers.CUR_POS_C, - CUR_FBC_CTL => Registers.CUR_FBC_CTL_C, PLANE_CTL => Registers.DSPCCNTR, PLANE_OFFSET => Registers.DSPCTILEOFF, PLANE_POS => Registers.PLANE_POS_1_C, @@ -252,4 +237,40 @@ Registers.CUR_WM_C_6, Registers.CUR_WM_C_7))); + type Cursor_Regs is record + CTL : Registers.Registers_Index; + BASE : Registers.Registers_Index; + POS : Registers.Registers_Index; + FBC_CTL : Registers.Registers_Invalid_Index; + end record; + + function Cursors (Pipe : Pipe_Index) return Cursor_Regs is + (if not Config.Has_Ivybridge_Cursors then + (if Pipe = Primary then + (CTL => Registers.CURACNTR, + BASE => Registers.CURABASE, + POS => Registers.CURAPOS, + FBC_CTL => Registers.Invalid_Register) + else + (CTL => Registers.CURBCNTR, + BASE => Registers.CURBBASE, + POS => Registers.CURBPOS, + FBC_CTL => Registers.Invalid_Register)) + else + (if Pipe = Primary then + (CTL => Registers.CUR_CTL_A, + BASE => Registers.CUR_BASE_A, + POS => Registers.CUR_POS_A, + FBC_CTL => Registers.CUR_FBC_CTL_A) + elsif Pipe = Secondary then + (CTL => Registers.CUR_CTL_B, + BASE => Registers.CUR_BASE_B, + POS => Registers.CUR_POS_B, + FBC_CTL => Registers.CUR_FBC_CTL_B) + else + (CTL => Registers.CUR_CTL_C, + BASE => Registers.CUR_BASE_C, + POS => Registers.CUR_POS_C, + FBC_CTL => Registers.CUR_FBC_CTL_C))); + end HW.GFX.GMA.Pipe_Setup; diff --git a/common/hw-gfx-gma-registers.ads b/common/hw-gfx-gma-registers.ads index ac0f023..5cffe76 100644 --- a/common/hw-gfx-gma-registers.ads +++ b/common/hw-gfx-gma-registers.ads @@ -473,6 +473,9 @@ CUR_BASE_A, CUR_POS_A, CUR_FBC_CTL_A, + CURBCNTR, + CURBBASE, + CURBPOS, CUR_WM_A_0, CUR_WM_A_1, CUR_WM_A_2, @@ -927,6 +930,9 @@ PS_CTRL_2_B => 16#06_8a80# / Register_Width, -- cursor control + CURBCNTR => 16#07_00c0# / Register_Width, -- <= SNB + CURBBASE => 16#07_00c4# / Register_Width, -- <= SNB + CURBPOS => 16#07_00c8# / Register_Width, -- <= SNB CUR_CTL_B => 16#07_1080# / Register_Width, CUR_BASE_B => 16#07_1084# / Register_Width, CUR_POS_B => 16#07_1088# / Register_Width, @@ -1632,6 +1638,9 @@ GMCH_ADPA : constant Registers_Index := FDI_TX_CTL_B; GMCH_HDMIB : constant Registers_Index := GMCH_SDVOB; GMCH_HDMIC : constant Registers_Index := GMCH_SDVOC; + CURACNTR : constant Registers_Index := CUR_CTL_A; + CURABASE : constant Registers_Index := CUR_BASE_A; + CURAPOS : constant Registers_Index := CUR_POS_A; --------------------------------------------------------------------------- diff --git a/common/hw-gfx-gma.ads b/common/hw-gfx-gma.ads index 3804cd4..d1acc69 100644 --- a/common/hw-gfx-gma.ads +++ b/common/hw-gfx-gma.ads @@ -126,12 +126,19 @@ Proof_In => (Init_State)), Pre => Is_Initialized; + pragma Warnings (GNATprove, Off, "no check message justified by this", + Reason => "see Annotate aspects."); procedure Update_Cursor (Pipe : Pipe_Index; Cursor : Cursor_Type) with Global => - (In_Out => (State, Device_State), + (Input => (Config_State), + In_Out => (State, Device_State), Proof_In => (Init_State)), - Pre => Is_Initialized; + Pre => Is_Initialized, + Annotate => + (GNATprove, Intentional, + "global input ""GMA.Config_State"" of ""Update_Cursor"" not read", + "Reading of Config_State depends on the platform configuration."); procedure Place_Cursor (Pipe : Pipe_Index; @@ -139,9 +146,14 @@ Y : Cursor_Pos) with Global => - (In_Out => (State, Device_State), + (Input => (Config_State), + In_Out => (State, Device_State), Proof_In => (Init_State)), - Pre => Is_Initialized; + Pre => Is_Initialized, + Annotate => + (GNATprove, Intentional, + "global input ""GMA.Config_State"" of ""Place_Cursor"" not read", + "Reading of Config_State depends on the platform configuration."); procedure Move_Cursor (Pipe : Pipe_Index; @@ -149,9 +161,14 @@ Y : Cursor_Pos) with Global => - (In_Out => (State, Device_State), + (Input => (Config_State), + In_Out => (State, Device_State), Proof_In => (Init_State)), - Pre => Is_Initialized; + Pre => Is_Initialized, + Annotate => + (GNATprove, Intentional, + "global input ""GMA.Config_State"" of ""Move_Cursor"" not read", + "Reading of Config_State depends on the platform configuration."); ---------------------------------------------------------------------------- @@ -188,8 +205,6 @@ Proof_In => (Init_State)), Pre => Is_Initialized and HW.Config.Dynamic_MMIO; - pragma Warnings (GNATprove, Off, "no check message justified by this", - Reason => "see Annotate aspects."); procedure Map_Linear_FB (Linear_FB : out Word64; FB : in Framebuffer_Type) with Global => -- To view, visit https://review.coreboot.org/27154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4d79f59a8cb693d73d6da666525f091021efb4fd Gerrit-Change-Number: 27154 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma: Fix Ironlake panel fitting, revisited
by Nico Huber (Code Review) 18 Jun '18

18 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27153 Change subject: gma: Fix Ironlake panel fitting, revisited ...................................................................... gma: Fix Ironlake panel fitting, revisited This time avoid scaling to odd heights, too. At least Sandy Bridge has trouble with this. Change-Id: Ib7dfe1fd289661ecd6949eca4b39860dbecc4463 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-pipe_setup.adb 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/53/27153/1 diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb index 647ba35..656eb13 100644 --- a/common/hw-gfx-gma-pipe_setup.adb +++ b/common/hw-gfx-gma-pipe_setup.adb @@ -513,6 +513,10 @@ if Width < Mode.H_Visible and Width mod 2 = 1 then Width := Width + 1; end if; + -- Do not scale to odd height (at least Sandy Bridge makes trouble). + if Height < Mode.V_Visible and Height mod 2 = 1 then + Height := Height + 1; + end if; X := (Mode.H_Visible - Width) / 2; Y := (Mode.V_Visible - Height) / 2; -- To view, visit https://review.coreboot.org/27153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7dfe1fd289661ecd6949eca4b39860dbecc4463 Gerrit-Change-Number: 27153 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018