coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 ) Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ...................................................................... Patch Set 41: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29170/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75081/ : SUCCESS -- To view, visit https://review.coreboot.org/26132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a Gerrit-Change-Number: 26132 Gerrit-PatchSet: 41 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 10:01:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Enable Synaptics touchpad device
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27159 ) Change subject: mb/google/octopus: Enable Synaptics touchpad device ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75080/ : SUCCESS -- To view, visit https://review.coreboot.org/27159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc1e8c35a9de54ed04187fcf219a72a592d3bd81 Gerrit-Change-Number: 27159 Gerrit-PatchSet: 2 Gerrit-Owner: Xingyu Wu <wuxy(a)bitland.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 07:33:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Enable Synaptics touchpad device
by Xingyu Wu (Code Review) 19 Jun '18

19 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27159 to look at the new patch set (#2). Change subject: mb/google/octopus: Enable Synaptics touchpad device ...................................................................... mb/google/octopus: Enable Synaptics touchpad device This change adds Synaptcs device to phaser project. BUG=b:110236590 TEST=emerge-octopus coreboot chromeos-bootimage reflash the coreboot to DUT,make sure the Synaptics Touchpad can work. Change-Id: Icc1e8c35a9de54ed04187fcf219a72a592d3bd81 Signed-off-by: Xingyu <wuxy(a)bitland.corp-partner.google.com> --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/27159/2 -- To view, visit https://review.coreboot.org/27159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icc1e8c35a9de54ed04187fcf219a72a592d3bd81 Gerrit-Change-Number: 27159 Gerrit-PatchSet: 2 Gerrit-Owner: Xingyu Wu <wuxy(a)bitland.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus: Enable Synaptics touchpad device
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27159 ) Change subject: mb/google/octopus: Enable Synaptics touchpad device ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75079/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/29169/ : SUCCESS -- To view, visit https://review.coreboot.org/27159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc1e8c35a9de54ed04187fcf219a72a592d3bd81 Gerrit-Change-Number: 27159 Gerrit-PatchSet: 1 Gerrit-Owner: Xingyu Wu <wuxy(a)bitland.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 07:05:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Enable Image Unit
by Furquan Shaikh (Code Review) 19 Jun '18

19 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27124 ) Change subject: mainboard/google/nocturne: Enable Image Unit ...................................................................... Patch Set 1: This change needs to be rebased on top of its parent CL. -- To view, visit https://review.coreboot.org/27124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2edf5ec7bde5c55ce1b13cf7b680094a9fffc6a Gerrit-Change-Number: 27124 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 07:03:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Enable Synaptics touchpad device
by Xingyu Wu (Code Review) 19 Jun '18

19 Jun '18

Xingyu Wu has uploaded this change for review. ( https://review.coreboot.org/27159 Change subject: mb/google/octopus: Enable Synaptics touchpad device ...................................................................... mb/google/octopus: Enable Synaptics touchpad device This change adds Synaptcs device to phaser project. BUG=b:110236590 TEST=emerge-octopus coreboot chromeos-bootimage reflash the coreboot to DUT,make sure the Synaptics Touchpad can work. Change-Id: Icc1e8c35a9de54ed04187fcf219a72a592d3bd81 Signed-off-by:wuxy<wuxy(a)bitland.corp-partner.google.com> --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/27159/1 diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index 56fd94f..88dfce4 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -185,6 +185,15 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_135_IRQ)" + register "generic.wake" = "GPE0_DW2_02" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end # - I2C 6 device pci 17.3 on chip drivers/i2c/generic -- To view, visit https://review.coreboot.org/27159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icc1e8c35a9de54ed04187fcf219a72a592d3bd81 Gerrit-Change-Number: 27159 Gerrit-PatchSet: 1 Gerrit-Owner: Xingyu Wu <wuxy(a)bitland.corp-partner.google.com>

1 0

Change in coreboot[master]: mb/lenovo/t400: Change CMOS value name to Dual Graphics
by Nico Rikken (Code Review) 19 Jun '18

19 Jun '18

Nico Rikken has posted comments on this change. ( https://review.coreboot.org/27158 ) Change subject: mb/lenovo/t400: Change CMOS value name to Dual Graphics ...................................................................... Patch Set 1: The found user manual has been addressed by a merge request: https://notabug.org/libreboot/libreboot/pulls/473 -- To view, visit https://review.coreboot.org/27158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4d8bafbae5de97c78dab118f75fdefff1d7c37 Gerrit-Change-Number: 27158 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 06:17:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/t400: Change CMOS value name to Dual Graphics
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27158 ) Change subject: mb/lenovo/t400: Change CMOS value name to Dual Graphics ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29168/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75078/ : SUCCESS -- To view, visit https://review.coreboot.org/27158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4d8bafbae5de97c78dab118f75fdefff1d7c37 Gerrit-Change-Number: 27158 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 06:05:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo/t400: Change CMOS value name to Dual Graphics
by Nico Rikken (Code Review) 19 Jun '18

19 Jun '18

Nico Rikken has uploaded this change for review. ( https://review.coreboot.org/27158 Change subject: mb/lenovo/t400: Change CMOS value name to Dual Graphics ...................................................................... mb/lenovo/t400: Change CMOS value name to Dual Graphics To uniform the naming of the 'Dual Graphics' mode amongst the ThinkPads that support it, the T400 CMOS value needs a change. This was the outcome of a discussion on another patch: https://review.coreboot.org/#/c/coreboot/+/23040/ This might cause breakage for automated NVRAM configuration scripts, and manuals. I only found one manual using the previous 'Switchable' option: https://libreboot.org/docs/install/r400_external.html#a-note-about-gpus Change-Id: I2e4d8bafbae5de97c78dab118f75fdefff1d7c37 Signed-off-by: Nico Rikken <nico(a)nicorikken.eu> --- M src/mainboard/lenovo/t400/cmos.layout 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/27158/1 diff --git a/src/mainboard/lenovo/t400/cmos.layout b/src/mainboard/lenovo/t400/cmos.layout index 6592f40..62072dc 100644 --- a/src/mainboard/lenovo/t400/cmos.layout +++ b/src/mainboard/lenovo/t400/cmos.layout @@ -128,7 +128,7 @@ 11 12 352M 12 0 Integrated Only 12 1 Discrete Only -12 2 Switchable +12 2 Dual Graphics # ----------------------------------------------------------------- checksums -- To view, visit https://review.coreboot.org/27158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e4d8bafbae5de97c78dab118f75fdefff1d7c37 Gerrit-Change-Number: 27158 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Rikken <nico(a)nicorikken.eu>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Add SAR sensor device into devicet...
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27149 ) Change subject: mb/google/poppy/variants/nautilus: Add SAR sensor device into devicetree.cb ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29167/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75077/ : SUCCESS -- To view, visit https://review.coreboot.org/27149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4969e4b82d18b1b1a599de8226c2d7d4bda7915 Gerrit-Change-Number: 27149 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 05:48:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018