coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: lib/prog_loaders: Move argument selection into selfload
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25861 ) Change subject: lib/prog_loaders: Move argument selection into selfload ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29174/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75089/ : SUCCESS -- To view, visit https://review.coreboot.org/25861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I994f604fc4501e0e3b00165819f796b1b8275d8c Gerrit-Change-Number: 25861 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 11:52:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib: Raw import FIT parser
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25739 ) Change subject: lib: Raw import FIT parser ...................................................................... Patch Set 16: (13 comments) https://review.coreboot.org/#/c/25739/16/src/include/fit.h File src/include/fit.h: https://review.coreboot.org/#/c/25739/16/src/include/fit.h@28 PS16, Line 28: { open brace '{' following enum go on the same line https://review.coreboot.org/#/c/25739/16/src/include/fit.h@36 PS16, Line 36: { open brace '{' following struct go on the same line https://review.coreboot.org/#/c/25739/16/src/include/fit.h@46 PS16, Line 46: { open brace '{' following struct go on the same line https://review.coreboot.org/#/c/25739/16/src/lib/fit.c File src/lib/fit.c: https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@194 PS16, Line 194: const char *path[] = { "chosen", NULL }; char * array declaration might be better as static const https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@202 PS16, Line 202: const char *path[] = { "chosen", NULL }; char * array declaration might be better as static const https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@225 PS16, Line 225: { open brace '{' following struct go on the same line https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@226 PS16, Line 226: unsigned addr_cells; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@227 PS16, Line 227: unsigned size_cells; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@231 PS16, Line 231: static uint64_t max_range(unsigned size_cells) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@242 PS16, Line 242: unsigned *count = (unsigned *)params->data; Prefer 'unsigned int *' to bare use of 'unsigned *' https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@242 PS16, Line 242: unsigned *count = (unsigned *)params->data; Prefer 'unsigned int *' to bare use of 'unsigned *' https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@298 PS16, Line 298: * Kernel likes its availabe memory areas at least 1MB 'availabe' may be misspelled - perhaps 'available'? https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@323 PS16, Line 323: unsigned count = 0; Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/25739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 16 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 11:52:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 ) Change subject: soc/intel/common/block: Move common uart function to block/uart ...................................................................... Patch Set 47: (3 comments) https://review.coreboot.org/#/c/26164/47/src/soc/intel/apollolake/uart.c File src/soc/intel/apollolake/uart.c: https://review.coreboot.org/#/c/26164/47/src/soc/intel/apollolake/uart.c@59 PS47, Line 59: MAX_GPIO_PAD_PER_UART + index]; code indent should use tabs where possible https://review.coreboot.org/#/c/26164/47/src/soc/intel/cannonlake/uart.c File src/soc/intel/cannonlake/uart.c: https://review.coreboot.org/#/c/26164/47/src/soc/intel/cannonlake/uart.c@52 PS47, Line 52: MAX_GPIO_PAD_PER_UART + index]; code indent should use tabs where possible https://review.coreboot.org/#/c/26164/47/src/soc/intel/skylake/uart.c File src/soc/intel/skylake/uart.c: https://review.coreboot.org/#/c/26164/47/src/soc/intel/skylake/uart.c@52 PS47, Line 52: MAX_GPIO_PAD_PER_UART + index]; code indent should use tabs where possible -- To view, visit https://review.coreboot.org/26164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 47 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 11:08:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common: Make infrastructure ready for Intel common stage files
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25734 ) Change subject: soc/intel/common: Make infrastructure ready for Intel common stage files ...................................................................... Patch Set 13: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75086/ : SUCCESS -- To view, visit https://review.coreboot.org/25734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac99b4346e8bf6e260b00be9fefede5ad7b3e778 Gerrit-Change-Number: 25734 Gerrit-PatchSet: 13 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 10:56:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Make infrastructure ready for Intel common stage files
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25734 ) Change subject: soc/intel/common: Make infrastructure ready for Intel common stage files ...................................................................... Patch Set 12: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75085/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29171/ : SUCCESS -- To view, visit https://review.coreboot.org/25734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac99b4346e8bf6e260b00be9fefede5ad7b3e778 Gerrit-Change-Number: 25734 Gerrit-PatchSet: 12 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 10:41:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mediatek: Move watchdog timer code to a common directory
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27025 ) Change subject: mediatek: Move watchdog timer code to a common directory ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75084/ : SUCCESS -- To view, visit https://review.coreboot.org/27025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbeb04f775c3c0fdc18dd198df8591f5c4b6ddce Gerrit-Change-Number: 27025 Gerrit-PatchSet: 4 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 10:30:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mediatek/mt8183: Add watchdog timer support
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27026 ) Change subject: mediatek/mt8183: Add watchdog timer support ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75083/ : SUCCESS -- To view, visit https://review.coreboot.org/27026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be3a133dbb8a64604133cefb0c5f02d01afd0d4 Gerrit-Change-Number: 27026 Gerrit-PatchSet: 5 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 10:24:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mediatek: Share watchdog timer code among similar SOCs
by build bot (Jenkins) (Code Review) 19 Jun '18

19 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27024 ) Change subject: mediatek: Share watchdog timer code among similar SOCs ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75082/ : SUCCESS -- To view, visit https://review.coreboot.org/27024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I745c2f204924d9eee1941c0f3e9b6ba45cfb1958 Gerrit-Change-Number: 27024 Gerrit-PatchSet: 4 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Jun 2018 10:23:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018