coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: sb/intel/common/firmware: Enable me_cleaner for Nehalem
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27178 ) Change subject: sb/intel/common/firmware: Enable me_cleaner for Nehalem ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75168/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/29240/ : SUCCESS -- To view, visit https://review.coreboot.org/27178 To unsubscribe, or for help writing … [View More]

1 0

Change in coreboot[master]: sb/intel/common/firmware: Enable me_cleaner for Nehalem
by Nicola Corna (Code Review) 21 Jun '18

21 Jun '18

Nicola Corna has uploaded this change for review. ( https://review.coreboot.org/27178 Change subject: sb/intel/common/firmware: Enable me_cleaner for Nehalem ...................................................................... sb/intel/common/firmware: Enable me_cleaner for Nehalem Recent patches in coreboot have fixed the freeze issues related to the use of me_cleaner on Nehalem. However, at least on the Lenovo X201, with me_cleaner some PCIe devices (like the SATA and USB controllers) … [View More]disappear. In particular, setting the AltMeDisable bit ("-S" or "-s" flag) makes them disappear completely, while unsetting it makes them disappear only during cold boots. This kind of behaviour was already observed by Youness Alaoui on the Purism Librem laptops ([1]), and it seems related to some required board-specific PCIe configuration in the ME's MFS partition. For this reason, on the Lenovo X201, "-w EFFS" has been added to the me_cleaner arguments, which whitelists the MFS-equivalent partition for ME generation 2. This fixes all the issues, and the PCIe devices work as expected. [1] https://puri.sm/posts/deep-dive-into-intel-me-disablement/ Change-Id: Ie77a80d2cb4945cf1c984bdb0fb1cc2f18e82ebc --- M src/mainboard/lenovo/x201/Kconfig M src/southbridge/intel/common/firmware/Kconfig 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/27178/1 diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index 2351209..a689bbc 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -48,4 +48,10 @@ int default 36 +# Without the Intel ME's EFFS partition some PCIe devices (like the USB and SATA +# controllers) don't work as expected +config ME_CLEANER_ARGS + string + default "-S -w EFFS" + endif diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig index 4b882bd..30c9aaf 100644 --- a/src/southbridge/intel/common/firmware/Kconfig +++ b/src/southbridge/intel/common/firmware/Kconfig @@ -73,7 +73,8 @@ config USE_ME_CLEANER bool "Strip down the Intel ME/TXE firmware" - depends on HAVE_ME_BIN && (NORTHBRIDGE_INTEL_SANDYBRIDGE || \ + depends on HAVE_ME_BIN && (NORTHBRIDGE_INTEL_NEHALEM || \ + NORTHBRIDGE_INTEL_SANDYBRIDGE || \ NORTHBRIDGE_INTEL_IVYBRIDGE || NORTHBRIDGE_INTEL_HASWELL || \ SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || \ SOC_INTEL_KABYLAKE || SOC_INTEL_BAYTRAIL || SOC_INTEL_BRASWELL) -- To view, visit https://review.coreboot.org/27178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie77a80d2cb4945cf1c984bdb0fb1cc2f18e82ebc Gerrit-Change-Number: 27178 Gerrit-PatchSet: 1 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> [View Less]

1 0

Change in coreboot[master]: payloads/external/GRUB2: Use pkg-config over freetype-config
by Arthur Heymans (Code Review) 21 Jun '18

21 Jun '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/26822 ) Change subject: payloads/external/GRUB2: Use pkg-config over freetype-config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/26822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-… [View More]

1 0

Change in coreboot[master]: payloads/external/GRUB2: Use pkg-config over freetype-config
by Angel Pons (Code Review) 21 Jun '18

21 Jun '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/26822 ) Change subject: payloads/external/GRUB2: Use pkg-config over freetype-config ...................................................................... Patch Set 1: Code-Review+1 Tested with Arch Linux, this patch fixes building GRUB. -- To view, visit https://review.coreboot.org/26822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot … [View More]

1 0

Change in coreboot[master]: soc/intel/cannonlake: Remove DMA support for PTT
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27176 ) Change subject: soc/intel/cannonlake: Remove DMA support for PTT ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75167/ : SUCCESS -- To view, visit https://review.coreboot.org/27176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: … [View More]

1 0

Change in coreboot[master]: util/lint/checkpatch_json: Fix checkpatch output keyword match string
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27170 ) Change subject: util/lint/checkpatch_json: Fix checkpatch output keyword match string ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29239/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75166/ : SUCCESS -- To view, visit https://review.coreboot.org/27170 To unsubscribe, or … [View More]

1 0

Change in coreboot[master]: util/lint/checkpatch_json: Fix checkpatch output keyword match string
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27170 ) Change subject: util/lint/checkpatch_json: Fix checkpatch output keyword match string ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75165/ : SUCCESS -- To view, visit https://review.coreboot.org/27170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings … [View More]

1 0

Change in coreboot[master]: util/lint/checkpatch_json: Fix checkpatch output keyword match string
by Naresh Solanki (Code Review) 21 Jun '18

21 Jun '18

Hello Rizwan Qureshi, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27170 to look at the new patch set (#4). Change subject: util/lint/checkpatch_json: Fix checkpatch output keyword match string ...................................................................... util/lint/checkpatch_json: Fix checkpatch output keyword match string Look for keyword 'ERROR:' , 'WARNING:' & 'FILE:' instead of the … [View More]

1 0

Change in coreboot[master]: util/lint/checkpatch_json: Fix checkpatch output keyword match string
by Naresh Solanki (Code Review) 21 Jun '18

21 Jun '18

Hello Rizwan Qureshi, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27170 to look at the new patch set (#3). Change subject: util/lint/checkpatch_json: Fix checkpatch output keyword match string ...................................................................... util/lint/checkpatch_json: Fix checkpatch output keyword match string Look for keyword 'ERROR:' , 'WARNING:' & 'FILE:' instead of the … [View More]

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27177 ) Change subject: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29238/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75164/ : SUCCESS -- To view, visit https://review.coreboot.org/27177 To unsubscribe, or for help … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018