coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: soc/intel/common: Add support to configure top swap feature
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25805 ) Change subject: soc/intel/common: Add support to configure top swap feature ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29237/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75163/ : SUCCESS -- To view, visit https://review.coreboot.org/25805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea31b891f81e76d4d623fcb68183c3ad3dcadbad Gerrit-Change-Number: 25805 Gerrit-PatchSet: 7 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:50:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: config to insert ucode address in second FIT
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27151 ) Change subject: Kconfig: config to insert ucode address in second FIT ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29235/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75161/ : SUCCESS -- To view, visit https://review.coreboot.org/27151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ee41d90bae34862aa68c9b8bd69288de1335585 Gerrit-Change-Number: 27151 Gerrit-PatchSet: 5 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:50:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: Add config for creating a second bootblock
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22533 ) Change subject: Kconfig: Add config for creating a second bootblock ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29236/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75162/ : SUCCESS -- To view, visit https://review.coreboot.org/22533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bbd19c35871891b762a0673f840858d972e129e Gerrit-Change-Number: 22533 Gerrit-PatchSet: 9 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:45:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373...
by Patrick Georgi (Code Review) 21 Jun '18

21 Jun '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27167 ) Change subject: mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373 Amp's ...................................................................... mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373 Amp's When played Left Only Audio and Right Only Audio, we observed that Audio got swapped. Left Data played on Right Speaker and Viceversa. This patch fixes the above issue. BUG=b:73635449 TEST=Play Left only & Right only Audio and cross check Audio. Change-Id: Ie9c417ad0634a76fc8a4126ee75886603f1b3da0 Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Reviewed-on: https://review.coreboot.org/27167 Reviewed-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Nick Vaccaro: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 0b30caa..de9c91c 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -317,7 +317,7 @@ register "uid" = "0" register "desc" = ""RIGHT SPEAKER AMP"" register "name" = ""MAXR"" - device i2c 31 on end + device i2c 32 on end end chip drivers/i2c/max98373 register "vmon_slot_no" = "6" @@ -325,7 +325,7 @@ register "uid" = "1" register "desc" = ""LEFT SPEAKER AMP"" register "name" = ""MAXL"" - device i2c 32 on end + device i2c 31 on end end end # I2C #4 - Audio device pci 1c.0 on -- To view, visit https://review.coreboot.org/27167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c417ad0634a76fc8a4126ee75886603f1b3da0 Gerrit-Change-Number: 27167 Gerrit-PatchSet: 2 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon
by Crystal Lin (Code Review) 21 Jun '18

21 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27177 to look at the new patch set (#3). Change subject: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon ...................................................................... mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon We found GPP_C3 keep high when system in S0ix mode.It caused 1.8V leakage.To fix this problem, add GPP_C3 into config for Pantheon Synaptics touchscreen. BUG=b:78436458 BRANCH=None TEST=Let DUT in S0ix mode and check GPP_C3 is normal. Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af Signed-off-by: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/gpio.c 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27177/3 -- To view, visit https://review.coreboot.org/27177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af Gerrit-Change-Number: 27177 Gerrit-PatchSet: 3 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cbfstool: Update FIT entries in the second bootblock
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26836 ) Change subject: cbfstool: Update FIT entries in the second bootblock ...................................................................... Patch Set 15: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29234/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/75160/ : SUCCESS -- To view, visit https://review.coreboot.org/26836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a417031c279038903cdf1761a791f2da0fe8644 Gerrit-Change-Number: 26836 Gerrit-PatchSet: 15 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:38:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Add support to configure top swap feature
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25805 ) Change subject: soc/intel/common: Add support to configure top swap feature ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75159/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29233/ : SUCCESS -- To view, visit https://review.coreboot.org/25805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea31b891f81e76d4d623fcb68183c3ad3dcadbad Gerrit-Change-Number: 25805 Gerrit-PatchSet: 6 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:38:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: config to insert ucode address in second FIT
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27151 ) Change subject: Kconfig: config to insert ucode address in second FIT ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75158/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29232/ : SUCCESS -- To view, visit https://review.coreboot.org/27151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ee41d90bae34862aa68c9b8bd69288de1335585 Gerrit-Change-Number: 27151 Gerrit-PatchSet: 4 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:38:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: Add config for creating a second bootblock
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22533 ) Change subject: Kconfig: Add config for creating a second bootblock ...................................................................... Patch Set 8: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75157/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29231/ : SUCCESS -- To view, visit https://review.coreboot.org/22533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bbd19c35871891b762a0673f840858d972e129e Gerrit-Change-Number: 22533 Gerrit-PatchSet: 8 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:38:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 ) Change subject: cbfstool: add an option for creating a topswap bootblock ...................................................................... Patch Set 23: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29229/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/75155/ : SUCCESS -- To view, visit https://review.coreboot.org/22537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8 Gerrit-Change-Number: 22537 Gerrit-PatchSet: 23 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-CC: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:38:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018