coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: cbfstool: Update FIT entries in the second bootblock
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26836 ) Change subject: cbfstool: Update FIT entries in the second bootblock ...................................................................... Patch Set 14: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29230/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/75156/ : SUCCESS -- To view, visit https://review.coreboot.org/26836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a417031c279038903cdf1761a791f2da0fe8644 Gerrit-Change-Number: 26836 Gerrit-PatchSet: 14 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:33:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27177 ) Change subject: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75154/ : SUCCESS -- To view, visit https://review.coreboot.org/27177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af Gerrit-Change-Number: 27177 Gerrit-PatchSet: 2 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:21:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon
by Crystal Lin (Code Review) 21 Jun '18

21 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27177 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon ...................................................................... mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon We found GPP_C3 keep high when system in S0ix mode.It caused 1.8V leakage.To fix this problem, add GPP_C3 into config for Pantheon Synaptics touchscreen. BUG=b:78436458 BRANCH=None TEST=Let DUT in S0ix mode and check GPP_C3 is normal. Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af Signed-off-by: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/gpio.c 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27177/2 -- To view, visit https://review.coreboot.org/27177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af Gerrit-Change-Number: 27177 Gerrit-PatchSet: 2 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27177 ) Change subject: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75153/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/29228/ : SUCCESS -- To view, visit https://review.coreboot.org/27177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af Gerrit-Change-Number: 27177 Gerrit-PatchSet: 1 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 09:11:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon
by Crystal Lin (Code Review) 21 Jun '18

21 Jun '18

Crystal Lin has uploaded this change for review. ( https://review.coreboot.org/27177 Change subject: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon ...................................................................... mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon We found GPP_C3 keep high when system in S0ix mode.It caused 1.8V leakage.To fix this problem, add GPP_C3 into config for Pantheon Synaptics touchscreen. BUG=b:78436458 BRANCH=None TEST=Let DUT in S0ix mode and check GPP_C3 is normal. Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af --- M src/mainboard/google/poppy/variants/nami/gpio.c 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27177/1 diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c index 3c82c2b..2d0fea4 100644 --- a/src/mainboard/google/poppy/variants/nami/gpio.c +++ b/src/mainboard/google/poppy/variants/nami/gpio.c @@ -118,8 +118,6 @@ PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2 : SMBALERT# ==> NC(TP917) */ PAD_CFG_NC(GPP_C2), - /* C3 : SML0CLK ==> TOUCHSCREEN_DIS# */ - PAD_CFG_GPO(GPP_C3, 0, DEEP), /* C4 : SML0DATA ==> NC */ PAD_CFG_NC(GPP_C4), /* C5 : SML0ALERT# ==> SOC_SML0ALERT# (unstuffed) */ @@ -389,11 +387,22 @@ static const struct pad_config nami_default_sku_gpio_table[] = { /* D17 : DMIC_CLK1 ==> SOC_DMIC_CLK1 */ PAD_CFG_NF(GPP_D17, NONE, DEEP, NF1), + /* C3 : SML0CLK ==> TOUCHSCREEN_DIS# */ + PAD_CFG_GPO(GPP_C3, 0, DEEP), }; static const struct pad_config no_dmic1_sku_gpio_table[] = { /* D17 : DMIC_CLK1 ==> NC */ PAD_CFG_NC(GPP_D17), + /* C3 : SML0CLK ==> TOUCHSCREEN_DIS# */ + PAD_CFG_GPO(GPP_C3, 0, DEEP), +}; + +static const struct pad_config pantheon_gpio_table[] = { + /* D17 : DMIC_CLK1 ==> NC */ + PAD_CFG_NC(GPP_D17), + /* C3 : SML0CLK ==> NC */ + PAD_CFG_NC(GPP_C3), }; const struct pad_config *variant_sku_gpio_table(size_t *num) @@ -404,14 +413,17 @@ case SKU_0_VAYNE: case SKU_1_VAYNE: case SKU_2_VAYNE: - case SKU_0_PANTHEON: - case SKU_1_PANTHEON: - case SKU_2_PANTHEON: case SKU_0_SONA: case SKU_1_SONA: *num = ARRAY_SIZE(no_dmic1_sku_gpio_table); board_gpio_tables = no_dmic1_sku_gpio_table; break; + case SKU_0_PANTHEON: + case SKU_1_PANTHEON: + case SKU_2_PANTHEON: + *num = ARRAY_SIZE(pantheon_gpio_table); + board_gpio_tables = pantheon_gpio_table; + break; default: *num = ARRAY_SIZE(nami_default_sku_gpio_table); board_gpio_tables = nami_default_sku_gpio_table; -- To view, visit https://review.coreboot.org/27177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af Gerrit-Change-Number: 27177 Gerrit-PatchSet: 1 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Remove DMA support for PTT
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27176 ) Change subject: soc/intel/cannonlake: Remove DMA support for PTT ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29227/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75151/ : SUCCESS -- To view, visit https://review.coreboot.org/27176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11993cef77fd5e879eedabc1ed344f91f8257c90 Gerrit-Change-Number: 27176 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 06:36:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: vboot: Fix linking error with USE_OPTION_TABLE enabled
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26863 ) Change subject: vboot: Fix linking error with USE_OPTION_TABLE enabled ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75152/ : SUCCESS -- To view, visit https://review.coreboot.org/26863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10ae94d7936581bbb5ea49384122062bd4934ea5 Gerrit-Change-Number: 26863 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 06:31:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Remove DMA support for PTT
by Subrata Banik (Code Review) 21 Jun '18

21 Jun '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/27176 Change subject: soc/intel/cannonlake: Remove DMA support for PTT ...................................................................... soc/intel/cannonlake: Remove DMA support for PTT Alternative buffer communication support for PTT is no longer needed for CNL onwards and coreboot no need to reserve additional 4KiB memory for PTT support. Change-Id: I11993cef77fd5e879eedabc1ed344f91f8257c90 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/cannonlake/include/soc/iomap.h M src/soc/intel/cannonlake/memmap.c 2 files changed, 0 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/27176/1 diff --git a/src/soc/intel/cannonlake/include/soc/iomap.h b/src/soc/intel/cannonlake/include/soc/iomap.h index 2a3608c..75f11c0 100644 --- a/src/soc/intel/cannonlake/include/soc/iomap.h +++ b/src/soc/intel/cannonlake/include/soc/iomap.h @@ -65,10 +65,6 @@ #define HECI1_BASE_ADDRESS 0xfeda2000 -/* PTT registers */ -#define PTT_TXT_BASE_ADDRESS 0xfed30800 -#define PTT_PRESENT 0x00070000 - #define VTD_BASE_ADDRESS 0xFED90000 #define VTD_BASE_SIZE 0x00004000 /* diff --git a/src/soc/intel/cannonlake/memmap.c b/src/soc/intel/cannonlake/memmap.c index 108a1b0..64e07be 100644 --- a/src/soc/intel/cannonlake/memmap.c +++ b/src/soc/intel/cannonlake/memmap.c @@ -83,22 +83,6 @@ return 0; } -static bool is_ptt_enable(void) -{ - if ((read32((void *)PTT_TXT_BASE_ADDRESS) & PTT_PRESENT) == - PTT_PRESENT) - return true; - - return false; -} - -/* Calculate PTT size */ -static size_t get_ptt_size(void) -{ - /* Allocate 4KB for PTT if enabled */ - return is_ptt_enable() ? 4*KiB : 0; -} - /* Calculate ME Stolen size */ static size_t get_imr_size(void) { @@ -192,9 +176,6 @@ /* Get Tracehub size */ reserve_mem_base -= get_imr_size(); - /* Get PTT size */ - reserve_mem_base -= get_ptt_size(); - /* Traditional Area Size */ reserve_mem_size = dram_base - reserve_mem_base; -- To view, visit https://review.coreboot.org/27176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I11993cef77fd5e879eedabc1ed344f91f8257c90 Gerrit-Change-Number: 27176 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/common/block/cpu: Add option to skip coreboot AP init
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26644 ) Change subject: soc/intel/common/block/cpu: Add option to skip coreboot AP init ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29226/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75150/ : SUCCESS -- To view, visit https://review.coreboot.org/26644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8cd411e802fb682436a933073922b2693ba994 Gerrit-Change-Number: 26644 Gerrit-PatchSet: 10 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Teo Boon Tiong <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 05:37:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/cpu: Add option to skip coreboot AP init
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26644 ) Change subject: soc/intel/common/block/cpu: Add option to skip coreboot AP init ...................................................................... Patch Set 9: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29225/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/75149/ : ABORTED -- To view, visit https://review.coreboot.org/26644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8cd411e802fb682436a933073922b2693ba994 Gerrit-Change-Number: 26644 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Teo Boon Tiong <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 05:31:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018