coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: drivers/fsp1_1: fix VBT Loading by using GMA common function
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27169 ) Change subject: drivers/fsp1_1: fix VBT Loading by using GMA common function ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29215/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75138/ : SUCCESS -- To view, visit https://review.coreboot.org/27169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba882ee4d9e83dcd88bdf7dd2f5591f66005a3fe Gerrit-Change-Number: 27169 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 14:21:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Nico Huber (Code Review) 20 Jun '18

20 Jun '18

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29214/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75137/ : SUCCESS -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 8 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 13:04:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Quan Tran (Code Review) 20 Jun '18

20 Jun '18

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27168 to look at the new patch set (#8). Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... inteltool: Add PCI IDs for the C220 PCH series Adds missing PCI IDs to allow tool to dump the C220 PCH (8 series) southbridge. Intel Document 328904 is the datasheet for this PCH. Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Signed-off-by: Quan Tran <qeed.quan(a)gmail.com> --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 6 files changed, 112 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27168/8 -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 8 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29213/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75136/ : SUCCESS -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 7 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 12:53:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Nico Huber (Code Review) 20 Jun '18

20 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 7: (2 comments) https://review.coreboot.org/#/c/27168/7/util/inteltool/gpio.c File util/inteltool/gpio.c: https://review.coreboot.org/#/c/27168/7/util/inteltool/gpio.c@873 PS7, Line 873: /* Shares Lynx Point register locations but has less of them */ Nit, all 8 series is Lynx Point. The integrated one is referred to as Lynx Point-LP. https://review.coreboot.org/#/c/27168/7/util/inteltool/inteltool.h File util/inteltool/inteltool.h: https://review.coreboot.org/#/c/27168/7/util/inteltool/inteltool.h@187 PS7, Line 187: #define PCI_DEVICE_ID_INTEL_C8_MOBILE 0x8c41 : #define PCI_DEVICE_ID_INTEL_C8_DESKTOP 0x8c42 These two use spaces now? -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 7 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 12:52:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75135/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/29212/ : SUCCESS -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 6 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 12:48:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Quan Tran (Code Review) 20 Jun '18

20 Jun '18

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27168 to look at the new patch set (#7). Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... inteltool: Add PCI IDs for the C220 PCH series Adds missing PCI IDs to allow tool to dump the C220 PCH (8 series) southbridge. Intel Document 328904 is the datasheet for this PCH. Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Signed-off-by: Quan Tran <qeed.quan(a)gmail.com> --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 6 files changed, 112 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27168/7 -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 7 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Quan Tran (Code Review) 20 Jun '18

20 Jun '18

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27168 to look at the new patch set (#6). Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... inteltool: Add PCI IDs for the C220 PCH series Adds missing PCI IDs to allow tool to dump the C220 PCH (8 series) southbridge. Intel Document 328904 is the datasheet for this PCH. Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Signed-off-by: Quan Tran <qeed.quan(a)gmail.com> --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 6 files changed, 112 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27168/6 -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 6 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Nico Huber (Code Review) 20 Jun '18

20 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/27168/5/util/inteltool/gpio.c File util/inteltool/gpio.c: https://review.coreboot.org/#/c/27168/5/util/inteltool/gpio.c@873 PS5, Line 873: size = 29; Please leave a comment that this is intentionally reusing the 29 first registers of the LP variant. Otherwise ppl might get confused and try to "fix" it... https://review.coreboot.org/#/c/27168/5/util/inteltool/inteltool.h File util/inteltool/inteltool.h: https://review.coreboot.org/#/c/27168/5/util/inteltool/inteltool.h@201 PS5, Line 201: #define PCI_DEVICE_ID_INTEL_H81 0x8c5c again, please align -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 5 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 12:31:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018