coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: tianocore: Add more patches
by Nico Huber (Code Review) 20 Jun '18

20 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27137 ) Change subject: tianocore: Add more patches ...................................................................... Patch Set 1: (1 comment) Is there a reason not to move forward to a newer "stable" revision? https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… File payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch: https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches… PS1, Line 34: + while (StringPtr != NULL) { > DOS line endings I think this loop condition is supposed to look for a terminating '\0'... -- To view, visit https://review.coreboot.org/27137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e2efea930b27749b1097607ab143ce2f91e79ec Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 20 Jun 2018 11:09:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Patrick Rudolph (Code Review) 20 Jun '18

20 Jun '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h: https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.h@200 PS1, Line 200: pelase use two tabs instead of space as seperator https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.c File util/inteltool/inteltool.c: https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.c@236 PS1, Line 236: "Intel(R) C8 Mobile"}, The other southbridge names doesn't have an "Intel(R)" prefix, please remove. -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 1 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 10:43:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/lint/checkpatch_json: Fix checkpatch output keywork match string
by Rizwan Qureshi (Code Review) 20 Jun '18

20 Jun '18

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/27170 ) Change subject: util/lint/checkpatch_json: Fix checkpatch output keywork match string ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/27170/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27170/2//COMMIT_MSG@7 PS2, Line 7: keywork keyword https://review.coreboot.org/#/c/27170/2//COMMIT_MSG@9 PS2, Line 9: keyword 'ERROR:' , 'WARNING:' & 'FILE:' so, checkpatch will fail if finds a problem with lines containing "ERROR:" WARNING: FILE:. These strings are very generic and can be used in source code, can you modify the checkpatch keywords itself. e.g., CHECKPATCH_ERR, CHECKPATCH_WARN etc. -- To view, visit https://review.coreboot.org/27170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib690ab34a1ffabc4f83642634fd34beea16a64dc Gerrit-Change-Number: 27170 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 10:37:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/octopus: Update Phaser's GPIO table
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

1 0

Change in coreboot[master]: soc/intel/common: Add support to configure top swap feature
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25805 ) Change subject: soc/intel/common: Add support to configure top swap feature ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29207/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75129/ : SUCCESS -- To view, visit https://review.coreboot.org/25805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea31b891f81e76d4d623fcb68183c3ad3dcadbad Gerrit-Change-Number: 25805 Gerrit-PatchSet: 5 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Wed, 20 Jun 2018 09:55:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: config to insert ucode address in second FIT
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27151 ) Change subject: Kconfig: config to insert ucode address in second FIT ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29206/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75128/ : SUCCESS -- To view, visit https://review.coreboot.org/27151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ee41d90bae34862aa68c9b8bd69288de1335585 Gerrit-Change-Number: 27151 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 09:55:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cbfstool: Update FIT entries in the second bootblock
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26836 ) Change subject: cbfstool: Update FIT entries in the second bootblock ...................................................................... Patch Set 13: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29205/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/75127/ : SUCCESS -- To view, visit https://review.coreboot.org/26836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a417031c279038903cdf1761a791f2da0fe8644 Gerrit-Change-Number: 26836 Gerrit-PatchSet: 13 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Wed, 20 Jun 2018 09:55:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: Add config for creating a second bootblock
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22533 ) Change subject: Kconfig: Add config for creating a second bootblock ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29203/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75125/ : SUCCESS -- To view, visit https://review.coreboot.org/22533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bbd19c35871891b762a0673f840858d972e129e Gerrit-Change-Number: 22533 Gerrit-PatchSet: 7 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Wed, 20 Jun 2018 09:50:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/octopus: Update Phaser's GPIO table
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27171 ) Change subject: google/octopus: Update Phaser's GPIO table ...................................................................... Patch Set 1: (162 comments) https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… File src/mainboard/google/octopus/variants/phaser/gpio.c: https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 29: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_0, DN_20K, DEEP, NF1, IGNORE, ENPD), /* TCK */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 30: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_1, DN_20K, DEEP, NF1, IGNORE, ENPD), /* TRST_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 31: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_2, UP_20K, DEEP, NF1, IGNORE, ENPU), /* TMS */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 32: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_3, UP_20K, DEEP, NF1, IGNORE, ENPU), /* TDI */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 33: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_4, UP_20K, DEEP, NF1, IGNORE, ENPU), /* TDO */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 34: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_5, UP_20K, DEEP, NF1, IGNORE, ENPU), /* TP_GPIO5 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 35: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_6, UP_20K, DEEP, NF1, IGNORE, ENPU), /* CX_PREQ_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 36: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_7, UP_20K, DEEP, NF1, IGNORE, ENPU), /* CX_PRDY_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 37: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_8, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_CLK0 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 38: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_9, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_0 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 39: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_10, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_1 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 40: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_11, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_2 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 41: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_12, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_3 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 42: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_13, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_4 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 43: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_14, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_5 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 44: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_15, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_6 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 45: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_16, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_7*/ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 46: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_17, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_CLK_1 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 47: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_18, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_8 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 48: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_19, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_9 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 49: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_20, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_10 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 51: PAD_CFG_NF_IOSSTATE(GPIO_22, UP_20K, DEEP, NF2, TxDRxE), /* CNVI_MFUART2_TXD_PTI_12 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 52: PAD_CFG_NF(GPIO_23, UP_20K, DEEP, NF2), /* CNVI_GNSS_PA_BLANKING_PTI_13 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 53: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_24, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_14 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 54: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_25, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_15 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 55: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_26, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_CLK2 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 56: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_27, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_16 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 57: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_28, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_17 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_29, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_18 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 59: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_30, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_19 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 60: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_31, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_20 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 61: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_32, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_21 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 62: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_33, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_22 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 63: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_34, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_23 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 64: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_35, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DCI_CLK_PTICLK3 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 65: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_36, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DCI_DATA_PTITRACE3_0 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 66: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_37, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_TRACE3_1 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 67: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_TRACE3_2 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 68: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_TRACE3_3 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 69: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_40, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_TRACE3_4 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 70: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_41, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DGB_PTI_DATA_TRACE3_5 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 71: PAD_CFG_GPIO_HI_Z(GPIO_42, NONE, DEEP, HIZCRx0, DISPUPD), /* TP_WIFI_RST_N -- TP135 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 72: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* GP_INTD_DSI_TE2 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 73: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_44, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* USB_A_OC_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 74: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* USB_C_OC_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 75: PAD_CFG_GPIO_HI_Z(GPIO_46, NONE, DEEP, HIZCRx0, DISPUPD), /* TP_PCH_GPIO46 -- TP37 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 76: PAD_CFG_GPIO_HI_Z(GPIO_47, NONE, DEEP, HIZCRx0, DISPUPD), /* TP_PCH_GPIO47 -- TP31 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 77: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_48, NONE, DEEP, NF1), /* PCH_PMIC_I2C_SDA */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 78: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_49, NONE, DEEP, NF1), /* PCH_PMIC_I2C_SCL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 79: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_50, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* PCH_I2C_PEN_SDA */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 80: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_51, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* PCH_I2C_PEN_SCL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 81: PAD_CFG_GPIO_HI_Z(GPIO_52, NONE, DEEP, HIZCRx0, DISPUPD), /* PCH_I2C_P_SENSOR_SDA */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 82: PAD_CFG_GPIO_HI_Z(GPIO_53, NONE, DEEP, HIZCRx0, DISPUPD), /* PCH_I2C_P_SENSOR_SCL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 85: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_56, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* DBG_PCH_I2C_SDA */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 86: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_57, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* DBG_PCH_I2C_SCL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 87: PAD_CFG_GPIO_HI_Z(GPIO_58, NONE, DEEP, HIZCRx0, DISPUPD), /* PCH_I2C_H1_SDA */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 88: PAD_CFG_GPIO_HI_Z(GPIO_59, NONE, DEEP, HIZCRx0, DISPUPD), /* PCH_I2C_H1_SCL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 89: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_60, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* PCHRX_MIPI60TX_UART */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 90: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_61, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* PCHTX_MIPI60RX_UART */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 92: PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, EDGE_SINGLE, INVERT, TxDRxE, DISPUPD), /* H1_PCH_INT_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 93: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* PCHRX_UART2 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 94: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* PCHTX_UART2 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 96: PAD_CFG_GPIO_HI_Z(GPIO_67, NONE, DEEP, HIZCRx0, DISPUPD), /* EN_PP3300_DX_LTE_SOC -- TP45 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 103: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_74, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* THERMTRIP_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 104: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_75, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCH_PROCHOT_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 105: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_211, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* EMMC_RST_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 106: PAD_CFG_GPI_APIC_IOS(GPIO_212, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD), /* TOUCHSCREEN_INT_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 107: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_213, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_TOUCHSCREEN */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 108: PAD_CFG_GPIO_HI_Z(GPIO_214, NONE, DEEP, HIZCRx0, DISPUPD), /* P_SENSOR_INT_L -- TP69 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 113: PAD_CFG_GPIO_HI_Z(GPIO_76, NONE, DEEP, HIZCRx0, DISPUPD),/* TP_PCH_GPIO_76 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 114: PAD_CFG_GPIO_HI_Z(GPIO_77, NONE, DEEP, HIZCRx0, DISPUPD),/* TP_PCH_GPIO_77 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 115: PAD_CFG_GPIO_HI_Z(GPIO_78, NONE, DEEP, HIZCRx0, DISPUPD),/* TP_PCH_GPIO_78 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 120: PAD_CFG_GPIO_HI_Z(GPIO_81, UP_20K, DEEP, HIZCRx0, DISPUPD), /* GPIO_81_DEBUG (Boot halt) -- MIPI60 DEBUG */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 131: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, DN_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCH_SPI_CS0_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 132: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_91, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),/* FST_SPI_CS1_B -- SPK_PA_EN */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 133: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PCH_SPI_MOSI */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 134: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PCH_SPI_MISO_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 135: PAD_CFG_GPIO_HI_Z(GPIO_94, NONE, DEEP, HIZCRx0, DISPUPD),/* FST_SPI_IO2 - unused */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 136: PAD_CFG_GPIO_HI_Z(GPIO_95, NONE, DEEP, HIZCRx0, DISPUPD),/* FST_SPI_IO3 - unused */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 137: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, DN_20K, DEEP, NF1, HIZCRx0, ENPD),/* PCH_SPI_CLK */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 140: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_98, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PLT_RST_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 141: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, UP_20K, DEEP, NF1, TxDRxE, ENPU),/* EC_PCH_PWR_BTN_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 142: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_100, NONE, DEEP, NF1),/* PCH_SLP_S0_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 143: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_101, NONE, DEEP, NF1),/* PCH_SLP_S3_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 144: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_102, NONE, DEEP, NF1),/* PCH_SLP_S4_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 146: PAD_CFG_GPIO_HI_Z(GPIO_104, NONE, DEEP, HIZCRx0, DISPUPD),/* EN_PP3300_EMMC -- TP30 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 147: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* TOUCHSCREEN_RST */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 148: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PMU_BATLOW_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 149: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_107, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* SYS_RST_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 151: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_109, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD),/* SUS_STAT_B -- BT_DISABLE_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 154: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PCH_I2C_AUDIO_SDA_Q */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 155: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_111, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PCH_I2C_AUDIO_SCL_Q */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 158: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_112, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PCH_I2C_TRACKPAD_SDA */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 159: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_113, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PCH_I2C_TRACKPAD_SCL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 162: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_114, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PCH_I2C_TOUCHSCREEN_SDA */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 163: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_115, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PCH_I2C_TOUCHSCREEN_SCL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 167: PAD_CFG_GPIO_HI_Z(GPIO_117, NONE, DEEP, HIZCRx0, DISPUPD),/* LTE_WAKE_L -- TP80 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 169: PAD_CFG_GPI_SCI_LOW(GPIO_119, NONE, DEEP, EDGE_SINGLE),/* WLAN_PCIE_WAKE_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 172: PAD_CFG_GPIO_HI_Z(GPIO_120, NONE, DEEP, HIZCRx0, DISPUPD),/* PCIE_CLKREQ0_ODL -- TP157 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 173: PAD_CFG_GPIO_HI_Z(GPIO_121, NONE, DEEP, HIZCRx0, DISPUPD),/* PCIE_CLKREQ1_ODL -- TP145 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 174: PAD_CFG_GPIO_HI_Z(GPIO_122, NONE, DEEP, HIZCRx0, DISPUPD),/* PCIE_CLKREQ2_ODL -- TP171 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 175: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, UP_20K, DEEP, NF1, TxDRxE, DISPUPD), /* WLAN_PCIE_CLKREQ_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 178: PAD_CFG_GPIO_HI_Z(GPIO_124, NONE, DEEP, HIZCRx0, DISPUPD),/* HV_DDI0_DDC_SDA -- unused */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 179: PAD_CFG_GPIO_HI_Z(GPIO_125, NONE, DEEP, HIZCRx0, DISPUPD),/* HV_DDI0_DDC_SCL -- unused */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 180: PAD_CFG_GPIO_HI_Z(GPIO_126, NONE, DEEP, HIZCRx0, DISPUPD),/* HV_DDI1_DDC_SDA -- unused */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 181: PAD_CFG_GPIO_HI_Z(GPIO_127, NONE, DEEP, HIZCRx0, DISPUPD),/* HV_DDI1_DDC_SCL -- unused */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 184: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_128, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* EN_PP3300_EDP_DX */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 185: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_129, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* SOC_EDP_BKLTEN */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 186: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_130, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* SOC_EDP_BKLTCTL_1V8 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 189: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_131, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* USB_C0_HPD_1V8_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 190: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_132, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* USB_C1_HPD_1V8_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 191: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* EDP_HPD_PANEL_1V8_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 194: PAD_CFG_GPI_APIC_LOW(GPIO_135, NONE, DEEP),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 195: PAD_CFG_GPI_APIC_IOS(GPIO_136, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_136 -- PMIC_PCH_INT_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 196: PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_137 -- HP_INT_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 197: PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 198: PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_INT_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 199: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 200: // TODO check if it is ok to set to GPIROUTSCI (as in Coral/Reef and others). line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 203: PAD_CFG_GPI_SCI_IOS(GPIO_141, UP_20K, DEEP, EDGE_SINGLE, INVERT, IGNORE, SAME),/* GPIO_141 -- EC_PCH_WAKE_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 204: PAD_CFG_GPI_SCI_LOW(GPIO_142, NONE, DEEP, LEVEL),/* GPIO_142 -- TRACKPAD_INT2_1V8_ODL */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 205: PAD_CFG_GPIO_HI_Z(GPIO_143, NONE, DEEP, HIZCRx0, DISPUPD),/* LTE_SAR_ODL -- TP64 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 206: PAD_CFG_GPIO_HI_Z(GPIO_144, NONE, DEEP, HIZCRx0, DISPUPD),/* TP_GPIO_144 -- TP49 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 207: PAD_CFG_GPIO_HI_Z(GPIO_145, NONE, DEEP, HIZCRx0, DISPUPD),/* TP_GPIO_145 -- TP7 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 218: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_157, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* I2S0_SCLK_R -- TP53 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 219: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_158, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* I2S0_SFRM_R -- TP54 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 220: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_159, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* I2S0_PCH_RX -- TP57 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 221: PAD_CFG_GPIO_HI_Z(GPIO_160, NONE, DEEP, HIZCRx0, DISPUPD), /* I2S0_PCH_TX -- TP59 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 222: PAD_CFG_GPIO_HI_Z(GPIO_161, NONE, DEEP, HIZCRx0, DISPUPD), /* LTE_OFF_ODL -- TP65 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 223: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_162, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* I2S_SCLK_SPKR */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 224: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_163, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* I2S_SFRM_SPKR */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 226: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_165, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* I2S_PCH_TX_SPKR_RX */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 227: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, SAME), /* I2S2_SCLK_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 228: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_167, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* I2S2_SFRM_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 229: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_168, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* I2S2_PCH_RX */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 230: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_169, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* I2S2_PCH_TX */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 231: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_170, DN_20K, DEEP, NF2, HIZCRx0, DISPUPD), /* I2S2_MCLK_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 232: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_171, DN_20K, DEEP, NF1), /* AVS_M_CLK_A1 -- DMIC_CLK1_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 233: PAD_CFG_NF_IOSSTATE(GPIO_172, DN_20K, DEEP, NF1, HIZCRx0), /* AVS_M_CLK_B1 -- DMIC_CLK2_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 234: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_173, DN_20K, DEEP, NF1), /* AVS_M_DATA_1 -- DMIC_DATA_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 235: PAD_CFG_GPIO_HI_Z(GPIO_174, NONE, DEEP, HIZCRx0, DISPUPD), /* AVS_M_CLK_AB2 -- TP_GPIO_174 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 236: PAD_CFG_NF_IOSSTATE(GPIO_175, DN_20K, DEEP, NF1, HIZCRx0), /* AVS_M_DATA_2 -- DMIC_CAM2_DATA */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 239: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_176, 0, DEEP, NONE, HIZCRx0, DISPUPD), /* TP_SMB_ALERT_N */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 240: PAD_CFG_GPIO_HI_Z(GPIO_177, NONE, DEEP, HIZCRx0, DISPUPD), /* TP_PCH_SMB_CLK -- TP160 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 242: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_189, 0, DEEP, NONE, TxDRxE, DISPUPD), /* EC_IN_RW_OD */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 243: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_191, NONE, DEEP, NF1), /* CNVI_BRI_DT_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 244: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_192, UP_20K, DEEP, NF1), /* CNVI_BRI_RSP */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 245: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_193, NONE, DEEP, NF1), /* CNVI_RGI_DT_R */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 246: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_194, UP_20K, DEEP, NF1), /* CNV_RGI_RSP */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 247: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_195, NONE, DEEP, NF1), /* CNVI_RF_RESET_L */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 248: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPU), /* EMMC_CLK */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 249: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_200, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_DAT0 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 250: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_201, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_DAT1 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 251: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_202, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_DAT2 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 252: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_203, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_DAT3 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 253: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_204, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_DAT4 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 254: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_205, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_DAT5 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 255: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_206, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_DAT6 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 256: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_207, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_DAT7 */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 257: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_208, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC_CMD */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 258: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, DN_20K, DEEP, NF1, HIZCRx0, ENPU), /* EMMC_RCLK */ line over 80 characters https://review.coreboot.org/#/c/27171/1/src/mainboard/google/octopus/varian… PS1, Line 259: PAD_CFG_GPIO_HI_Z(GPIO_210, NONE, DEEP, HIZCRx0, DISPUPD), /* TP_GPIO210 */ line over 80 characters -- To view, visit https://review.coreboot.org/27171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5777a98d21df7a30503ada24c7000994aa4c3de Gerrit-Change-Number: 27171 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Chen <nickchen(a)ami.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 09:50:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 ) Change subject: cbfstool: add an option for creating a topswap bootblock ...................................................................... Patch Set 22: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29204/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/75126/ : SUCCESS -- To view, visit https://review.coreboot.org/22537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8 Gerrit-Change-Number: 22537 Gerrit-PatchSet: 22 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-CC: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Comment-Date: Wed, 20 Jun 2018 09:50:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018