coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29211/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75134/ : SUCCESS -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 5 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 12:31:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75133/ : SUCCESS -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 4 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 12:24:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Quan Tran (Code Review) 20 Jun '18

20 Jun '18

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27168 to look at the new patch set (#5). Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... inteltool: Add PCI IDs for the C220 PCH series Adds missing PCI IDs to allow tool to dump the C220 PCH (8 series) southbridge. Intel Document 328904 is the datasheet for this PCH. Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Signed-off-by: Quan Tran <qeed.quan(a)gmail.com> --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 6 files changed, 111 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27168/5 -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 5 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75132/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29210/ : SUCCESS -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 3 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 12:19:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Quan Tran (Code Review) 20 Jun '18

20 Jun '18

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27168 to look at the new patch set (#4). Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... inteltool: Add PCI IDs for the C220 PCH series Adds missing PCI IDs to allow tool to dump the C220 PCH (8 series) southbridge. Intel Document 328904 is the datasheet for this PCH. Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Signed-off-by: Quan Tran <qeed.quan(a)gmail.com> --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 6 files changed, 126 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27168/4 -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 4 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Quan Tran (Code Review) 20 Jun '18

20 Jun '18

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27168 to look at the new patch set (#3). Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... inteltool: Add PCI IDs for the C220 PCH series Adds missing PCI IDs to allow tool to dump the C220 PCH (8 series) southbridge. Intel Document 328904 is the datasheet for this PCH. Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Signed-off-by: Quan Tran <qeed.quan(a)gmail.com> --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 6 files changed, 126 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27168/3 -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 3 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Nico Huber (Code Review) 20 Jun '18

20 Jun '18

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29209/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75131/ : SUCCESS -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 2 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 11:35:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Nico Huber (Code Review) 20 Jun '18

20 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27168 ) Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... Patch Set 1: (5 comments) https://review.coreboot.org/#/c/27168/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27168/1//COMMIT_MSG@9 PS1, Line 9: ICH8 ICH was the predecessor of the PCH. Because some features of the GMCH (northbridge) also moved into the PCH Intel counts the PCH series based on the GMCH numbers. i.e. after 4 series GMCH came 5 series PCH. This is about the 8 series PCHs. Also, please break lines before 72 characters. https://review.coreboot.org/#/c/27168/1//COMMIT_MSG@12 PS1, Line 12: Documentation on the PCH can be found here: Please separate paragraphs with an empty line. https://review.coreboot.org/#/c/27168/1//COMMIT_MSG@13 PS1, Line 13: https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/8-s… No links please. Document and revision numbers are more useful in the long run. https://review.coreboot.org/#/c/27168/1/util/inteltool/gpio.c File util/inteltool/gpio.c: https://review.coreboot.org/#/c/27168/1/util/inteltool/gpio.c@866 PS1, Line 866: case PCI_DEVICE_ID_INTEL_H81: According to the datasheet the non-LP version doesn't have the registers above 0x68. Can you confirm if you see (or don't see) valid values above that? In case, you can still use the same register description, just reduce the `size` below. https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.c File util/inteltool/inteltool.c: https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.c@235 PS1, Line 235: { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C8_MOBILE, : "Intel(R) C8 Mobile"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C8_DESKTOP, : "Intel(R) C8 Desktop"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z87, : "Intel(R) Z87"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z85, : "Intel(R) Z85"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HM86, : "Intel(R) HM86"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H87, : "Intel(R) H87"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HM87, : "Intel(R) HM87"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Q85, : "Intel(R) Q85"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Q87, : "Intel(R) Q87"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QM87, : "Intel(R) QM87"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_B85, : "Intel(R) B85"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C222, : "Intel(R) C222"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C224, : "Intel(R) C224"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C226, : "Intel(R) C226"}, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H81, : "Intel(R) H81"}, Please don't break lines that fit into 80 chars. -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 1 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 11:33:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series
by Quan Tran (Code Review) 20 Jun '18

20 Jun '18

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27168 to look at the new patch set (#2). Change subject: inteltool: Add PCI IDs for the C220 PCH series ...................................................................... inteltool: Add PCI IDs for the C220 PCH series The C220 PCH series is a ICH8 generation southbridge. There is already existing code to dump this southbridge. This patch adds the missing PCI IDs to allow the tool to dump them. Documentation on the PCH can be found here: https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/8-s… Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Signed-off-by: Quan Tran <qeed.quan(a)gmail.com> --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 6 files changed, 121 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27168/2 -- To view, visit https://review.coreboot.org/27168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 Gerrit-Change-Number: 27168 Gerrit-PatchSet: 2 Gerrit-Owner: Quan Tran <qeed.quan(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018