coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: soc/intel/common/block/cpu: Add option to skip coreboot AP init
by build bot (Jenkins) (Code Review) 21 Jun '18

21 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26644 ) Change subject: soc/intel/common/block/cpu: Add option to skip coreboot AP init ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29224/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75148/ : SUCCESS -- To view, visit https://review.coreboot.org/26644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8cd411e802fb682436a933073922b2693ba994 Gerrit-Change-Number: 26644 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Teo Boon Tiong <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 04:20:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by Tomasz Figa (Code Review) 21 Jun '18

21 Jun '18

Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl: https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants… PS5, Line 37: Method (PMON, 0, Serialized) { : CTXS(FCAM_RST_L) : STXS(FCAM_PWR_EN) : STXS(PCH_FCAM_CLK_EN) : Sleep(3) : STXS(FCAM_RST_L) : } : : Method (PMOF, 0, Serialized) { : CTXS(PCH_FCAM_CLK_EN) : CTXS(FCAM_RST_L) : CTXS(FCAM_PWR_EN) : } Since these are used by both sensor and NVM, doesn't this need to be reference counted? Same for front camera. https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants… PS5, Line 63: Return (0x0F) Shouldn't this return some actual status? Same for front camera. -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 5 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 03:21:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: Add SX9310 support
by Furquan Shaikh (Code Review) 21 Jun '18

21 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27172 ) Change subject: mb/google/poppy/variants/nocturne: Add SX9310 support ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/27172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7358ee34df873098a86d692cc8a909b0ec5023a8 Gerrit-Change-Number: 27172 Gerrit-PatchSet: 3 Gerrit-Owner: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 03:12:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/i2c: Add a driver for Semtech SX9310
by Furquan Shaikh (Code Review) 21 Jun '18

21 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27173 ) Change subject: drivers/i2c: Add a driver for Semtech SX9310 ...................................................................... Patch Set 1: (4 comments) https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h File src/drivers/i2c/sx9310/chip.h: https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h@19 PS1, Line 19: #include <drivers/i2c/generic/chip.h> Why is this included here? https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h@21 PS1, Line 21: #define I2C_SX9310_ACPI_ID "SX9310" : #define I2C_SX9310_ACPI_NAME "Semtech SX9310" Can these be moved to sx9310.c? https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/registers.h File src/drivers/i2c/sx9310/registers.h: https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/registers.h@… PS1, Line 17: REGISTER(TYPE, NAME) REGISTER(NAME) https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/sx9310.c File src/drivers/i2c/sx9310/sx9310.c: https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/sx9310.c@72 PS1, Line 72: {0} Not required. -- To view, visit https://review.coreboot.org/27173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8c434eec9fe2da731e142442503a12e88db2236 Gerrit-Change-Number: 27173 Gerrit-PatchSet: 1 Gerrit-Owner: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 03:11:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Add SAR sensor device into devicet...
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27149 ) Change subject: mb/google/poppy/variants/nautilus: Add SAR sensor device into devicetree.cb ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29223/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75147/ : SUCCESS -- To view, visit https://review.coreboot.org/27149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4969e4b82d18b1b1a599de8226c2d7d4bda7915 Gerrit-Change-Number: 27149 Gerrit-PatchSet: 5 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 01:35:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Clear GPP_D0 when entering S5
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27148 ) Change subject: mb/google/poppy/variants/nautilus: Clear GPP_D0 when entering S5 ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29222/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75146/ : SUCCESS -- To view, visit https://review.coreboot.org/27148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I054e707b2bc2e63d6f99cd2fd8a57be20615f111 Gerrit-Change-Number: 27148 Gerrit-PatchSet: 7 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 01:35:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Add SAR sensor device into devicet...
by build bot (Jenkins) (Code Review) 20 Jun '18

20 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27149 ) Change subject: mb/google/poppy/variants/nautilus: Add SAR sensor device into devicetree.cb ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29221/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75145/ : SUCCESS -- To view, visit https://review.coreboot.org/27149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4969e4b82d18b1b1a599de8226c2d7d4bda7915 Gerrit-Change-Number: 27149 Gerrit-PatchSet: 4 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Jun 2018 01:13:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nocturne: configure VR
by Pratikkumar V Prajapati (Code Review) 20 Jun '18

20 Jun '18

Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/27175 Change subject: nocturne: configure VR ...................................................................... nocturne: configure VR [WIP, still undertest] Change-Id: I4c67c6a095aecc158e529a6b393baf03ec358a3d Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/27175/1 diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index f746c08..9394a69 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -62,7 +62,7 @@ register "speed_shift_enable" = "1" register "dptf_enable" = "1" - register "tdp_pl2_override" = "15" + register "tdp_pl2_override" = "18" register "psys_pmax" = "45" register "tcc_offset" = "10" register "pch_trip_temp" = "75" @@ -87,10 +87,10 @@ #| Psi4Enable | 1 | 1 | 1 | 1 | #| ImonSlope | 0 | 0 | 0 | 0 | #| ImonOffset | 0 | 0 | 0 | 0 | - #| IccMax | 4A | 24A | 24A | 24A | + #| IccMax | 4A | 28A | 24A | 24A | #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | - #| AcLoadline | 14.9 | 5 | 5.7 | 4.57 | - #| DcLoadline | 14.2 | 4.86 | 4.2 | 4.3 | + #| AcLoadline | 17.4 | 4 | 5.7 | 4.57 | + #| DcLoadline | 16.7 | 4 | 4.2 | 4.3 | #+----------------+-------+-------+-------+-------+ register "domain_vr_config[VR_SYSTEM_AGENT]" = "{ .vr_config_enable = 1, @@ -103,8 +103,8 @@ .imon_offset = 0x0, .icc_max = VR_CFG_AMP(4), .voltage_limit = 1520, - .ac_loadline = 1490, - .dc_loadline = 1420, + .ac_loadline = 1740, + .dc_loadline = 1670, }" register "domain_vr_config[VR_IA_CORE]" = "{ @@ -116,10 +116,10 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(24), + .icc_max = VR_CFG_AMP(28), .voltage_limit = 1520, - .ac_loadline = 500, - .dc_loadline = 486, + .ac_loadline = 400, + .dc_loadline = 400, }" register "domain_vr_config[VR_GT_UNSLICED]" = "{ -- To view, visit https://review.coreboot.org/27175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4c67c6a095aecc158e529a6b393baf03ec358a3d Gerrit-Change-Number: 27175 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>

1 0

Change in coreboot[master]: mb/google/bip: update emmc tuning parameters
by John Zhao (Code Review) 20 Jun '18

20 Jun '18

John Zhao has posted comments on this change. ( https://review.coreboot.org/27174 ) Change subject: mb/google/bip: update emmc tuning parameters ...................................................................... Patch Set 3: Code-Review+1 After applying eMMC tuning data on Bip, it boots to kernel. -- To view, visit https://review.coreboot.org/27174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib054d1437c82b6ae9f5885dd49c8c1f9b4045a02 Gerrit-Change-Number: 27174 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Comment-Date: Thu, 21 Jun 2018 00:01:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: EMMC DLL tuning
by Bora Guvendik (Code Review) 20 Jun '18

20 Jun '18

Bora Guvendik has abandoned this change. ( https://review.coreboot.org/25729 ) Change subject: mb/google/octopus: EMMC DLL tuning ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/25729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I15e547d69002f66b4d9a53898ee4b131517c299d Gerrit-Change-Number: 25729 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018