coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: mb/google/poppy/variants/atlas: add GPIO for bluetooth enable
by Furquan Shaikh (Code Review) 22 Jun '18

22 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27185 ) Change subject: mb/google/poppy/variants/atlas: add GPIO for bluetooth enable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ba940e89b1dc03548b7ab44b8f84dc9a3097acb Gerrit-Change-Number: 27185 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 06:19:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add GPIO for bluetooth enable
by Caveh Jalali (Code Review) 22 Jun '18

22 Jun '18

Hello caveh jalali, I'd like you to do a code review. Please visit https://review.coreboot.org/27185 to review the following change. Change subject: mb/google/poppy/variants/atlas: add GPIO for bluetooth enable ...................................................................... mb/google/poppy/variants/atlas: add GPIO for bluetooth enable This configures a GPIO pin for enabling/disabling bluetooth on the next version of the atlas board. The default is for bluetooth to be enabled at this point. BUG=b:110614620,b:110613353 BRANCH=none TEST=none Change-Id: I4ba940e89b1dc03548b7ab44b8f84dc9a3097acb Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/27185/1 diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c index b374265..d99a0e4 100644 --- a/src/mainboard/google/poppy/variants/atlas/gpio.c +++ b/src/mainboard/google/poppy/variants/atlas/gpio.c @@ -213,8 +213,8 @@ PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST), /* E1 : SATAXPCIE1 ==> NC */ PAD_CFG_NC(GPP_E1), - /* E2 : SATAXPCIE2 ==> NC */ - PAD_CFG_NC(GPP_E2), + /* E2 : SATAXPCIE2 ==> BT_DISABLE_L */ + PAD_CFG_GPO(GPP_E2, 1, DEEP), /* E3 : CPU_GP0 ==> NC */ PAD_CFG_NC(GPP_E3), /* E4 : SATA_DEVSLP0 ==> NC */ -- To view, visit https://review.coreboot.org/27185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4ba940e89b1dc03548b7ab44b8f84dc9a3097acb Gerrit-Change-Number: 27185 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27184 ) Change subject: mb/google/poppy/variants/atlas: add two new memory options ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29253/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75185/ : SUCCESS -- To view, visit https://review.coreboot.org/27184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Gerrit-Change-Number: 27184 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 05:29:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
by Furquan Shaikh (Code Review) 22 Jun '18

22 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27184 ) Change subject: mb/google/poppy/variants/atlas: add two new memory options ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Gerrit-Change-Number: 27184 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 05:27:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
by caveh jalali (Code Review) 22 Jun '18

22 Jun '18

caveh jalali has posted comments on this change. ( https://review.coreboot.org/27184 ) Change subject: mb/google/poppy/variants/atlas: add two new memory options ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27184/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/Makefile.inc: https://review.coreboot.org/#/c/27184/1/src/mainboard/google/poppy/variants… PS1, Line 12: > other lines don't use a tab here. Done -- To view, visit https://review.coreboot.org/27184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Gerrit-Change-Number: 27184 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 05:24:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27184 ) Change subject: mb/google/poppy/variants/atlas: add two new memory options ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29252/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75184/ : SUCCESS -- To view, visit https://review.coreboot.org/27184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Gerrit-Change-Number: 27184 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 05:24:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
by Caveh Jalali (Code Review) 22 Jun '18

22 Jun '18

Hello caveh jalali, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27184 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/atlas: add two new memory options ...................................................................... mb/google/poppy/variants/atlas: add two new memory options - add K4E6E304EC-EGCF and K4EBE304EC-EGCF to memory strapping table BUG=b:110498646 BRANCH=none TEST=none Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/27184/2 -- To view, visit https://review.coreboot.org/27184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Gerrit-Change-Number: 27184 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
by Furquan Shaikh (Code Review) 22 Jun '18

22 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27184 ) Change subject: mb/google/poppy/variants/atlas: add two new memory options ...................................................................... Patch Set 1: -Code-Review (2 comments) https://review.coreboot.org/#/c/27184/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/Makefile.inc: https://review.coreboot.org/#/c/27184/1/src/mainboard/google/poppy/variants… PS1, Line 12: One less space to match the formatting on other lines. https://review.coreboot.org/#/c/27184/1/src/mainboard/google/poppy/variants… PS1, Line 12: other lines don't use a tab here. -- To view, visit https://review.coreboot.org/27184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Gerrit-Change-Number: 27184 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 05:22:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
by Furquan Shaikh (Code Review) 22 Jun '18

22 Jun '18

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
by Caveh Jalali (Code Review) 22 Jun '18

22 Jun '18

Hello caveh jalali, I'd like you to do a code review. Please visit https://review.coreboot.org/27184 to review the following change. Change subject: mb/google/poppy/variants/atlas: add two new memory options ...................................................................... mb/google/poppy/variants/atlas: add two new memory options - add K4E6E304EC-EGCF and K4EBE304EC-EGCF to memory strapping table BUG=b:110498646 BRANCH=none TEST=none Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/27184/1 diff --git a/src/mainboard/google/poppy/variants/atlas/Makefile.inc b/src/mainboard/google/poppy/variants/atlas/Makefile.inc index 7c77696..c0f6a9c 100644 --- a/src/mainboard/google/poppy/variants/atlas/Makefile.inc +++ b/src/mainboard/google/poppy/variants/atlas/Makefile.inc @@ -9,6 +9,8 @@ SPD_SOURCES += micron_dimm_MT52L512M32D2PF-107 # 0b0111 SPD_SOURCES += micron_dimm_MT52L1G32D4PG-107 # 0b1000 SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107 # 0b1001 +SPD_SOURCES += samsung_dimm_K4E6E304EC-EGCF # 0b1010 +SPD_SOURCES += samsung_dimm_K4EBE304EC-EGCF # 0b1011 bootblock-y += gpio.c -- To view, visit https://review.coreboot.org/27184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19 Gerrit-Change-Number: 27184 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018