coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: nb/intel/i945: Remove dead code when channel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27204 to look at the new patch set (#7). Change subject: nb/intel/i945: Remove dead code when channel B is empty ...................................................................... nb/intel/i945: Remove dead code when channel B is empty Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27204/7 -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/i945: Remove dead code when cannel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27204 to look at the new patch set (#6). Change subject: nb/intel/i945: Remove dead code when cannel B is empty ...................................................................... nb/intel/i945: Remove dead code when cannel B is empty Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27204/6 -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/i945: Fix C1DRBs values when channel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Fix C1DRBs values when channel B is empty ...................................................................... Patch Set 5: indeed, the code is correct. however, the old commented (dead) code is not correct: #if 0 /* Exception: Channel 1 is not populated. C1DRB stays zero */ if (sysinfo->dimm[2] == SYSINFO_DIMM_NOT_POPULATED && sysinfo->dimm[3] == SYSINFO_DIMM_NOT_POPULATED) cum1 = 0; #endif -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 12:18:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Fix C1DRBs values when channel B is empty
by Arthur Heymans (Code Review) 22 Jun '18

22 Jun '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Fix C1DRBs values when channel B is empty ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/27204/5//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27204/5//COMMIT_MSG@9 PS5, Line 9: C1DRBs must be programmed with the same value as C0DRB3 : when the channel B is empty. : If channels are interleaved, C0DRB* is equal to C1DRB*. The code and the comments suggest this is untrue so what makes you believe it is? -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 12:07:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Fix C1DRBs values when channel B is empty
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Fix C1DRBs values when channel B is empty ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75194/ : SUCCESS -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 11:33:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Fix C1DRBs values when channel B is empty
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Fix C1DRBs values when channel B is empty ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75193/ : ABORTED -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 11:29:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Fix C1DRBs values when channel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27204 to look at the new patch set (#5). Change subject: nb/intel/i945: Fix C1DRBs values when channel B is empty ...................................................................... nb/intel/i945: Fix C1DRBs values when channel B is empty C1DRBs must be programmed with the same value as C0DRB3 when the channel B is empty. If channels are interleaved, C0DRB* is equal to C1DRB*. Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 19 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27204/5 -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/i945: Fix C1DRBs values when channel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27204 to look at the new patch set (#4). Change subject: nb/intel/i945: Fix C1DRBs values when channel B is empty ...................................................................... nb/intel/i945: Fix C1DRBs values when channel B is empty C1DRBs must be programmed with the same value as C0DRB3 when the channel B is empty. If channels are interleave, C0DRB* is equal to C1DRB*. Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 19 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27204/4 -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/i945: Add C1DRBs when channel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Add C1DRBs when channel B is empty ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 11:21:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Add C1DRBs when channel B is empty
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Add C1DRBs when channel B is empty ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75191/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29259/ : SUCCESS -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 11:14:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018