coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: nb/intel/i945: Add C1DRBs when channel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27204 to look at the new patch set (#3). Change subject: nb/intel/i945: Add C1DRBs when channel B is empty ...................................................................... nb/intel/i945: Add C1DRBs when channel B is empty C1DRBs must be programmed with the same value as C0DRB3 when the channel B is empty. If channels are interleave, C0DRB* is equal to C1DRB*. Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 19 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27204/3 -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/i945: Add C1DRBs when channel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27204 to look at the new patch set (#2). Change subject: nb/intel/i945: Add C1DRBs when channel B is empty ...................................................................... nb/intel/i945: Add C1DRBs when channel B is empty C1DRBs must be programmed with the same value as C0DRB3 when the channel B is empty. If channels are interleave, C0DRB* is equal to C1DRB*. Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 19 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27204/2 -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/i945: Add C1DRBs when channel B is empty
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Add C1DRBs when channel B is empty ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75190/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29258/ : SUCCESS -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 11:00:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Add C1DRBs when channel B is empty
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Add C1DRBs when channel B is empty ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/27204/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/#/c/27204/1/src/northbridge/intel/i945/raminit.… PS1, Line 1197: /* If channel 1 is empty, all of the C1DRBs are programmed with the same value as C0DRB3 */ line over 80 characters https://review.coreboot.org/#/c/27204/1/src/northbridge/intel/i945/raminit.… PS1, Line 1207: if (!(sysinfo->interleaved) && (sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED || line over 80 characters -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 10:56:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Add C1DRBs when channel B is empty
by Elyes HAOUAS (Code Review) 22 Jun '18

22 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/27204 Change subject: nb/intel/i945: Add C1DRBs when channel B is empty ...................................................................... nb/intel/i945: Add C1DRBs when channel B is empty C1DRBs must be programmed with the same value as C0DRB3 when the channel B is empty. If channels are interleave, C0DRB* is equal to C1DRB*. Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 16 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27204/1 diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index 6719961..615832d 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -1189,25 +1189,27 @@ for (i = 0; i < 2 * DIMM_SOCKETS; i++) { cum0 += sysinfo->banksize[i]; MCHBAR8(C0DRB0+i) = cum0; + /* If interleaved C0DRB's = C1DRB's */ + if (sysinfo->interleaved) + MCHBAR8(C1DRB0+i) = cum0; + } + + /* If channel 1 is empty, all of the C1DRBs are programmed with the same value as C0DRB3 */ + if (sysinfo->dimm[2] == SYSINFO_DIMM_NOT_POPULATED && + sysinfo->dimm[3] == SYSINFO_DIMM_NOT_POPULATED) { + for (i = 0; i < 2 * DIMM_SOCKETS; i++) + MCHBAR8(C1DRB0+i) = cum1; } /* Assume we continue in Channel 1 where we stopped in Channel 0 */ cum1 = cum0; - /* Exception: Interleaved starts from the beginning */ - if (sysinfo->interleaved) - cum1 = 0; - -#if 0 - /* Exception: Channel 1 is not populated. C1DRB stays zero */ - if (sysinfo->dimm[2] == SYSINFO_DIMM_NOT_POPULATED && - sysinfo->dimm[3] == SYSINFO_DIMM_NOT_POPULATED) - cum1 = 0; -#endif - - for (i = 0; i < 2 * DIMM_SOCKETS; i++) { - cum1 += sysinfo->banksize[i + 4]; - MCHBAR8(C1DRB0+i) = cum1; + if (!(sysinfo->interleaved) && (sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED || + sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED) { + for (i = 0; i < 2 * DIMM_SOCKETS; i++) { + cum1 += sysinfo->banksize[i + 4]; + MCHBAR8(C1DRB0+i) = cum1; + } } /* Set TOLUD Top Of Low Usable DRAM */ -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: cbfstool/fit.c: Fix for older CPUs without total_size in mcu_header
by Patrick Georgi (Code Review) 22 Jun '18

22 Jun '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27090 ) Change subject: cbfstool/fit.c: Fix for older CPUs without total_size in mcu_header ...................................................................... cbfstool/fit.c: Fix for older CPUs without total_size in mcu_header Some older CPUs have a fixed size of 2048 bytes for microcode total size. Change-Id: Ia50c087af41b0df14b607ce3c3b4eabc602e8738 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/27090 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/cbfstool/fit.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/util/cbfstool/fit.c b/util/cbfstool/fit.c index e3e6c32..d33cb56 100644 --- a/util/cbfstool/fit.c +++ b/util/cbfstool/fit.c @@ -226,13 +226,18 @@ mcu_header = rom_buffer_pointer(&image->buffer, current_offset); + /* Newer microcode updates include a size field, whereas older + * containers set it at 0 and are exactly 2048 bytes long */ + uint32_t total_size = mcu_header->total_size + ? mcu_header->total_size : 2048; + /* Quickly sanity check a prospective microcode update. */ - if (mcu_header->total_size < sizeof(*mcu_header)) + if (total_size < sizeof(*mcu_header)) break; /* FIXME: Should the checksum be validated? */ mcus[num_mcus].offset = current_offset; - mcus[num_mcus].size = mcu_header->total_size; + mcus[num_mcus].size = total_size; /* Proceed to next payload. */ current_offset += mcus[num_mcus].size; -- To view, visit https://review.coreboot.org/27090 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia50c087af41b0df14b607ce3c3b4eabc602e8738 Gerrit-Change-Number: 27090 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: payloads/LinuxBoot: Add ARM64 support
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25152 ) Change subject: payloads/LinuxBoot: Add ARM64 support ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29257/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75189/ : SUCCESS -- To view, visit https://review.coreboot.org/25152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a0cc248283432fb2384956ca55e687d4127398c Gerrit-Change-Number: 25152 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 07:56:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads/LinuxBoot: Add ARM64 support
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25152 ) Change subject: payloads/LinuxBoot: Add ARM64 support ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75188/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29256/ : SUCCESS -- To view, visit https://review.coreboot.org/25152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a0cc248283432fb2384956ca55e687d4127398c Gerrit-Change-Number: 25152 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 07:50:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 ) Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ...................................................................... Patch Set 43: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29255/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75187/ : SUCCESS -- To view, visit https://review.coreboot.org/26132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a Gerrit-Change-Number: 26132 Gerrit-PatchSet: 43 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 06:46:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: add GPIO for bluetooth enable
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27185 ) Change subject: mb/google/poppy/variants/atlas: add GPIO for bluetooth enable ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29254/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75186/ : SUCCESS -- To view, visit https://review.coreboot.org/27185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ba940e89b1dc03548b7ab44b8f84dc9a3097acb Gerrit-Change-Number: 27185 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 06:24:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018