coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29279/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75216/ : SUCCESS -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 7 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Fri, 22 Jun 2018 19:56:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29278/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/75215/ : ABORTED -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 6 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Fri, 22 Jun 2018 19:46:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Enable camera sensors
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26283 ) Change subject: mainboard/google/nocturne: Enable camera sensors ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29277/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75214/ : SUCCESS -- To view, visit https://review.coreboot.org/26283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c877df8062d5c79e25ed27775ab58e977555db Gerrit-Change-Number: 26283 Gerrit-PatchSet: 10 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward #1002003 Gerrit-Comment-Date: Fri, 22 Jun 2018 19:22:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/skylake: nhlt: Add capture config for echo ref stream for Max98...
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27182 ) Change subject: intel/skylake: nhlt: Add capture config for echo ref stream for Max98373 Codec ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75213/ : SUCCESS -- To view, visit https://review.coreboot.org/27182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fe619ece94d5011caffe37ef10b48f956938db9 Gerrit-Change-Number: 27182 Gerrit-PatchSet: 2 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 18:51:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/i2c/alps: Get rid of i2c/alps driver
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27208 ) Change subject: drivers/i2c/alps: Get rid of i2c/alps driver ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29276/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75212/ : SUCCESS -- To view, visit https://review.coreboot.org/27208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60761c384f3d800532b2b346272da7be28b77acd Gerrit-Change-Number: 27208 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 17:30:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Remove dead code
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27204 ) Change subject: nb/intel/i945: Remove dead code ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75211/ : SUCCESS -- To view, visit https://review.coreboot.org/27204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b Gerrit-Change-Number: 27204 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 17:29:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [wip]soc/intel/cannonlake: Enable DPTF in coreboot side
by Lijian Zhao (Code Review) 22 Jun '18

22 Jun '18

Lijian Zhao has abandoned this change. ( https://review.coreboot.org/25502 ) Change subject: [wip]soc/intel/cannonlake: Enable DPTF in coreboot side ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/25502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ia71cd6ad3b905544626e5943a3f9d2d2c3e5718b Gerrit-Change-Number: 25502 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com>

1 0

Change in coreboot[master]: drivers/i2c/alps: Get rid of i2c/alps driver
by Furquan Shaikh (Code Review) 22 Jun '18

22 Jun '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27208 Change subject: drivers/i2c/alps: Get rid of i2c/alps driver ...................................................................... drivers/i2c/alps: Get rid of i2c/alps driver i2c/alps driver implementation is an exact copy of the i2c/hid driver with only the addition of ALPS0001_HID. This can be supported by the i2c/hid driver using the hid field in devicetree which is what glkrvp mainboard does. So, this change removes the i2c/alps driver which is anyways unused. Change-Id: I60761c384f3d800532b2b346272da7be28b77acd Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- D src/drivers/i2c/alps/Kconfig D src/drivers/i2c/alps/Makefile.inc D src/drivers/i2c/alps/alps.c D src/drivers/i2c/alps/chip.h 4 files changed, 0 insertions(+), 94 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/27208/1 diff --git a/src/drivers/i2c/alps/Kconfig b/src/drivers/i2c/alps/Kconfig deleted file mode 100644 index b49581d..0000000 --- a/src/drivers/i2c/alps/Kconfig +++ /dev/null @@ -1,3 +0,0 @@ -config DRIVERS_I2C_ALPS - bool - select DRIVERS_I2C_GENERIC diff --git a/src/drivers/i2c/alps/Makefile.inc b/src/drivers/i2c/alps/Makefile.inc deleted file mode 100644 index aa18034..0000000 --- a/src/drivers/i2c/alps/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -ramstage-$(CONFIG_DRIVERS_I2C_ALPS) += alps.c diff --git a/src/drivers/i2c/alps/alps.c b/src/drivers/i2c/alps/alps.c deleted file mode 100644 index 2862374..0000000 --- a/src/drivers/i2c/alps/alps.c +++ /dev/null @@ -1,60 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2016 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <arch/acpigen_dsm.h> -#include <device/device.h> -#include <stdint.h> -#include "chip.h" - -static void i2c_alps_fill_dsm(struct device *dev) -{ - struct drivers_i2c_alps_config *config = dev->chip_info; - struct dsm_i2c_hid_config dsm_config = { - .hid_desc_reg_offset = config->hid_desc_reg_offset, - }; - - acpigen_write_dsm_i2c_hid(&dsm_config); -} - -static void i2c_alps_fill_ssdt_generator(struct device *dev) -{ - struct drivers_i2c_alps_config *config = dev->chip_info; - i2c_generic_fill_ssdt(dev, &i2c_alps_fill_dsm, &config->generic); -} - -static const char *i2c_alps_acpi_name(const struct device *dev) -{ - return "ALPS"; -} - -static struct device_operations i2c_alps_ops = { - .read_resources = DEVICE_NOOP, - .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, -#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES) - .acpi_name = &i2c_alps_acpi_name, - .acpi_fill_ssdt_generator = &i2c_alps_fill_ssdt_generator, -#endif -}; - -static void i2c_alps_enable(struct device *dev) -{ - dev->ops = &i2c_alps_ops; -} - -struct chip_operations drivers_i2c_alps_ops = { - CHIP_NAME("ALPS I2C Device") - .enable_dev = &i2c_alps_enable -}; diff --git a/src/drivers/i2c/alps/chip.h b/src/drivers/i2c/alps/chip.h deleted file mode 100644 index fb0b0fa..0000000 --- a/src/drivers/i2c/alps/chip.h +++ /dev/null @@ -1,30 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2016 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef __I2C_ALPS_CHIP_H__ -#define __I2C_ALPS_CHIP_H__ - -#include <drivers/i2c/generic/chip.h> - -#define ALPS0001_HID "ALPS0001" -#define PNP0C50_CID "PNP0C50" -#define ALPS_TP_DESC "ALPS Touchpad" - -struct drivers_i2c_alps_config { - struct drivers_i2c_generic_config generic; - uint8_t hid_desc_reg_offset; -}; - -#endif /* __I2C_ALPS_CHIP_H__ */ -- To view, visit https://review.coreboot.org/27208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I60761c384f3d800532b2b346272da7be28b77acd Gerrit-Change-Number: 27208 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: drivers/i2c/sx9310: Check for config not being NULL before using it
by build bot (Jenkins) (Code Review) 22 Jun '18

22 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27207 ) Change subject: drivers/i2c/sx9310: Check for config not being NULL before using it ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29275/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75210/ : SUCCESS -- To view, visit https://review.coreboot.org/27207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f0cd2bf2437fc640f4cf8d8203a971daf1f8d17 Gerrit-Change-Number: 27207 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Jun 2018 17:19:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/i2c/sx9310: Check for config not being NULL before using it
by Furquan Shaikh (Code Review) 22 Jun '18

22 Jun '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27207 Change subject: drivers/i2c/sx9310: Check for config not being NULL before using it ...................................................................... drivers/i2c/sx9310: Check for config not being NULL before using it This change fixes the issue reported by Coverity CID 1393576 to ensure that config is checked for NULL before it is actually used. Change-Id: I5f0cd2bf2437fc640f4cf8d8203a971daf1f8d17 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/drivers/i2c/sx9310/sx9310.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/27207/1 diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index 7da87c4..5f63734 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -36,7 +36,7 @@ struct acpi_i2c i2c = { .address = dev->path.i2c.device, .mode_10bit = dev->path.i2c.mode_10bit, - .speed = config->speed ? : I2C_SPEED_FAST, + .speed = I2C_SPEED_FAST, .resource = scope, }; struct acpi_dp *dsd; @@ -44,6 +44,9 @@ if (!dev->enabled || !scope || !config) return; + if (config->speed) + i2c.speed = config->speed; + /* Device */ acpigen_write_scope(scope); acpigen_write_device(acpi_device_name(dev)); -- To view, visit https://review.coreboot.org/27207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5f0cd2bf2437fc640f4cf8d8203a971daf1f8d17 Gerrit-Change-Number: 27207 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018