Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/27265 )
Change subject: nocturne: Do not set 4 LSB of SX9310 CRTL0
......................................................................
Patch Set 3:
Cleaned, my tree was checkout with "Subproject commit" changes, did git commit -as ... by mistake.
--
To view, visit https://review.coreboot.org/27265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-…
[View More]Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e10f5570ac82124f7f4b5cc7aaad27da0c578be
Gerrit-Change-Number: 27265
Gerrit-PatchSet: 3
Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Comment-Date: Thu, 28 Jun 2018 20:34:29 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
[View Less]
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27265
to look at the new patch set (#3).
Change subject: nocturne: Do not set 4 LSB of SX9310 CRTL0
......................................................................
nocturne: Do not set 4 LSB of SX9310 CRTL0
These bits start the acquisition process. They should only be set by the
driver.
BUG=b:74363445
TEST=compile
Change-Id: I9e10f5570ac82124f7f4b5cc7aaad27da0c578be
Signed-…
[View More]off-by: Gwendal Grignou <gwendal(a)chromium.org>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/27265/3
--
To view, visit https://review.coreboot.org/27265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e10f5570ac82124f7f4b5cc7aaad27da0c578be
Gerrit-Change-Number: 27265
Gerrit-PatchSet: 3
Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
[View Less]