coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: smmstore: Add a key/val store facility in flash, mediated through SMM
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25182 ) Change subject: smmstore: Add a key/val store facility in flash, mediated through SMM ...................................................................... Patch Set 6: (16 comments) https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c: https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@30 PS6, Line 30: static int range_check(void *start, size_t size) { open brace '{' following function declarations go on the next line https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@36 PS6, Line 36: u32 smmstore_exec(u8 command, void* param) "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@43 PS6, Line 43: struct smmstore_params_read *params = (struct smmstore_params_read *)param; line over 80 characters https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@56 PS6, Line 56: struct smmstore_params_append *params = (struct smmstore_params_append *)param; line over 80 characters https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@76 PS6, Line 76: printk(BIOS_DEBUG, "Unknown SMM store command: 0x%02x\n", command); line over 80 characters https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c File src/drivers/smmstore/store.c: https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@60 PS6, Line 60: if (cbfs_locate_file_in_region(&file, CONFIG_SMMSTORE_REGION, CONFIG_SMMSTORE_FILENAME, NULL) < 0) { line over 80 characters https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@61 PS6, Line 61: printk(BIOS_WARNING, "smm store: Unable to find SMM store file in region '%s'\n", CONFIG_SMMSTORE_REGION); line over 80 characters https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@108 PS6, Line 108: int smmstore_append_data(void *key, uint32_t key_sz, void *value, uint32_t value_sz) line over 80 characters https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@161 PS6, Line 161: printk(BIOS_WARNING, "eof of data marker looks invalid: 0x%x\n", k_sz); line over 80 characters https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@167 PS6, Line 167: printk(BIOS_WARNING, "open (%zx, %zx) for writing\n", store.region.offset, store.region.size); line over 80 characters https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@179 PS6, Line 179: if (rdev_writeat(&store, &key_sz, end, 4) != 4) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@183 PS6, Line 183: if (rdev_writeat(&store, &value_sz, end, 4) != 4) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@187 PS6, Line 187: if (rdev_writeat(&store, key, end, key_sz) != key_sz) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@191 PS6, Line 191: if (rdev_writeat(&store, value, end, value_sz) != value_sz) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@196 PS6, Line 196: if (rdev_writeat(&store, &nul, end, 1) != 1) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25182/6/src/include/smmstore.h File src/include/smmstore.h: https://review.coreboot.org/#/c/25182/6/src/include/smmstore.h@49 PS6, Line 49: int smmstore_append_data(void *key, uint32_t key_sz, void *value, uint32_t value_sz); line over 80 characters -- To view, visit https://review.coreboot.org/25182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9553922f9dfa60b9d4b3576973ad4b84d3fe2fb5 Gerrit-Change-Number: 25182 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 16:17:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: arch/x86: add SMM caller
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25193 ) Change subject: arch/x86: add SMM caller ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29529/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75486/ : SUCCESS -- To view, visit https://review.coreboot.org/25193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a9cc626dae9a7751034615ef409eebc6035f5c3 Gerrit-Change-Number: 25193 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 16:17:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86: add SMM caller
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25193 ) Change subject: arch/x86: add SMM caller ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/25193/2/src/arch/x86/include/smm.h File src/arch/x86/include/smm.h: https://review.coreboot.org/#/c/25193/2/src/arch/x86/include/smm.h@25 PS2, Line 25: static inline u32 call_smm(u8 cmd, u8 subcmd, void *arg) { open brace '{' following function declarations go on the next line -- To view, visit https://review.coreboot.org/25193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a9cc626dae9a7751034615ef409eebc6035f5c3 Gerrit-Change-Number: 25193 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 16:16:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Move smihandler common functions into block/s...
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26138 ) Change subject: soc/intel/common/block: Move smihandler common functions into block/smihandler ...................................................................... Patch Set 34: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29528/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75484/ : SUCCESS -- To view, visit https://review.coreboot.org/26138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic082bc5d556dd19617d83ab86f93a53574b5bc03 Gerrit-Change-Number: 26138 Gerrit-PatchSet: 34 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 13:26:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move smihandler common functions into block/s...
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26138 ) Change subject: soc/intel/common/block: Move smihandler common functions into block/smihandler ...................................................................... Patch Set 33: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75483/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29527/ : SUCCESS -- To view, visit https://review.coreboot.org/26138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic082bc5d556dd19617d83ab86f93a53574b5bc03 Gerrit-Change-Number: 26138 Gerrit-PatchSet: 33 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 13:16:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/common/block/systemagent: Add provision to configure PCIEXBAR f...
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27262 ) Change subject: intel/common/block/systemagent: Add provision to configure PCIEXBAR from soc ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29526/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75482/ : SUCCESS -- To view, visit https://review.coreboot.org/27262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b0e9c927d395ac6d27201e0b3a8658e958518a Gerrit-Change-Number: 27262 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 12:47:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/device: Add check for existence and validity of PCIE base address...
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27263 ) Change subject: src/device: Add check for existence and validity of PCIE base address config ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29525/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75481/ : SUCCESS -- To view, visit https://review.coreboot.org/27263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b0e9c927d395ac6d27201e0b3a8658e958518d Gerrit-Change-Number: 27263 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 12:45:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/device: Add check for existence and validity of PCIE base address...
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27263 ) Change subject: src/device: Add check for existence and validity of PCIE base address config ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29524/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75480/ : SUCCESS -- To view, visit https://review.coreboot.org/27263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b0e9c927d395ac6d27201e0b3a8658e958518d Gerrit-Change-Number: 27263 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 12:11:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/device: Add check for existence and validity of PCIE base address...
by Aamir Bohra (Code Review) 28 Jun '18

28 Jun '18

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/27263 Change subject: src/device: Add check for existence and validity of PCIE base address config ...................................................................... src/device: Add check for existence and validity of PCIE base address config Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> Change-Id: I89b0e9c927d395ac6d27201e0b3a8658e958518d --- M src/device/pci_ops_mmconf.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/27263/1 diff --git a/src/device/pci_ops_mmconf.c b/src/device/pci_ops_mmconf.c index fb085a6..e822ead 100644 --- a/src/device/pci_ops_mmconf.c +++ b/src/device/pci_ops_mmconf.c @@ -17,6 +17,10 @@ #include <device/pci_ids.h> #include <device/pci_ops.h> +#if !defined(CONFIG_MMCONF_BASE_ADDRESS) || !CONFIG_MMCONF_BASE_ADDRESS +#error "PCI Express MMIO base address (PCIEXBAR) needs to be non-zero!" +#endif + /* * Functions for accessing PCI configuration space with mmconf accesses */ -- To view, visit https://review.coreboot.org/27263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I89b0e9c927d395ac6d27201e0b3a8658e958518d Gerrit-Change-Number: 27263 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com>

1 0

Change in coreboot[master]: intel/common/block/systemagent: Add provision to configure PCIEXBAR f...
by build bot (Jenkins) (Code Review) 28 Jun '18

28 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27262 ) Change subject: intel/common/block/systemagent: Add provision to configure PCIEXBAR from soc ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29523/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75479/ : SUCCESS -- To view, visit https://review.coreboot.org/27262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b0e9c927d395ac6d27201e0b3a8658e958518a Gerrit-Change-Number: 27262 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 10:43:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018