coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by Elyes HAOUAS (Code Review) 13 Jun '18

13 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27096 to look at the new patch set (#4). Change subject: src: Use NULL instead of 0 for pointer ...................................................................... src: Use NULL instead of 0 for pointer Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/exception.c M src/arch/x86/mpspec.c M src/arch/x86/smbios.c M src/drivers/amd/agesa/oem_s3.c M src/drivers/i2c/tpm/tis.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/stage_cache.c M src/drivers/intel/fsp2_0/mma_core.c M src/drivers/intel/fsp2_0/stage_cache.c M src/drivers/intel/i210/i210.c M src/drivers/pc80/vga/vga.c M src/drivers/spi/tpm/tpm.c M src/drivers/xgi/common/vb_setmode.c M src/ec/google/chromeec/ec.c M src/lib/device_tree.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/poppy/variants/atlas/nhlt.c M src/mainboard/google/poppy/variants/baseboard/gpio.c M src/mainboard/google/poppy/variants/baseboard/nhlt.c M src/mainboard/google/poppy/variants/nami/nhlt.c M src/mainboard/google/poppy/variants/nautilus/nhlt.c M src/mainboard/google/poppy/variants/nocturne/nhlt.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c M src/mainboard/google/reef/mainboard.c M src/northbridge/amd/amdmct/mct/mct_d_gcc.c M src/northbridge/amd/amdmct/mct/mctardk3.c M src/northbridge/amd/amdmct/mct/mctardk4.c M src/northbridge/amd/amdmct/mct/mctdqs_d.c M src/northbridge/amd/amdmct/mct/mctpro_d.c M src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.c M src/northbridge/amd/amdmct/mct_ddr3/mctardk6.c M src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c M src/northbridge/amd/amdmct/mct_ddr3/mcttmrl.c M src/northbridge/amd/amdmct/mct_ddr3/s3utils.c M src/northbridge/intel/fsp_rangeley/northbridge.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/gm45/raminit.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/i945/northbridge.c M src/northbridge/intel/i945/rcven.c M src/northbridge/intel/nehalem/raminit.c M src/northbridge/intel/pineview/ram_calc.c M src/northbridge/intel/pineview/raminit.c M src/northbridge/intel/sandybridge/northbridge.c M src/northbridge/intel/x4x/ram_calc.c M src/northbridge/intel/x4x/raminit.c M src/soc/amd/stoneyridge/gpio.c M src/soc/intel/broadwell/igd.c M src/soc/intel/broadwell/systemagent.c M src/soc/intel/common/block/acpi/acpi.c 53 files changed, 81 insertions(+), 81 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27096/4 -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in libgfxinit[master]: gma config: Introduce per generation/CPU booleans
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27060 ) Change subject: gma config: Introduce per generation/CPU booleans ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I307d1dd56f480fdb4fbc6e2e25fc5f413c4158f8 Gerrit-Change-Number: 27060 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:13:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27096 ) Change subject: src: Use NULL instead of 0 for pointer ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74884/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28986/ : SUCCESS -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:10:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27096 ) Change subject: src: Use NULL instead of 0 for pointer ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/27096/3/src/device/oprom/x86emu/debug.c File src/device/oprom/x86emu/debug.c: https://review.coreboot.org/#/c/27096/3/src/device/oprom/x86emu/debug.c@334 PS3, Line 334: *n = NULL; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:06:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by Elyes HAOUAS (Code Review) 13 Jun '18

13 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27096 to look at the new patch set (#3). Change subject: src: Use NULL instead of 0 for pointer ...................................................................... src: Use NULL instead of 0 for pointer Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/exception.c M src/arch/x86/mpspec.c M src/arch/x86/smbios.c M src/device/oprom/x86emu/debug.c M src/drivers/amd/agesa/oem_s3.c M src/drivers/i2c/tpm/tis.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/stage_cache.c M src/drivers/intel/fsp2_0/mma_core.c M src/drivers/intel/fsp2_0/stage_cache.c M src/drivers/intel/i210/i210.c M src/drivers/pc80/vga/vga.c M src/drivers/spi/tpm/tpm.c M src/drivers/xgi/common/vb_setmode.c M src/ec/google/chromeec/ec.c M src/lib/device_tree.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/poppy/variants/atlas/nhlt.c M src/mainboard/google/poppy/variants/baseboard/gpio.c M src/mainboard/google/poppy/variants/baseboard/nhlt.c M src/mainboard/google/poppy/variants/nami/nhlt.c M src/mainboard/google/poppy/variants/nautilus/nhlt.c M src/mainboard/google/poppy/variants/nocturne/nhlt.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c M src/mainboard/google/reef/mainboard.c M src/northbridge/amd/amdmct/mct/mct_d_gcc.c M src/northbridge/amd/amdmct/mct/mctardk3.c M src/northbridge/amd/amdmct/mct/mctardk4.c M src/northbridge/amd/amdmct/mct/mctdqs_d.c M src/northbridge/amd/amdmct/mct/mctpro_d.c M src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.c M src/northbridge/amd/amdmct/mct_ddr3/mctardk6.c M src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c M src/northbridge/amd/amdmct/mct_ddr3/mcttmrl.c M src/northbridge/amd/amdmct/mct_ddr3/s3utils.c M src/northbridge/intel/fsp_rangeley/northbridge.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/gm45/raminit.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/i945/northbridge.c M src/northbridge/intel/i945/rcven.c M src/northbridge/intel/nehalem/raminit.c M src/northbridge/intel/pineview/ram_calc.c M src/northbridge/intel/pineview/raminit.c M src/northbridge/intel/sandybridge/northbridge.c M src/northbridge/intel/x4x/ram_calc.c M src/northbridge/intel/x4x/raminit.c M src/soc/amd/stoneyridge/gpio.c M src/soc/intel/broadwell/igd.c M src/soc/intel/broadwell/systemagent.c M src/soc/intel/common/block/acpi/acpi.c 54 files changed, 82 insertions(+), 82 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27096/3 -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/abuild: Fix building when not in coreboot root dir
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27095 ) Change subject: util/abuild: Fix building when not in coreboot root dir ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/28985/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74883/ : SUCCESS -- To view, visit https://review.coreboot.org/27095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe54096f275a05bda745ae2cc76c0109281c0c4b Gerrit-Change-Number: 27095 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:02:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27096 ) Change subject: src: Use NULL instead of 0 for pointer ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74882/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28984/ : SUCCESS -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:01:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/abuild: Fix building when not in coreboot root dir
by Arthur Heymans (Code Review) 13 Jun '18

13 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27095 to look at the new patch set (#3). Change subject: util/abuild: Fix building when not in coreboot root dir ...................................................................... util/abuild: Fix building when not in coreboot root dir Change-Id: Ibe54096f275a05bda745ae2cc76c0109281c0c4b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/abuild/abuild 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/27095/3 -- To view, visit https://review.coreboot.org/27095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe54096f275a05bda745ae2cc76c0109281c0c4b Gerrit-Change-Number: 27095 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in libgfxinit[master]: gma: Introduce Generation type
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27059 ) Change subject: gma: Introduce Generation type ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/27059/1/common/Makefile.inc File common/Makefile.inc: https://review.coreboot.org/#/c/27059/1/common/Makefile.inc@47 PS1, Line 47: missing $(call strip_quotes,...) https://review.coreboot.org/#/c/27059/1/common/hw-gfx-gma-config.ads.templa… File common/hw-gfx-gma-config.ads.template: https://review.coreboot.org/#/c/27059/1/common/hw-gfx-gma-config.ads.templa… PS1, Line 39: Introduce Gen_* booleans here already? -- To view, visit https://review.coreboot.org/27059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5061021a80cd75ee3d7996ca343e6388b22bf341 Gerrit-Change-Number: 27059 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 20:57:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27096 ) Change subject: src: Use NULL instead of 0 for pointer ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/74881/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/28983/ : SUCCESS -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 20:57:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018