coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: soc/intel/apollolake: unify definition for spi base address
by Furquan Shaikh (Code Review) 13 Jun '18

13 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27097 ) Change subject: soc/intel/apollolake: unify definition for spi base address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibcb013fc95de29234253e89c9ca100cc468d44f6 Gerrit-Change-Number: 27097 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 01:19:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/{glk, apl} and mainboards: Configure LPC_CLKRUN# pin as GPIO...
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23742 ) Change subject: soc/intel/{glk,apl} and mainboards: Configure LPC_CLKRUN# pin as GPIO for S0ix ...................................................................... Patch Set 14: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29000/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74898/ : SUCCESS -- To view, visit https://review.coreboot.org/23742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c1013fee638a3b7a91469736efc0c25a1597fa Gerrit-Change-Number: 23742 Gerrit-PatchSet: 14 Gerrit-Owner: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:44:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] soc/intel/apollolake: Use bootblock common stage
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25802 ) Change subject: [WIP] soc/intel/apollolake: Use bootblock common stage ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/28998/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74896/ : SUCCESS -- To view, visit https://review.coreboot.org/25802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I319453c902632f26eec63ab9c1e9bb6956b466fb Gerrit-Change-Number: 25802 Gerrit-PatchSet: 10 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:41:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] soc/intel/cannonlake: Use bootblock common stage
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

1 0

Change in coreboot[master]: [WIP]soc/intel/common: Add common code to report platform information
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25810 ) Change subject: [WIP]soc/intel/common: Add common code to report platform information ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/28997/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74895/ : SUCCESS -- To view, visit https://review.coreboot.org/25810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1497b72f784db00a334544f6c5ddc2774049107 Gerrit-Change-Number: 25810 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:34:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/apollolake: unify definition for spi base address
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27097 ) Change subject: soc/intel/apollolake: unify definition for spi base address ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/28995/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74893/ : SUCCESS -- To view, visit https://review.coreboot.org/27097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibcb013fc95de29234253e89c9ca100cc468d44f6 Gerrit-Change-Number: 27097 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:30:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]soc/intel/common: Add bootblock common stage file
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18457 ) Change subject: [WIP]soc/intel/common: Add bootblock common stage file ...................................................................... Patch Set 17: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/28996/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74894/ : SUCCESS -- To view, visit https://review.coreboot.org/18457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If84c08d33f6f8fd3cd9722ee893653f1d1ae90c1 Gerrit-Change-Number: 18457 Gerrit-PatchSet: 17 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:30:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma config: Tag constants depending on generation or CPU
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27067 ) Change subject: gma config: Tag constants depending on generation or CPU ...................................................................... Patch Set 1: Verified+1 (1 comment) https://review.coreboot.org/#/c/27067/1/common/hw-gfx-gma-config.ads.templa… File common/hw-gfx-gma-config.ads.template: https://review.coreboot.org/#/c/27067/1/common/hw-gfx-gma-config.ads.templa… PS1, Line 177: (DDI_HDMI_Buffer_Translation /= -1); spurious -- To view, visit https://review.coreboot.org/27067 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa50987c51dc62ab2eb8b31e8f223b8a94e8ac12 Gerrit-Change-Number: 27067 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:28:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] soc/intel/cannonlake: Use bootblock common stage
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25811 ) Change subject: [WIP] soc/intel/cannonlake: Use bootblock common stage ...................................................................... Patch Set 7: (4 comments) https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/… File src/soc/intel/cannonlake/bootblock/report_platform.c: https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/… PS7, Line 55: const struct cpu_info* soc_get_cpu_id_table(void) "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/… PS7, Line 60: const struct mch_info* soc_get_mch_id_table(void) "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/… PS7, Line 65: const struct pch_info* soc_get_pch_id_table(void) "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/… PS7, Line 70: const struct igd_info* soc_get_igd_id_table(void) "foo* bar" should be "foo *bar" -- To view, visit https://review.coreboot.org/25811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4397c6d599a9f4ef235755835db3f4d22f81674e Gerrit-Change-Number: 25811 Gerrit-PatchSet: 7 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:27:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by Martin Roth (Code Review) 13 Jun '18

13 Jun '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27096 ) Change subject: src: Use NULL instead of 0 for pointer ...................................................................... Patch Set 6: This isn't right. When you're assigning *ptr = 0, you're setting the value of the address pointed to by ptr to 0, not setting the address of ptr to NULL. Look up dereferencing a pointer. -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:26:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018