coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27096 ) Change subject: src: Use NULL instead of 0 for pointer ...................................................................... Patch Set 5: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74887/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28989/ : SUCCESS -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:52:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by Elyes HAOUAS (Code Review) 13 Jun '18

13 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27096 to look at the new patch set (#5). Change subject: src: Use NULL instead of 0 for pointer ...................................................................... src: Use NULL instead of 0 for pointer Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/exception.c M src/drivers/i2c/tpm/tis.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/stage_cache.c M src/drivers/intel/fsp2_0/mma_core.c M src/drivers/intel/fsp2_0/stage_cache.c M src/drivers/pc80/vga/vga.c M src/drivers/spi/tpm/tpm.c M src/drivers/xgi/common/vb_setmode.c M src/ec/google/chromeec/ec.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/poppy/variants/atlas/nhlt.c M src/mainboard/google/poppy/variants/baseboard/gpio.c M src/mainboard/google/poppy/variants/baseboard/nhlt.c M src/mainboard/google/poppy/variants/nami/nhlt.c M src/mainboard/google/poppy/variants/nautilus/nhlt.c M src/mainboard/google/poppy/variants/nocturne/nhlt.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c M src/mainboard/google/reef/mainboard.c M src/northbridge/amd/amdmct/mct/mctardk3.c M src/northbridge/amd/amdmct/mct/mctardk4.c M src/northbridge/amd/amdmct/mct/mctdqs_d.c M src/northbridge/amd/amdmct/mct/mctpro_d.c M src/northbridge/amd/amdmct/mct_ddr3/mctardk6.c M src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c M src/northbridge/amd/amdmct/mct_ddr3/mcttmrl.c M src/northbridge/amd/amdmct/mct_ddr3/s3utils.c M src/northbridge/intel/pineview/raminit.c M src/northbridge/intel/x4x/raminit.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/ramtop.c M src/soc/intel/broadwell/igd.c M src/soc/intel/common/block/acpi/acpi.c M src/vendorcode/siemens/hwilib/hwilib.c 37 files changed, 57 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27096/5 -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in libgfxinit[master]: gma config: Initialize stateful configs late
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27066 ) Change subject: gma config: Initialize stateful configs late ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9192c9a7c4d67e4af7f3e26659489f58998ae832 Gerrit-Change-Number: 27066 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:43:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma config: Group mutable state into a record
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27065 ) Change subject: gma config: Group mutable state into a record ...................................................................... Patch Set 1: Verified+1 Need to find a better name than `Settings`. -- To view, visit https://review.coreboot.org/27065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffc7984b61e57cda7bdaf3b915a4fc51b396423a Gerrit-Change-Number: 27065 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:42:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma pipe setup: Drop explicit Global and Depends contracts
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27064 ) Change subject: gma pipe setup: Drop explicit Global and Depends contracts ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27064 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia75c78a7030960a56e9cb469601b24c677732875 Gerrit-Change-Number: 27064 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:41:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/pi: Add AgesaHeapRebase callout
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25458 ) Change subject: amd/pi: Add AgesaHeapRebase callout ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/28988/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74886/ : SUCCESS -- To view, visit https://review.coreboot.org/25458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieda202a6064302b21707bd7ddfabc132cd85ed45 Gerrit-Change-Number: 25458 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mei-Zee Yong <mei-zee.yong(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:27:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in libgfxinit[master]: gma: Give constants depending on Config.CPU* a type
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27063 ) Change subject: gma: Give constants depending on Config.CPU* a type ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b671cb18701d0ecae118e023e0fd21be5095da0 Gerrit-Change-Number: 27063 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:18:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma: Turn constants depending on Config.CPU* into functions
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27062 ) Change subject: gma: Turn constants depending on Config.CPU* into functions ...................................................................... Patch Set 1: Verified+1 (1 comment) https://review.coreboot.org/#/c/27062/1/common/ironlake/hw-gfx-gma-connecto… File common/ironlake/hw-gfx-gma-connectors-fdi.adb: https://review.coreboot.org/#/c/27062/1/common/ironlake/hw-gfx-gma-connecto… PS1, Line 51: DP_Info. maybe add `use HW.GFX.GMA.DP_Info.Training_Pattern;`? -- To view, visit https://review.coreboot.org/27062 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0522f5c63c63080bf9633f3d1b6019f35e52d226 Gerrit-Change-Number: 27062 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:18:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27096 ) Change subject: src: Use NULL instead of 0 for pointer ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74885/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28987/ : SUCCESS -- To view, visit https://review.coreboot.org/27096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c Gerrit-Change-Number: 27096 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:18:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma config: Limit types of CPU and CPU_Var
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27061 ) Change subject: gma config: Limit types of CPU and CPU_Var ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeca7d0fb5cbc617a0819448e78d406793c6f866 Gerrit-Change-Number: 27061 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 21:14:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018