coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in libgfxinit[master]: gma broxton power/clocks: Turn pre-condition into code
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27054 ) Change subject: gma broxton power/clocks: Turn pre-condition into code ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ccafdc91a6e11fdc565e154f1394598a4572449 Gerrit-Change-Number: 27054 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 20:10:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Enable camera sensors
by build bot (Jenkins) (Code Review) 13 Jun '18

13 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26283 ) Change subject: mainboard/google/nocturne: Enable camera sensors ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/28979/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74877/ : SUCCESS -- To view, visit https://review.coreboot.org/26283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c877df8062d5c79e25ed27775ab58e977555db Gerrit-Change-Number: 26283 Gerrit-PatchSet: 6 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward #1002003 Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Wed, 13 Jun 2018 20:01:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by Lijian Zhao (Code Review) 13 Jun '18

13 Jun '18

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/27094 Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... mainboard/google/nocturne: Set camera power sequence To make image senor working, the intended power sequence need to applied. BUG=NONE TEST=NONE Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h 3 files changed, 63 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/27094/1 diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl index c42188f..7396fc7 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl @@ -35,6 +35,34 @@ ) }) + Method (PMON, 0, Serialized) { + CTXS(RCAM_RST_L) + STXS(RCAM_PWR_EN) + STXS(PCH_RCAM_CLK_EN) + Sleep(3) + STXS(RCAM_RST_L) + } + + Method (PMOF, 0, Serialized) { + CTXS(RCAM_RST_L) + } + + Name (_PR0, Package (0x01) { RCPR }) + Name (_PR3, Package (0x01) { RCPR }) + + /* Power resource methods for Rear Camera */ + PowerResource (RCPR, 0, 0) { + Method (_ON, 0, Serialized) { + PMON() + } + Method (_OFF, 0, Serialized) { + PMOF() + } + Method (_STA, 0, Serialized) { + Return (0x0F) + } + } + /* Port0 of CAM0 is connected to port0 of CIO2 device */ Name (_DSD, Package () { ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl index 1859aaf..029429b 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl @@ -34,6 +34,33 @@ ) }) + Method (PMON, 0, Serialized) { + CTXS(FCAM_RST_L) + STXS(FCAM_PWR_EN) + STXS(PCH_FCAM_CLK_EN) + Sleep(3) + STXS(FCAM_RST_L) + } + + Method (PMOF, 0, Serialized) { + CTXS(FCAM_RST_L) + } + + Name (_PR0, Package (0x01) { FCPR }) + Name (_PR3, Package (0x01) { FCPR }) + + /* Power resource methods for Rear Camera */ + PowerResource (FCPR, 0, 0) { + Method (_ON, 0, Serialized) { + PMON() + } + Method (_OFF, 0, Serialized) { + PMOF() + } + Method (_STA, 0, Serialized) { + Return (0x0F) + } + } /* Port0 of CAM1 is connected to port1 of CIO2 device */ Name (_DSD, Package () { diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h index 08b51b2..2afb39c 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h @@ -37,4 +37,12 @@ /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI +/* Camera Sensor config */ +#define RCAM_PWR_EN GPP_D7 +#define PCH_RCAM_CLK_EN GPP_D14 +#define RCAM_RST_L GPP_D16 +#define FCAM_PWR_EN GPP_D8 +#define PCH_FCAM_CLK_EN GPP_D13 +#define FCAM_RST_L GPP_D15 + #endif /* BASEBOARD_GPIO_H */ -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in libgfxinit[master]: gma config: Introduce Is_ULT
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27053 ) Change subject: gma config: Introduce Is_ULT ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27053/1/common/skylake/hw-gfx-gma-connector… File common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb: https://review.coreboot.org/#/c/27053/1/common/skylake/hw-gfx-gma-connector… PS1, Line 104: (if Config.Is_ULT then `not Is_ULT` or reverse bodies -- To view, visit https://review.coreboot.org/27053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I545d74ba6cadb06479b29b85aa9dc2af2be564d6 Gerrit-Change-Number: 27053 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 19:44:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in libgfxinit[master]: gma config: Introduce Has_Ivy_Bridge_FDI
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27052 ) Change subject: gma config: Introduce Has_Ivy_Bridge_FDI ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27052/1/common/ironlake/hw-gfx-gma-connecto… File common/ironlake/hw-gfx-gma-connectors-fdi.adb: https://review.coreboot.org/#/c/27052/1/common/ironlake/hw-gfx-gma-connecto… PS1, Line 43: TP_SHIFT : constant := (if Config.Has_Ivy_Bridge_FDI then 8 else 28); could as well use `CPU_Ivybridge` later -- To view, visit https://review.coreboot.org/27052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2adeaef88fb79c40e999d0857f927ffe82a9c41b Gerrit-Change-Number: 27052 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 19:41:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in libgfxinit[master]: gma config: Introduce Has_Broadwell_DDI_Bufs
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27050 ) Change subject: gma config: Introduce Has_Broadwell_DDI_Bufs ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27050/1/common/haswell/hw-gfx-gma-connector… File common/haswell/hw-gfx-gma-connectors-ddi-buffers.adb: https://review.coreboot.org/#/c/27050/1/common/haswell/hw-gfx-gma-connector… PS1, Line 128: (if Config.Has_Broadwell_DDI_Bufs then could as well use `CPU_Broadwell` later -- To view, visit https://review.coreboot.org/27050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b17825006d35ec19ebf3e5a276aefa4d326fd73 Gerrit-Change-Number: 27050 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 19:38:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in libgfxinit[master]: gma config: Introduce Have_HDMI_Buf_Override
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27049 ) Change subject: gma config: Introduce Have_HDMI_Buf_Override ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27049/1/common/hw-gfx-gma-config.ads.templa… File common/hw-gfx-gma-config.ads.template: https://review.coreboot.org/#/c/27049/1/common/hw-gfx-gma-config.ads.templa… PS1, Line 39: DDI_HDMI_Buffer_Translation /= -1; maybe `>= 0` instead -- To view, visit https://review.coreboot.org/27049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id00ae200cc8d08ce245d57b2886a40f0fea10167 Gerrit-Change-Number: 27049 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 19:37:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in libgfxinit[master]: gma config: Introduce Has_Ivy_Bridge_FDI
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

1 0

Change in libgfxinit[master]: gma config: Introduce Has_Original_ILK_Trans
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27051 ) Change subject: gma config: Introduce Has_Original_ILK_Trans ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a5951abf62ed01583ad028bc944c0135744457 Gerrit-Change-Number: 27051 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 19:34:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma config: Introduce Has_Broadwell_DDI_Bufs
by Nico Huber (Code Review) 13 Jun '18

13 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27050 ) Change subject: gma config: Introduce Has_Broadwell_DDI_Bufs ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/27050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b17825006d35ec19ebf3e5a276aefa4d326fd73 Gerrit-Change-Number: 27050 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 13 Jun 2018 19:34:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018