coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: arch/x86/smbios: fix whitespace trimming
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26597 ) Change subject: arch/x86/smbios: fix whitespace trimming ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73538/ : SUCCESS -- To view, visit https://review.coreboot.org/26597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9e458f3072ed0496cbdd37c60567d5331afd42f Gerrit-Change-Number: 26597 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 18:58:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/common/spi.c: Add a SPI write protect function
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: mainboard/google/nocturne: Enable camera sensors
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26283 ) Change subject: mainboard/google/nocturne: Enable camera sensors ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73539/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27648/ : SUCCESS -- To view, visit https://review.coreboot.org/26283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c877df8062d5c79e25ed27775ab58e977555db Gerrit-Change-Number: 26283 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward #1002003 Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Tue, 29 May 2018 18:38:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/broadwell: decouple PEI memory struct from coreboot header
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26598 ) Change subject: soc/intel/broadwell: decouple PEI memory struct from coreboot header ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73537/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27647/ : SUCCESS -- To view, visit https://review.coreboot.org/26598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I932b7b41ae1e3fd364d056a8c91f7ed5d25dbafc Gerrit-Change-Number: 26598 Gerrit-PatchSet: 7 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 18:33:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/broadwell: decouple PEI memory struct from coreboot header
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26598 ) Change subject: soc/intel/broadwell: decouple PEI memory struct from coreboot header ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73536/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27646/ : SUCCESS -- To view, visit https://review.coreboot.org/26598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I932b7b41ae1e3fd364d056a8c91f7ed5d25dbafc Gerrit-Change-Number: 26598 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 18:19:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: include/bootstate.h: Remove whitespace before tab
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26666 ) Change subject: include/bootstate.h: Remove whitespace before tab ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73535/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27645/ : SUCCESS -- To view, visit https://review.coreboot.org/26666 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78e912e00a85eedc724206a32d5c3e32064ba5c8 Gerrit-Change-Number: 26666 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 17:51:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: include/bootstate.h: Remove whitespace before tab
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26666 ) Change subject: include/bootstate.h: Remove whitespace before tab ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/26666/1/src/include/bootstate.h File src/include/bootstate.h: https://review.coreboot.org/#/c/26666/1/src/include/bootstate.h@127 PS1, Line 127: #define INIT_BOOT_STATE_CALLBACK_DEBUG(bscb_) \ Single statement macros should not use a do {} while (0) loop -- To view, visit https://review.coreboot.org/26666 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78e912e00a85eedc724206a32d5c3e32064ba5c8 Gerrit-Change-Number: 26666 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 17:47:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: include/bootstate.h: Remove whitespace before tab
by Elyes HAOUAS (Code Review) 29 May '18

29 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26666 Change subject: include/bootstate.h: Remove whitespace before tab ...................................................................... include/bootstate.h: Remove whitespace before tab Change-Id: I78e912e00a85eedc724206a32d5c3e32064ba5c8 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/bootstate.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/26666/1 diff --git a/src/include/bootstate.h b/src/include/bootstate.h index c15cb30..edfabe5 100644 --- a/src/include/bootstate.h +++ b/src/include/bootstate.h @@ -124,7 +124,7 @@ #if IS_ENABLED(CONFIG_DEBUG_BOOT_STATE) #define BOOT_STATE_CALLBACK_LOC __FILE__ ":" STRINGIFY(__LINE__) #define BOOT_STATE_CALLBACK_INIT_DEBUG .location = BOOT_STATE_CALLBACK_LOC, -#define INIT_BOOT_STATE_CALLBACK_DEBUG(bscb_) \ +#define INIT_BOOT_STATE_CALLBACK_DEBUG(bscb_) \ do { \ bscb_->location = BOOT_STATE_CALLBACK_LOC; \ } while (0) -- To view, visit https://review.coreboot.org/26666 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I78e912e00a85eedc724206a32d5c3e32064ba5c8 Gerrit-Change-Number: 26666 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: sb/intel/common/spi.c: Add a SPI write protect function
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: sb/intel/common/spi.c: Add a SPI write protect function
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23146 ) Change subject: sb/intel/common/spi.c: Add a SPI write protect function ...................................................................... Patch Set 13: (4 comments) https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c File src/southbridge/intel/common/spi.c: https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c… PS13, Line 978: (((((limit) >> SPI_FPR_SHIFT) & ICH7_SPI_FPR_MASK) << ICH7_SPI_FPR_LIMIT_SHIFT) |\ line over 80 characters https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c… PS13, Line 979: ((((base) >> SPI_FPR_SHIFT) & ICH7_SPI_FPR_MASK) << SPI_FPR_BASE_SHIFT)) line over 80 characters https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c… PS13, Line 981: (((((limit) >> SPI_FPR_SHIFT) & ICH9_SPI_FPR_MASK) << ICH9_SPI_FPR_LIMIT_SHIFT) |\ line over 80 characters https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c… PS13, Line 982: ((((base) >> SPI_FPR_SHIFT) & ICH9_SPI_FPR_MASK) << SPI_FPR_BASE_SHIFT)) line over 80 characters -- To view, visit https://review.coreboot.org/23146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0a9a0de639c5d6761a77a56ceba6d89110a4ea1 Gerrit-Change-Number: 23146 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 16:53:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018