build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25414 )
Change subject: src/sb/intel/common/spi.c: Adapt and link in romstage
......................................................................
Patch Set 3:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/73530/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/27640/ : SUCCESS
--
To view, visit https://review.coreboot.org/25414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4671653c0b07ab5c4bf91128f18f142ce4f893cf
Gerrit-Change-Number: 25414
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christoph Pomaska <cp_public(a)posteo.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 29 May 2018 15:24:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25414 )
Change subject: src/sb/intel/common/spi.c: Adapt and link in romstage
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/25414/3/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/25414/3/src/southbridge/intel/common/spi.c@…
PS3, Line 321: car_set_var(g_ichspi_lock, readw_(&ich7_spi->spis) & HSFS_FLOCKDN);
line over 80 characters
https://review.coreboot.org/#/c/25414/3/src/southbridge/intel/common/spi.c@…
PS3, Line 957: writel_ (0x1000, &cntlr->ich9_spi->fdoc);
space prohibited between function name and open parenthesis '('
--
To view, visit https://review.coreboot.org/25414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4671653c0b07ab5c4bf91128f18f142ce4f893cf
Gerrit-Change-Number: 25414
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christoph Pomaska <cp_public(a)posteo.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 29 May 2018 15:20:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No