coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: soc/intel/broadwell: decouple PEI memory struct from coreboot header
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26598 ) Change subject: soc/intel/broadwell: decouple PEI memory struct from coreboot header ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73550/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27659/ : SUCCESS -- To view, visit https://review.coreboot.org/26598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I932b7b41ae1e3fd364d056a8c91f7ed5d25dbafc Gerrit-Change-Number: 26598 Gerrit-PatchSet: 8 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 20:54:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/cbfstool: Remove whitespace before tab
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26669 ) Change subject: util/cbfstool: Remove whitespace before tab ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73549/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27658/ : SUCCESS -- To view, visit https://review.coreboot.org/26669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I122acaf9129afaa7b3ae8fd50d8717138809132e Gerrit-Change-Number: 26669 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 20:36:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/superiotool: Remove whitespace before tab
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26668 ) Change subject: util/superiotool: Remove whitespace before tab ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73548/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27657/ : SUCCESS -- To view, visit https://review.coreboot.org/26668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie79cfb92cfb8b8f628aa4b12bba946b0479fc466 Gerrit-Change-Number: 26668 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 20:29:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/cbfstool: Remove whitespace before tab
by Elyes HAOUAS (Code Review) 29 May '18

29 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26669 Change subject: util/cbfstool: Remove whitespace before tab ...................................................................... util/cbfstool: Remove whitespace before tab Change-Id: I122acaf9129afaa7b3ae8fd50d8717138809132e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/cbfstool/cbfstool.c M util/cbfstool/linux.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/26669/1 diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index eecb84f..08f2e32 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -687,7 +687,7 @@ /* Set the alignment to 4KiB minimum for FSP blobs when no base address * is provided so that relocation can occur. */ if (param.type == CBFS_COMPONENT_FSP) { - if (!param.baseaddress_assigned) + if (!param.baseaddress_assigned) param.alignment = 4*1024; convert = cbfstool_convert_fsp; } else if (param.stage_xip) { diff --git a/util/cbfstool/linux.h b/util/cbfstool/linux.h index 249c7d7..c2d9079 100644 --- a/util/cbfstool/linux.h +++ b/util/cbfstool/linux.h @@ -149,7 +149,7 @@ u16 mount_root_rdonly; /* 0x1f2 */ u8 reserved7[4]; /* 0x1f4 */ u16 ramdisk_flags; /* 0x1f8 */ -#define RAMDISK_IMAGE_START_MASK 0x07FF +#define RAMDISK_IMAGE_START_MASK 0x07FF #define RAMDISK_PROMPT_FLAG 0x8000 #define RAMDISK_LOAD_FLAG 0x4000 u8 reserved8[2]; /* 0x1fa */ -- To view, visit https://review.coreboot.org/26669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I122acaf9129afaa7b3ae8fd50d8717138809132e Gerrit-Change-Number: 26669 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: util/superiotool: Remove whitespace before tab
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26668 ) Change subject: util/superiotool: Remove whitespace before tab ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/26668/1/util/superiotool/winbond.c File util/superiotool/winbond.c: https://review.coreboot.org/#/c/26668/1/util/superiotool/winbond.c@232 PS1, Line 232: {0xa23, "W83627UHG = NCT6627UD", { /* TODO: Not yet in sensors-detect */ line over 80 characters https://review.coreboot.org/#/c/26668/1/util/superiotool/winbond.c@233 PS1, Line 233: {NOLDN, NULL, /* CR2B (485) is only valid for chip rev.E */ line over 80 characters -- To view, visit https://review.coreboot.org/26668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie79cfb92cfb8b8f628aa4b12bba946b0479fc466 Gerrit-Change-Number: 26668 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 20:25:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/superiotool: Remove whitespace before tab
by Elyes HAOUAS (Code Review) 29 May '18

29 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26668 Change subject: util/superiotool: Remove whitespace before tab ...................................................................... util/superiotool: Remove whitespace before tab Change-Id: Ie79cfb92cfb8b8f628aa4b12bba946b0479fc466 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/superiotool/Makefile M util/superiotool/smsc.c M util/superiotool/superiotool.h M util/superiotool/winbond.c 4 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/26668/1 diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile index f05e1f9..cedd631 100644 --- a/util/superiotool/Makefile +++ b/util/superiotool/Makefile @@ -104,7 +104,7 @@ @printf "\nChecking for pciutils and zlib... " @echo "$$LIBPCI_TEST" > .test.c @$(CC) $(CFLAGS) .test.c -o .test $(LIBS) >/dev/null 2>&1 && \ - printf "found.\n" || ( printf "not found.\n\n"; \ + printf "found.\n" || ( printf "not found.\n\n"; \ printf "Please install pciutils-devel and zlib-devel.\n"; \ printf "See README for more information.\n\n"; \ rm -f .test.c .test; exit 1) diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c index 640f438..21763ec 100644 --- a/util/superiotool/smsc.c +++ b/util/superiotool/smsc.c @@ -20,8 +20,8 @@ #define DEVICE_ID_REG_OLD 0x0d #define DEVICE_REV_REG_OLD 0x0e -#define DEVICE_ID_REG 0x20 -#define DEVICE_REV_REG 0x21 +#define DEVICE_ID_REG 0x20 +#define DEVICE_REV_REG 0x21 static const struct superio_registers reg_table[] = { /* The following Super I/Os use the 0x20/0x21 ID registers. */ diff --git a/util/superiotool/superiotool.h b/util/superiotool/superiotool.h index 01237a5..ed7beae 100644 --- a/util/superiotool/superiotool.h +++ b/util/superiotool/superiotool.h @@ -133,7 +133,7 @@ #define MAXLDN 0x14 /* Biggest LDN */ #define LDNSIZE (MAXLDN + 3) /* Biggest LDN + 0 + NOLDN + EOT */ #define MAXNUMIDX 170 /* Maximum number of indices */ -#define IDXSIZE (MAXNUMIDX + 1) +#define IDXSIZE (MAXNUMIDX + 1) #define MAXNUMPORTS (6 + 1) /* Maximum number of Super I/O ports */ /* Select registers for various components. */ diff --git a/util/superiotool/winbond.c b/util/superiotool/winbond.c index 281c179..fce860d 100644 --- a/util/superiotool/winbond.c +++ b/util/superiotool/winbond.c @@ -229,8 +229,8 @@ {0x00,0x48,0x48,0x48,0x48,0x00,0x00,0x48,0x00,0x00, EOT}}, {EOT}}}, - {0xa23, "W83627UHG = NCT6627UD", { /* TODO: Not yet in sensors-detect */ - {NOLDN, NULL, /* CR2B (485) is only valid for chip rev.E */ + {0xa23, "W83627UHG = NCT6627UD", { /* TODO: Not yet in sensors-detect */ + {NOLDN, NULL, /* CR2B (485) is only valid for chip rev.E */ {0x02,0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28, 0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, {0x00,0xa2,NANA,0xff,0xF0,MISC,0x00,MISC,RSVD,0x00, -- To view, visit https://review.coreboot.org/26668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie79cfb92cfb8b8f628aa4b12bba946b0479fc466 Gerrit-Change-Number: 26668 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: util/autoport: Remove whitespace before tab
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26667 ) Change subject: util/autoport: Remove whitespace before tab ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73547/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27656/ : SUCCESS -- To view, visit https://review.coreboot.org/26667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I824ca52bd41c058b4455d4fdc429619d1bd491e6 Gerrit-Change-Number: 26667 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 20:22:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/autoport: Remove whitespace before tab
by Elyes HAOUAS (Code Review) 29 May '18

29 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26667 Change subject: util/autoport: Remove whitespace before tab ...................................................................... util/autoport: Remove whitespace before tab Change-Id: I824ca52bd41c058b4455d4fdc429619d1bd491e6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/autoport/readme.md 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/26667/1 diff --git a/util/autoport/readme.md b/util/autoport/readme.md index 21174b0..67a2c56 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -88,16 +88,16 @@ phcoder@sid:~/coreboot/util/autoport$ sudo modprobe i2c-dev phcoder@sid:~/coreboot/util/autoport$ sudo i2cdetect -l - i2c-0 i2c i915 gmbus ssc I2C adapter - i2c-1 i2c i915 gmbus vga I2C adapter - i2c-2 i2c i915 gmbus panel I2C adapter - i2c-3 i2c i915 gmbus dpc I2C adapter - i2c-4 i2c i915 gmbus dpb I2C adapter - i2c-5 i2c i915 gmbus dpd I2C adapter - i2c-6 i2c DPDDC-B I2C adapter - i2c-7 i2c DPDDC-C I2C adapter - i2c-8 i2c DPDDC-D I2C adapter - i2c-9 smbus SMBus I801 adapter at 0400 SMBus adapter + i2c-0 i2c i915 gmbus ssc I2C adapter + i2c-1 i2c i915 gmbus vga I2C adapter + i2c-2 i2c i915 gmbus panel I2C adapter + i2c-3 i2c i915 gmbus dpc I2C adapter + i2c-4 i2c i915 gmbus dpb I2C adapter + i2c-5 i2c i915 gmbus dpd I2C adapter + i2c-6 i2c DPDDC-B I2C adapter + i2c-7 i2c DPDDC-C I2C adapter + i2c-8 i2c DPDDC-D I2C adapter + i2c-9 smbus SMBus I801 adapter at 0400 SMBus adapter phcoder@sid:~/coreboot/util/autoport$ sudo i2cdetect 9 WARNING! This program can confuse your I2C bus, cause data loss and worse! I will probe file /dev/i2c-9. -- To view, visit https://review.coreboot.org/26667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I824ca52bd41c058b4455d4fdc429619d1bd491e6 Gerrit-Change-Number: 26667 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: soc/intel/skylake: Swap PCI devfn resides in same PCI device
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: soc/intel/skylake: Swap PCI devfn resides in same PCI device
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26479 ) Change subject: soc/intel/skylake: Swap PCI devfn resides in same PCI device ...................................................................... Patch Set 4: (9 comments) https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c File src/soc/intel/skylake/chip_fsp20.c: https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 73: static void pcie_update_device_tree(struct pcie_entry *pcie_rp_group, int pci_groups) line over 80 characters https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 93: * Increase funtion by 1. 'funtion' may be misspelled - perhaps 'function'? https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 97: for (i = 1; i < pcie_rp_group[group].func_count; i++, devfn += inc) { line over 80 characters https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 102: /* Found the first enabled device in a given dev number */ line over 80 characters https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 103: printk(BIOS_INFO, "PCI func %d was swapped to func 0.\n", i); line over 80 characters https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 127: else if (id_mask == (PCI_DEVICE_ID_INTEL_KBP_H_PCIE_RP1 & ~0xf)) { else should follow close brace '}' https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 132: else if (id_mask == (PCI_DEVICE_ID_INTEL_SPT_H_PCIE_RP1 & ~0xf)) { else should follow close brace '}' https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 137: else { else should follow close brace '}' https://review.coreboot.org/#/c/26479/4/src/soc/intel/skylake/chip_fsp20.c@… PS4, Line 138: printk(BIOS_ERR, "[BUG] PCIE Root Port id 0x%x is not found\n", id); line over 80 characters -- To view, visit https://review.coreboot.org/26479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc5d6e979977011f5904c8bd4b2f1be16bd23dc Gerrit-Change-Number: 26479 Gerrit-PatchSet: 4 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 20:10:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018