coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: mb/siemens: Get rid of whitespace before tab
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26636 ) Change subject: mb/siemens: Get rid of whitespace before tab ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73579/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27688/ : SUCCESS -- To view, visit https://review.coreboot.org/26636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic334f65e5c27d4f773f81fc1c9e3df7d63d47a11 Gerrit-Change-Number: 26636 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 07:41:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/asus: Get rid of whitespace before tab
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26610 ) Change subject: mb/asus: Get rid of whitespace before tab ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73578/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27687/ : SUCCESS -- To view, visit https://review.coreboot.org/26610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id572144827b515e9e84c51aa3e4f8a20baf1c212 Gerrit-Change-Number: 26610 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 07:37:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Use "foo *bar" instead of "foo* bar"
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26461 ) Change subject: src: Use "foo *bar" instead of "foo* bar" ...................................................................... Patch Set 3: (23 comments) https://review.coreboot.org/#/c/26461/3/src/drivers/amd/agesa/eventlog.c File src/drivers/amd/agesa/eventlog.c: https://review.coreboot.org/#/c/26461/3/src/drivers/amd/agesa/eventlog.c@89 PS3, Line 89: const char *statusStrings[] = { "AGESA_SUCCESS", "AGESA_UNSUPPORTED", char * array declaration might be better as static const https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h File src/northbridge/amd/amdht/h3finit.h: https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 229: * @param[in,out] u8 *LinkWidthIn = modify to change the Link Witdh In line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 230: * @param[in,out] u8 *LinkWidthOut = modify to change the Link Witdh Out line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 231: * @param[in,out] u32 *FreqCap = modify to change the link's frequency capability line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 232: * @param[in,out] u32 *FeatureCap = modify to change the link's feature capability line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 269: * @param[in,out] u8 *ABLinkWidthLimit = modify to change the Link Witdh In line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 270: * @param[in,out] u8 *BALinkWidthLimit = modify to change the Link Witdh Out line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 271: * @param[in,out] u32 *PCBFreqCap = modify to change the link's frequency capability line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 302: * @param[in,out] u8 *DownstreamLinkWidthLimit = modify to change the Link Witdh In line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 303: * @param[in,out] u8 *UpstreamLinkWidthLimit = modify to change the Link Witdh Out line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 304: * @param[in,out] u32 *PCBFreqCap = modify to change the link's frequency capability line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 403: * @param[in,out] u8 *LinkWidthIn = modify to change the Link Witdh In line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 404: * @param[in,out] u8 *LinkWidthOut = modify to change the Link Witdh Out line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 405: * @param[in,out] u16 *LinkFrequency = modify to change the link's frequency capability line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 434: * @param[in,out] u8 *LinkWidthIn = modify to change the Link Witdh In line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 435: * @param[in,out] u8 *LinkWidthOut = modify to change the Link Witdh Out line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 436: * @param[in,out] u16 *LinkFrequency = modify to change the link's frequency capability line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h… PS3, Line 462: * @param[in] u8 *pEventData0 = useful data associated with the event. line over 80 characters https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/pi/agesawrapper… File src/northbridge/amd/pi/agesawrapper_call.h: https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/pi/agesawrapper… PS3, Line 35: const char *statusStrings[] = { "AGESA_SUCCESS", "AGESA_UNSUPPORTED", char * array declaration might be better as static const https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/fsp_sandybrid… File src/northbridge/intel/fsp_sandybridge/raminit.c: https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/fsp_sandybrid… PS3, Line 24: static const char *ecc_decoder[] = { static const char * array should probably be static const char * const https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/haswell/ramin… File src/northbridge/intel/haswell/raminit.c: https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/haswell/ramin… PS3, Line 65: static const char *ecc_decoder[] = { static const char * array should probably be static const char * const https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/sandybridge/r… File src/northbridge/intel/sandybridge/raminit_mrc.c: https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/sandybridge/r… PS3, Line 133: static const char *ecc_decoder[] = { static const char * array should probably be static const char * const https://review.coreboot.org/#/c/26461/3/src/southbridge/amd/sb700/sm.c File src/southbridge/amd/sb700/sm.c: https://review.coreboot.org/#/c/26461/3/src/southbridge/amd/sb700/sm.c@51 PS3, Line 51: static const char *power_mode_names[] = { static const char * array should probably be static const char * const -- To view, visit https://review.coreboot.org/26461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bb6cc80ac2bdc389c60c7ffac4bba937f0fca8 Gerrit-Change-Number: 26461 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 07:36:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/northbridge: Remove whitespace before tab
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26603 ) Change subject: src/northbridge: Remove whitespace before tab ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73574/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27683/ : SUCCESS -- To view, visit https://review.coreboot.org/26603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf13c08129c71372e9870159bbe0a1b86af93935 Gerrit-Change-Number: 26603 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 07:33:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: i210: Add additional PCI-ID to the i210 driver
by Mario Scheithauer (Code Review) 30 May '18

30 May '18

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/26683 ) Change subject: i210: Add additional PCI-ID to the i210 driver ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/26683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I608535202c49e40690381c2b2ab26322d62cfb37 Gerrit-Change-Number: 26683 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 07:32:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/hp: Get rid of whitespace before tab
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26623 ) Change subject: mb/hp: Get rid of whitespace before tab ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73577/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27686/ : SUCCESS -- To view, visit https://review.coreboot.org/26623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f85e2ef0682b808f6e99dc406bccb88badcb82c Gerrit-Change-Number: 26623 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 07:32:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/kontron: Get rid of whitespace before tab
by Elyes HAOUAS (Code Review) 30 May '18

30 May '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26629 to look at the new patch set (#2). Change subject: mb/kontron: Get rid of whitespace before tab ...................................................................... mb/kontron: Get rid of whitespace before tab Change-Id: I335dda11d0c1ee58bd2728580c48c41cef574654 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/kontron/986lcd-m/acpi/thermal.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/26629/2 -- To view, visit https://review.coreboot.org/26629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I335dda11d0c1ee58bd2728580c48c41cef574654 Gerrit-Change-Number: 26629 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/siemens: Get rid of whitespace before tab
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26636 ) Change subject: mb/siemens: Get rid of whitespace before tab ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/26636/2/src/mainboard/siemens/mc_tcu3/gpio.c File src/mainboard/siemens/mc_tcu3/gpio.c: https://review.coreboot.org/#/c/26636/2/src/mainboard/siemens/mc_tcu3/gpio.… PS2, Line 163: GPIO_INPUT_PD_10K, /* GPIO_S5[01] RESERVED RESERVED RESERVED PMC_WAKE_PCIE[1]# */ line over 80 characters https://review.coreboot.org/#/c/26636/2/src/mainboard/siemens/mc_tcu3/gpio.… PS2, Line 170: GPIO_INPUT_PU_10K, /* GPIO_S5[08] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters -- To view, visit https://review.coreboot.org/26636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic334f65e5c27d4f773f81fc1c9e3df7d63d47a11 Gerrit-Change-Number: 26636 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 07:31:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/siemens: Get rid of whitespace before tab
by Elyes HAOUAS (Code Review) 30 May '18

30 May '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26636 to look at the new patch set (#2). Change subject: mb/siemens: Get rid of whitespace before tab ...................................................................... mb/siemens: Get rid of whitespace before tab Change-Id: Ic334f65e5c27d4f773f81fc1c9e3df7d63d47a11 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/siemens/mc_tcu3/devicetree.cb M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/irqroute.h 3 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/26636/2 -- To view, visit https://review.coreboot.org/26636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic334f65e5c27d4f773f81fc1c9e3df7d63d47a11 Gerrit-Change-Number: 26636 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/technexion: Get rid of whitespace before tab
by Elyes HAOUAS (Code Review) 30 May '18

30 May '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/26638 ) Change subject: mb/technexion: Get rid of whitespace before tab ...................................................................... Abandoned see #26671 -- To view, visit https://review.coreboot.org/26638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ib2bd31e359ac43bd2215af0af233f92d07685e2f Gerrit-Change-Number: 26638 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018