coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: nb/intel/x4x: Use common code for SMM in TSEG
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25597 ) Change subject: nb/intel/x4x: Use common code for SMM in TSEG ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73603/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27714/ : SUCCESS -- To view, visit https://review.coreboot.org/25597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317c5ca34bd38c3d42bf0d4e929b2a225a8a82dc Gerrit-Change-Number: 25597 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 11:21:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801gx: Use common Intel SMM code
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25594 ) Change subject: sb/intel/i82801gx: Use common Intel SMM code ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73599/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27710/ : SUCCESS -- To view, visit https://review.coreboot.org/25594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7016a3b98fc5f14c287ce800325084f9dc602a0 Gerrit-Change-Number: 25594 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 11:17:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Use common SMM_TSEG code
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25595 ) Change subject: nb/intel/i945: Use common SMM_TSEG code ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73602/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27713/ : SUCCESS -- To view, visit https://review.coreboot.org/25595 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e6374746c3df96ce16f1c4a177af12747d6c1a9 Gerrit-Change-Number: 25595 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 11:17:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/console: Fix coding style
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26303 ) Change subject: src/console: Fix coding style ...................................................................... Patch Set 2: (13 comments) https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c File src/console/vtxprintf.c: https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@99 PS2, Line 99: if (num == 0) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@101 PS2, Line 101: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@101 PS2, Line 101: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@101 PS2, Line 101: } else { space required after that close brace '}' https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@107 PS2, Line 107: if (i > precision) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@179 PS2, Line 179: } else if (*fmt == '*') { code indent should use tabs where possible https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@179 PS2, Line 179: } else if (*fmt == '*') { please, no spaces at the start of a line https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@179 PS2, Line 179: } else if (*fmt == '*') { space required after that close brace '}' https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@193 PS2, Line 193: if (is_digit(*fmt)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@195 PS2, Line 195: } else if (*fmt == '*') { code indent should use tabs where possible https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@195 PS2, Line 195: } else if (*fmt == '*') { please, no spaces at the start of a line https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@195 PS2, Line 195: } else if (*fmt == '*') { space required after that close brace '}' https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@200 PS2, Line 200: if (precision < 0) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/26303 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57724262ade87e7907d31ea66e4f1b9c382ef3db Gerrit-Change-Number: 26303 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 30 May 2018 11:13:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/gm45: Use common code for SMM in TSEG
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23419 ) Change subject: nb/intel/gm45: Use common code for SMM in TSEG ...................................................................... Patch Set 24: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73601/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27712/ : SUCCESS -- To view, visit https://review.coreboot.org/23419 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic80c65ea42fcf554ea5695772e8828d2f3b00b98 Gerrit-Change-Number: 23419 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 11:13:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801jx: Use common Intel SMM code
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25596 ) Change subject: sb/intel/i82801jx: Use common Intel SMM code ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73600/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27711/ : SUCCESS -- To view, visit https://review.coreboot.org/25596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3b3b3abbb3920d68d77fd7db996a1dc3c6b85a3 Gerrit-Change-Number: 25596 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 11:08:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: device/oprom/x86emu/prim_ops.c: Fix coding style
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26353 ) Change subject: device/oprom/x86emu/prim_ops.c: Fix coding style ...................................................................... Patch Set 8: (90 comments) https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c File src/device/oprom/x86emu/prim_ops.c: https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 195: if (set_carry) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 295: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 314: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 763: if ((cnt = s % 9) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 784: if (ACCESS_FLAG(F_CF)) { /* carry flag is set */ suspect code indent for conditional statements (16, 32) https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 810: if ((cnt = s % 17) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 815: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 834: if ((cnt = s % 33) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 881: if ((cnt = s % 9) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 886: /* note hackery here. Access_flag(..) evaluates to either line over 80 characters https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 945: if ((cnt = s % 17) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 954: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 977: if ((cnt = s % 33) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1024: if ((cnt = s % 8) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1057: if ((cnt = s % 16) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1082: if ((cnt = s % 32) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1122: if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */ do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1153: if ((cnt = s % 16) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1176: if ((cnt = s % 32) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1217: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1217: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1253: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1253: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1286: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^ line over 80 characters https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1288: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1288: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1321: if (cnt == 1) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1323: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1323: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1356: if (cnt == 1) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1358: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1358: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1358: } else { space required after that close brace '}' https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1358: } else { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1390: if (cnt == 1) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1392: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1392: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1422: if (sf) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1460: if (sf) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1498: if (sf) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1541: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1541: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1574: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^ line over 80 characters https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1576: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1576: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1609: if (cnt == 1) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1611: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1611: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1643: if (cnt == 1) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1645: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1645: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1645: } else { space required after that close brace '}' https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1645: } else { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1668: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1670: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1670: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1670: } else { space required after that close brace '}' https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1670: } else { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1692: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1694: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1694: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1694: } else { space required after that close brace '}' https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1694: } else { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1716: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1718: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1718: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1718: } else { space required after that close brace '}' https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1718: } else { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1934: if ((d_sign = d & 0x80000000) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1934: if ((d_sign = d & 0x80000000) != 0) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1939: if ((s_sign = s & 0x80000000) != 0) { do not use assignment in if condition https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 1939: if ((s_sign = s & 0x80000000) != 0) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2304: } else if (size == 2) { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2304: } else if (size == 2) { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2304: } else if (size == 2) { space required after that close brace '}' https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2307: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2307: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2307: } else { space required after that close brace '}' https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2317: if (ACCESS_FLAG(F_DF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2352: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2352: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2352: } else { space required after that close brace '}' https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2362: if (ACCESS_FLAG(F_DF)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2375: if (M.x86.mode & SYSMODE_32BIT_REP) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2471: /* Regardless if we have real data from the hardware, the emulator line over 80 characters https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2472: * will only support upto feature 1, which we set in register EAX. line over 80 characters https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2482: /* If we don't have x86 compatible hardware, we return values from an line over 80 characters https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2483: * Intel 486dx4; which was one of the first processors to have CPUID. line over 80 characters https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2489: /* In the case that we have hardware CPUID instruction, we make sure line over 80 characters https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@… PS8, Line 2496: * return all zeros when queried for invalid or unsupported feature line over 80 characters -- To view, visit https://review.coreboot.org/26353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I010f3e02813d38293a7ab7fc84f60b8c2ec098a7 Gerrit-Change-Number: 26353 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 30 May 2018 11:08:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: device/oprom/x86emu/prim_ops.c: Fix coding style
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

1 0

Change in coreboot[master]: nb/intel/i945: Enable and allocate 8M for TSEG
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25592 ) Change subject: nb/intel/i945: Enable and allocate 8M for TSEG ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73598/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27709/ : SUCCESS -- To view, visit https://review.coreboot.org/25592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da5a00c98c4c4fb309b2691dc1d4645eb35b4fd Gerrit-Change-Number: 25592 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 30 May 2018 11:04:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/pineview: Enable and allocate 8M for TSEG
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25593 ) Change subject: nb/intel/pineview: Enable and allocate 8M for TSEG ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73596/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27707/ : SUCCESS -- To view, visit https://review.coreboot.org/25593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa3acce57f0c13eee326b7c203a43453c74c3161 Gerrit-Change-Number: 25593 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 30 May 2018 11:02:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018