Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/26684 )
Change subject: mb/google/poppy/variants/nocturne: configure the FPMCU interface
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/26684/1/src/mainboard/google/poppy/variants…
File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/26684/1/src/mainboard/google/poppy/variants…
PS1, Line 136: 1
I had missed this on the other CL. This should be 0 since ACPI power resource will take care of de-asserting reset.
--
To view, visit https://review.coreboot.org/26684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib417dcf84cda8e354060785cd16a7b6b812148d5
Gerrit-Change-Number: 26684
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Comment-Date: Wed, 30 May 2018 11:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25598 )
Change subject: nb/intel/pineview: Use common code for SMM in TSEG
......................................................................
Patch Set 9:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/73604/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/27715/ : SUCCESS
--
To view, visit https://review.coreboot.org/25598
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f947cfae730b67bc76a581bc90cb10e5a2a4a52
Gerrit-Change-Number: 25598
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 11:26:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No