coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25751 ) Change subject: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF ...................................................................... Patch Set 14: (2 comments) https://review.coreboot.org/#/c/25751/14/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c: https://review.coreboot.org/#/c/25751/14/src/soc/cavium/cn81xx/soc.c@59 PS14, Line 59: void *ptr = cbfs_boot_map_with_leak("sff8104-linux.dtb", CBFS_TYPE_RAW, &size); line over 80 characters https://review.coreboot.org/#/c/25751/14/src/soc/cavium/common/include/soc/… File src/soc/cavium/common/include/soc/bl31_plat_params.h: https://review.coreboot.org/#/c/25751/14/src/soc/cavium/common/include/soc/… PS14, Line 21: #include <soc/cavium/common/arm-trusted-firmware/plat/cavium/common/include/plat_params.h> line over 80 characters -- To view, visit https://review.coreboot.org/25751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e9eb429d11150d43aa070d1bd6a11ea71951ce3 Gerrit-Change-Number: 25751 Gerrit-PatchSet: 14 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:11:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Add PCI support
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25750 ) Change subject: soc/cavium: Add PCI support ...................................................................... Patch Set 14: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73641/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27757/ : SUCCESS -- To view, visit https://review.coreboot.org/25750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I881f38a26a165e6bd965fcd73547473b5e32d4b0 Gerrit-Change-Number: 25750 Gerrit-PatchSet: 14 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 30 May 2018 13:11:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: device/pci: Add MSI-X helper functions
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26329 ) Change subject: device/pci: Add MSI-X helper functions ...................................................................... Patch Set 5: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73640/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27756/ : SUCCESS -- To view, visit https://review.coreboot.org/26329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94413712e7986efd17e6b11ba59f6eb390384c8c Gerrit-Change-Number: 26329 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:11:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium/cn81xx: Set cntfrq_el0
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25450 ) Change subject: soc/cavium/cn81xx: Set cntfrq_el0 ...................................................................... Patch Set 24: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73639/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27755/ : SUCCESS -- To view, visit https://review.coreboot.org/25450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b6d0b0cf646a066fc5a51552a1891eccbd91e5e Gerrit-Change-Number: 25450 Gerrit-PatchSet: 24 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:11:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Be verbose
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25449 ) Change subject: mb/cavium/cn8100_sff_evb: Be verbose ...................................................................... Patch Set 24: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73638/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27754/ : SUCCESS -- To view, visit https://review.coreboot.org/25449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0acac7a29290bc2eb9f4283317165fa0cf1b24e1 Gerrit-Change-Number: 25449 Gerrit-PatchSet: 24 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:11:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Be verbose
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25449 ) Change subject: mb/cavium/cn8100_sff_evb: Be verbose ...................................................................... Patch Set 24: (1 comment) https://review.coreboot.org/#/c/25449/24/src/mainboard/cavium/cn8100_sff_ev… File src/mainboard/cavium/cn8100_sff_evb/mainboard.c: https://review.coreboot.org/#/c/25449/24/src/mainboard/cavium/cn8100_sff_ev… PS24, Line 41: switch (boot_method) { switch and case should be at the same indent -- To view, visit https://review.coreboot.org/25449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0acac7a29290bc2eb9f4283317165fa0cf1b24e1 Gerrit-Change-Number: 25449 Gerrit-PatchSet: 24 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:10:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Clean uart code
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25448 ) Change subject: soc/cavium: Clean uart code ...................................................................... Patch Set 24: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73637/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27753/ : SUCCESS -- To view, visit https://review.coreboot.org/25448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1043b30318ec6210e2dd6b7ac313a41171d37f55 Gerrit-Change-Number: 25448 Gerrit-PatchSet: 24 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:10:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Enable MMU
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25371 ) Change subject: soc/cavium: Enable MMU ...................................................................... Patch Set 26: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73636/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27752/ : SUCCESS -- To view, visit https://review.coreboot.org/25371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I969446da62b4cc7adf9393fab69ff84ebf49220d Gerrit-Change-Number: 25371 Gerrit-PatchSet: 26 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:10:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: devicetree: Add method to delete property by name
by Patrick Rudolph (Code Review) 30 May '18

30 May '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/26693 Change subject: devicetree: Add method to delete property by name ...................................................................... devicetree: Add method to delete property by name Change-Id: I7c58a2411206bca62d0e96fa627530e937383ac9 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/include/device_tree.h M src/lib/device_tree.c 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/26693/1 diff --git a/src/include/device_tree.h b/src/include/device_tree.h index 107fcf6..8433ddf 100644 --- a/src/include/device_tree.h +++ b/src/include/device_tree.h @@ -149,6 +149,8 @@ void *data, size_t size); // Write src into *dest as a 'length'-byte big-endian integer. void dt_write_int(u8 *dest, u64 src, size_t length); +// Delete a property +void dt_delete_prop(struct device_tree_node *node, const char *name); // Add different kinds of properties to a node, or update existing ones. void dt_add_bin_prop(struct device_tree_node *node, const char *name, void *data, size_t size); diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index 0a88c1f..5edd729 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -748,6 +748,26 @@ * @param data The raw data blob to be stored in the property. * @param size The size of data in bytes. */ +void dt_delete_prop(struct device_tree_node *node, const char *name) +{ + struct device_tree_property *prop; + + list_for_each(prop, node->properties, list_node) { + if (!strcmp(prop->prop.name, name)) { + list_remove(&prop->list_node); + return; + } + } +} + +/* + * Add an arbitrary property to a node, or update it if it already exists. + * + * @param node The device tree node to add to. + * @param name The name of the new property. + * @param data The raw data blob to be stored in the property. + * @param size The size of data in bytes. + */ void dt_add_bin_prop(struct device_tree_node *node, const char *name, void *data, size_t size) { -- To view, visit https://review.coreboot.org/26693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7c58a2411206bca62d0e96fa627530e937383ac9 Gerrit-Change-Number: 26693 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: device/oprom/x86emu/prim_ops.c: Fix coding style
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26353 ) Change subject: device/oprom/x86emu/prim_ops.c: Fix coding style ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73633/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27749/ : SUCCESS -- To view, visit https://review.coreboot.org/26353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I010f3e02813d38293a7ab7fc84f60b8c2ec098a7 Gerrit-Change-Number: 26353 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 30 May 2018 13:03:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018