build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26298 )
Change subject: cpu/intel/model_2065x: Put stage cache in TSEG
......................................................................
Patch Set 4:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/73616/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/27727/ : SUCCESS
--
To view, visit https://review.coreboot.org/26298
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cbfb6ece62f554ac676fe686115e841d2c1e40
Gerrit-Change-Number: 26298
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 11:59:32 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Vincent Palatin has posted comments on this change. ( https://review.coreboot.org/26684 )
Change subject: mb/google/poppy/variants/nocturne: configure the FPMCU interface
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/26684/1/src/mainboard/google/poppy/variants…
File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/26684/1/src/mainboard/google/poppy/variants…
PS1, Line 136: 0
> I had missed this on the other CL. […]
Done
--
To view, visit https://review.coreboot.org/26684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib417dcf84cda8e354060785cd16a7b6b812148d5
Gerrit-Change-Number: 26684
Gerrit-PatchSet: 2
Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org>
Gerrit-Reviewer: Vincent Palatin <vpalatin(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Comment-Date: Wed, 30 May 2018 11:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/26684
to look at the new patch set (#2).
Change subject: mb/google/poppy/variants/nocturne: configure the FPMCU interface
......................................................................
mb/google/poppy/variants/nocturne: configure the FPMCU interface
The FPMCU is using the standard cros-ec-spi interface on GSPI1.
Configure the GPIOs controlling the MCU too.
We need to be able to wake from S3 on the MCU interrupt, re-configure
GPE0 DW0 to point to GPP_C bank.
BRANCH=poppy
BUG=b:79666174
TEST=exercise the cros_ec interface, e.g. 'ectool --name=cros_fp version',
verify the MKBP events by doing 'ectool --name=cros_fp fpmode fingerup'
then 'ectool --name=cros_fp waitevent 5 10000', toggle the other GPIOs
with the flash_fp_mcu script.
Change-Id: Ib417dcf84cda8e354060785cd16a7b6b812148d5
Signed-off-by: Vincent Palatin <vpalatin(a)chromium.org>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
M src/mainboard/google/poppy/variants/nocturne/gpio.c
2 files changed, 25 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/26684/2
--
To view, visit https://review.coreboot.org/26684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib417dcf84cda8e354060785cd16a7b6b812148d5
Gerrit-Change-Number: 26684
Gerrit-PatchSet: 2
Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26296 )
Change subject: sb/intel/ibexpeak: Use common Intel SMM code
......................................................................
Patch Set 4:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/73614/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/27725/ : SUCCESS
--
To view, visit https://review.coreboot.org/26296
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc2d8f7755ace598e66b162d071d472093e4656e
Gerrit-Change-Number: 26296
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 11:57:13 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25606 )
Change subject: nb/intel/x4x: Put stage cache in TSEG
......................................................................
Patch Set 10:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/73615/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/27726/ : SUCCESS
--
To view, visit https://review.coreboot.org/25606
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie46c1416f8042d5571339b36e1253c0cae0684b8
Gerrit-Change-Number: 25606
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 11:55:17 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25605 )
Change subject: nb/intel/pineview: Put stage cache in TSEG
......................................................................
Patch Set 10:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/73613/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/27724/ : SUCCESS
--
To view, visit https://review.coreboot.org/25605
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d163e8ff328ba01425b524a673f34a96fb93ea7
Gerrit-Change-Number: 25605
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 11:51:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25604 )
Change subject: nb/intel/gm45: Put stage cache in TSEG
......................................................................
Patch Set 11:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/73612/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/27723/ : SUCCESS
--
To view, visit https://review.coreboot.org/25604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I642f7d6ae5523a35904c8e1f029027565a364d26
Gerrit-Change-Number: 25604
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 11:46:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No