coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: mainboard/amd/south_station: Fix coding style
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: mainboard/amd/union_station: Fix coding style
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: mainboard/amd/union_station: Fix coding style
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26467 ) Change subject: mainboard/amd/union_station: Fix coding style ...................................................................... Patch Set 2: (11 comments) https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bio… File src/mainboard/amd/union_station/BiosCallOuts.c: https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bio… PS2, Line 24: VOID *ConfigPtr); need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bio… PS2, Line 157: Write64Mem8(GpioMmioAddr + SB_GPIO_REG21, Data8); // MXM_GPIO0. GPIO21 line over 80 characters https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bio… PS2, Line 163: Write64Mem8(GpioMmioAddr + SB_GPIO_REG21, Data8); // MXM_GPIO0. GPIO21 line over 80 characters https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bio… PS2, Line 173: Write64Mem8(GpioMmioAddr + SB_GPIO_REG25, Data8); // PCIE_RST#_LAN, GPIO25 line over 80 characters https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bio… PS2, Line 179: Write64Mem8(GpioMmioAddr + SB_GPIO_REG25, Data8); // PCIE_RST#_LAN, GPIO25 line over 80 characters https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bio… PS2, Line 189: Write64Mem8(GpioMmioAddr + SB_GPIO_REG02, Data8); // MPCIE_RST0, GPIO02 line over 80 characters https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bio… PS2, Line 195: Write64Mem8(GpioMmioAddr + SB_GPIO_REG02, Data8); // MPCIE_RST0, GPIO02 line over 80 characters https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Oem… File src/mainboard/amd/union_station/OemCustomize.c: https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Oem… PS2, Line 62: } Statements should start on a tabstop https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Oem… PS2, Line 77: } Statements should start on a tabstop https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/mpt… File src/mainboard/amd/union_station/mptable.c: https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/mpt… PS2, Line 26: [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, /* INTA# - INTH# */ line over 80 characters https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/mpt… PS2, Line 27: [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F, /* Misc-nil,0,1,2, INT from Serial irq */ line over 80 characters -- To view, visit https://review.coreboot.org/26467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3818877bf56c3b69d496e6cba6135a72306bb92a Gerrit-Change-Number: 26467 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 19:48:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/asrock/e350m1: Fix coding style
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: mainboard/amd/south_station: Fix coding style
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26466 ) Change subject: mainboard/amd/south_station: Fix coding style ...................................................................... Patch Set 2: (12 comments) https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Bio… File src/mainboard/amd/south_station/BiosCallOuts.c: https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Bio… PS2, Line 24: VOID *ConfigPtr); need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Bio… PS2, Line 157: Write64Mem8(GpioMmioAddr + SB_GPIO_REG21, Data8); // MXM_GPIO0. GPIO21 line over 80 characters https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Bio… PS2, Line 163: Write64Mem8(GpioMmioAddr + SB_GPIO_REG21, Data8); // MXM_GPIO0. GPIO21 line over 80 characters https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Bio… PS2, Line 173: Write64Mem8(GpioMmioAddr + SB_GPIO_REG25, Data8); // PCIE_RST#_LAN, GPIO25 line over 80 characters https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Bio… PS2, Line 179: Write64Mem8(GpioMmioAddr + SB_GPIO_REG25, Data8); // PCIE_RST#_LAN, GPIO25 line over 80 characters https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Bio… PS2, Line 189: Write64Mem8(GpioMmioAddr + SB_GPIO_REG02, Data8); // MPCIE_RST0, GPIO02 line over 80 characters https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Bio… PS2, Line 195: Write64Mem8(GpioMmioAddr + SB_GPIO_REG02, Data8); // MPCIE_RST0, GPIO02 line over 80 characters https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Oem… File src/mainboard/amd/south_station/OemCustomize.c: https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Oem… PS2, Line 60: } Statements should start on a tabstop https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/Oem… PS2, Line 75: } Statements should start on a tabstop https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/mpt… File src/mainboard/amd/south_station/mptable.c: https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/mpt… PS2, Line 26: [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, /* INTA# - INTH# */ line over 80 characters https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/mpt… PS2, Line 27: [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F, /* Misc-nil,0,1,2, INT from Serial irq */ line over 80 characters https://review.coreboot.org/#/c/26466/2/src/mainboard/amd/south_station/mpt… PS2, Line 81: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 80 characters -- To view, visit https://review.coreboot.org/26466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae457237ef104736478eface4d91dd282fd866ea Gerrit-Change-Number: 26466 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 19:45:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/asrock/e350m1: Fix coding style
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26470 ) Change subject: mainboard/asrock/e350m1: Fix coding style ...................................................................... Patch Set 2: (6 comments) https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/BiosCal… File src/mainboard/asrock/e350m1/BiosCallOuts.c: https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/BiosCal… PS2, Line 23: VOID *ConfigPtr); need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/BiosCal… PS2, Line 91: /* this seems to be just copy-pasted from the AMD reference boards and needs line over 80 characters https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/OemCust… File src/mainboard/asrock/e350m1/OemCustomize.c: https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/OemCust… PS2, Line 37: } Statements should start on a tabstop https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/OemCust… PS2, Line 52: } Statements should start on a tabstop https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/mptable… File src/mainboard/asrock/e350m1/mptable.c: https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/mptable… PS2, Line 27: [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, /* INTA# - INTH# */ line over 80 characters https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/mptable… PS2, Line 28: [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F, /* Misc-nil,0,1,2, INT from Serial irq */ line over 80 characters -- To view, visit https://review.coreboot.org/26470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a6d5635dc10e486fa137cfec08842f634f34e66 Gerrit-Change-Number: 26470 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 19:42:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/asrock/e350m1: Fix coding style
by Elyes HAOUAS (Code Review) 29 May '18

29 May '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26470 to look at the new patch set (#2). Change subject: mainboard/asrock/e350m1: Fix coding style ...................................................................... mainboard/asrock/e350m1: Fix coding style Change-Id: I9a6d5635dc10e486fa137cfec08842f634f34e66 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/asrock/e350m1/BiosCallOuts.c M src/mainboard/asrock/e350m1/OemCustomize.c M src/mainboard/asrock/e350m1/acpi_tables.c M src/mainboard/asrock/e350m1/buildOpts.c M src/mainboard/asrock/e350m1/irq_tables.c M src/mainboard/asrock/e350m1/mainboard.c M src/mainboard/asrock/e350m1/mptable.c M src/mainboard/asrock/e350m1/platform_cfg.h M src/mainboard/asrock/e350m1/romstage.c 9 files changed, 204 insertions(+), 212 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/26470/2 -- To view, visit https://review.coreboot.org/26470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a6d5635dc10e486fa137cfec08842f634f34e66 Gerrit-Change-Number: 26470 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/supermicro: Get rid of whitespace before tab
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26637 ) Change subject: mb/supermicro: Get rid of whitespace before tab ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73542/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27651/ : SUCCESS -- To view, visit https://review.coreboot.org/26637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2622e473959dcf105bfeeaebddd582593a3c274 Gerrit-Change-Number: 26637 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 19:36:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/supermicro: Get rid of whitespace before tab
by Elyes HAOUAS (Code Review) 29 May '18

29 May '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26637 to look at the new patch set (#2). Change subject: mb/supermicro: Get rid of whitespace before tab ...................................................................... mb/supermicro: Get rid of whitespace before tab Change-Id: Id2622e473959dcf105bfeeaebddd582593a3c274 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/supermicro/h8qme_fam10/romstage.c M src/mainboard/supermicro/h8scm_fam10/devicetree.cb M src/mainboard/supermicro/h8scm_fam10/dsdt.asl 3 files changed, 48 insertions(+), 48 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/26637/2 -- To view, visit https://review.coreboot.org/26637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id2622e473959dcf105bfeeaebddd582593a3c274 Gerrit-Change-Number: 26637 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/hp/dl145_g1: Remove empty WAK ACPI method
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26128 ) Change subject: mainboard/hp/dl145_g1: Remove empty WAK ACPI method ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73541/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27650/ : SUCCESS -- To view, visit https://review.coreboot.org/26128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16cdf2781ce1bf9458300de70a87a3bb98d01636 Gerrit-Change-Number: 26128 Gerrit-PatchSet: 8 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 May 2018 19:17:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018