coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 ) Change subject: cbfstool: add an option for creating a topswap bootblock ...................................................................... Patch Set 5: (14 comments) https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c: https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@344 PS5, Line 344: static int add_second_bootblock(struct buffer *buffer,uint32_t *offset) space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@347 PS5, Line 347: char* new_data = (char*)malloc(bb_size); "(foo*)" should be "(foo *)" https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@347 PS5, Line 347: char* new_data = (char*)malloc(bb_size); "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@349 PS5, Line 349: if (new_data == NULL){ space required before the open brace '{' https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@353 PS5, Line 353: char* bb1_offset = new_data + "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@355 PS5, Line 355: char* bb2_offset = new_data + (bb_size - buffer->size); "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@356 PS5, Line 356: DEBUG ("bb1 offset = 0x%p, bb2 offset = 0x%p\n", space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@410 PS5, Line 410: * topswap_size*2 bytes for bootblock to accomodate the second 'accomodate' may be misspelled - perhaps 'accommodate'? https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@414 PS5, Line 414: if(add_second_bootblock(&buffer, &offset)){ space required before the open brace '{' https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@414 PS5, Line 414: if(add_second_bootblock(&buffer, &offset)){ space required before the open parenthesis '(' https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@1341 PS5, Line 1341: " [-j topswap-size (in hex)] " code indent should use tabs where possible https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@1341 PS5, Line 1341: " [-j topswap-size (in hex)] " please, no spaces at the start of a line https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@1643 PS5, Line 1643: switch (param.topswap_size){ switch and case should be at the same indent https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@1643 PS5, Line 1643: switch (param.topswap_size){ space required before the open brace '{' -- To view, visit https://review.coreboot.org/22537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8 Gerrit-Change-Number: 22537 Gerrit-PatchSet: 5 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 29 May 2018 11:05:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 29 May '18

29 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 ) Change subject: cbfstool: add an option for creating a topswap bootblock ...................................................................... Patch Set 4: (14 comments) https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c: https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@344 PS4, Line 344: static int add_second_bootblock(struct buffer *buffer,uint32_t *offset) space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@347 PS4, Line 347: char* new_data = (char*)malloc(bb_size); "(foo*)" should be "(foo *)" https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@347 PS4, Line 347: char* new_data = (char*)malloc(bb_size); "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@349 PS4, Line 349: if (new_data == NULL){ space required before the open brace '{' https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@353 PS4, Line 353: char* bb1_offset = new_data + "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@355 PS4, Line 355: char* bb2_offset = new_data + (bb_size - buffer->size); "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@356 PS4, Line 356: DEBUG ("bb1 offset = 0x%p, bb2 offset = 0x%p\n", space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@410 PS4, Line 410: * topswap_size*2 bytes for bootblock to accomodate the second 'accomodate' may be misspelled - perhaps 'accommodate'? https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@414 PS4, Line 414: if(add_second_bootblock(&buffer, &offset)){ space required before the open brace '{' https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@414 PS4, Line 414: if(add_second_bootblock(&buffer, &offset)){ space required before the open parenthesis '(' https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@1340 PS4, Line 1340: " [-j topswap-size (in hex)] " code indent should use tabs where possible https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@1340 PS4, Line 1340: " [-j topswap-size (in hex)] " please, no spaces at the start of a line https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@1642 PS4, Line 1642: switch (param.topswap_size){ switch and case should be at the same indent https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@1642 PS4, Line 1642: switch (param.topswap_size){ space required before the open brace '{' -- To view, visit https://review.coreboot.org/22537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8 Gerrit-Change-Number: 22537 Gerrit-PatchSet: 4 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 29 May 2018 11:02:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in libgfxinit[master]: gma hsw transcoder: Choose PDW path for scaling on DDI A
by Nico Huber (Code Review) 29 May '18

29 May '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26664 Change subject: gma hsw transcoder: Choose PDW path for scaling on DDI A ...................................................................... gma hsw transcoder: Choose PDW path for scaling on DDI A If scaling is required, always drive DDI A through the Power Down Well (PDW) path. If not, keep the current "always on" path to allow power saving. Hopefully, this also enables us to use the eDP in legacy VGA text mode. Change-Id: Ia9135d253083d363872c7cf0b3e2b5b69ba0831f Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-pipe_setup.adb M common/hw-gfx-gma-transcoder.adb M common/hw-gfx-gma-transcoder.ads 3 files changed, 28 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/64/26664/1 diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb index 1ba4ee0..09fd286 100644 --- a/common/hw-gfx-gma-pipe_setup.adb +++ b/common/hw-gfx-gma-pipe_setup.adb @@ -511,7 +511,12 @@ Setup_FB (Pipe, Port_Cfg.Mode, Framebuffer); - Transcoder.On (Pipe, Port_Cfg, Framebuffer.BPC /= Port_Cfg.Mode.BPC); + Transcoder.On + (Pipe => Pipe, + Port_Cfg => Port_Cfg, + Dither => Framebuffer.BPC /= Port_Cfg.Mode.BPC, + Scale => Rotated_Width (Framebuffer) /= Port_Cfg.Mode.H_Visible or + Rotated_Height (Framebuffer) /= Port_Cfg.Mode.V_Visible); end On; ---------------------------------------------------------------------------- diff --git a/common/hw-gfx-gma-transcoder.adb b/common/hw-gfx-gma-transcoder.adb index 97ad069..daa5deb 100644 --- a/common/hw-gfx-gma-transcoder.adb +++ b/common/hw-gfx-gma-transcoder.adb @@ -1,5 +1,5 @@ -- --- Copyright (C) 2015-2016 secunet Security Networks AG +-- Copyright (C) 2015-2018 secunet Security Networks AG -- -- This program is free software; you can redistribute it and/or modify -- it under the terms of the GNU General Public License as published by @@ -76,11 +76,6 @@ DDI_FUNC_CTL_MODE_SELECT_DP_SST : constant := 2 * 2 ** 24; DDI_FUNC_CTL_MODE_SELECT_DP_MST : constant := 3 * 2 ** 24; DDI_FUNC_CTL_MODE_SELECT_FDI : constant := 4 * 2 ** 24; - DDI_FUNC_CTL_EDP_SELECT_MASK : constant := 7 * 2 ** 12; - DDI_FUNC_CTL_EDP_SELECT_ALWAYS_ON : constant := 0 * 2 ** 12; - DDI_FUNC_CTL_EDP_SELECT_A : constant := 4 * 2 ** 12; - DDI_FUNC_CTL_EDP_SELECT_B : constant := 5 * 2 ** 12; - DDI_FUNC_CTL_EDP_SELECT_C : constant := 6 * 2 ** 12; type DDI_Select_Array is array (Digital_Port) of Word32; DDI_FUNC_CTL_DDI_SELECT : constant DDI_Select_Array := @@ -105,16 +100,12 @@ (False => 0 * 2 ** 16, True => 1 * 2 ** 16); - type EDP_Select_Array is array (Pipe_Index) of Word32; - DDI_FUNC_CTL_EDP_SELECT : constant EDP_Select_Array := - (Primary => DDI_FUNC_CTL_EDP_SELECT_ALWAYS_ON, -- we never use - -- panel fitter - Secondary => DDI_FUNC_CTL_EDP_SELECT_B, - Tertiary => DDI_FUNC_CTL_EDP_SELECT_C); - DDI_FUNC_CTL_EDP_SELECT_ONOFF : constant EDP_Select_Array := - (Primary => DDI_FUNC_CTL_EDP_SELECT_A, - Secondary => DDI_FUNC_CTL_EDP_SELECT_B, - Tertiary => DDI_FUNC_CTL_EDP_SELECT_C); + DDI_FUNC_CTL_EDP_SELECT_MASK : constant := 7 * 2 ** 12; + DDI_FUNC_CTL_EDP_SELECT_ALWAYS_ON : constant := 0 * 2 ** 12; + DDI_FUNC_CTL_EDP_SELECT : constant array (Pipe_Index) of Word32 := + (Primary => 4 * 2 ** 12, + Secondary => 5 * 2 ** 12, + Tertiary => 6 * 2 ** 12); type Port_Width_Array is array (DP_Lane_Count) of Word32; DDI_FUNC_CTL_PORT_WIDTH : constant Port_Width_Array := @@ -245,10 +236,16 @@ procedure On (Pipe : Pipe_Index; Port_Cfg : Port_Config; - Dither : Boolean) + Dither : Boolean; + Scale : Boolean) is Trans : Transcoder_Regs renames Transcoders (Get_Idx (Pipe, Port_Cfg.Port)); + EDP_Select : constant Word32 := + (if Pipe = Primary and not Scale then + DDI_FUNC_CTL_EDP_SELECT_ALWAYS_ON + else + DDI_FUNC_CTL_EDP_SELECT (Pipe)); begin if Config.Has_Pipe_DDI_Func and Port_Cfg.Port in Digital_Port then Registers.Write @@ -259,7 +256,7 @@ DDI_FUNC_CTL_BPC (Port_Cfg.Mode.BPC) or DDI_FUNC_CTL_VSYNC (Port_Cfg.Mode.V_Sync_Active_High) or DDI_FUNC_CTL_HSYNC (Port_Cfg.Mode.H_Sync_Active_High) or - DDI_FUNC_CTL_EDP_SELECT (Pipe) or + EDP_Select or DDI_FUNC_CTL_PORT_WIDTH (Port_Cfg.DP.Lane_Count)); end if; @@ -308,7 +305,7 @@ if (Pipe = Primary and DDI_Func_Ctl = DDI_FUNC_CTL_EDP_SELECT_ALWAYS_ON) or - DDI_Func_Ctl = DDI_FUNC_CTL_EDP_SELECT_ONOFF (Pipe) + DDI_Func_Ctl = DDI_FUNC_CTL_EDP_SELECT (Pipe) then Trans_Off (Transcoders (Trans_EDP)); end if; diff --git a/common/hw-gfx-gma-transcoder.ads b/common/hw-gfx-gma-transcoder.ads index 79be8f7..b026933 100644 --- a/common/hw-gfx-gma-transcoder.ads +++ b/common/hw-gfx-gma-transcoder.ads @@ -1,5 +1,5 @@ -- --- Copyright (C) 2015-2016 secunet Security Networks AG +-- Copyright (C) 2015-2018 secunet Security Networks AG -- -- This program is free software; you can redistribute it and/or modify -- it under the terms of the GNU General Public License as published by @@ -19,7 +19,11 @@ is procedure Setup (Pipe : Pipe_Index; Port_Cfg : Port_Config); - procedure On (Pipe : Pipe_Index; Port_Cfg : Port_Config; Dither : Boolean); + procedure On + (Pipe : Pipe_Index; + Port_Cfg : Port_Config; + Dither : Boolean; + Scale : Boolean); procedure Off (Pipe : Pipe_Index); procedure Clk_Off (Pipe : Pipe_Index); -- To view, visit https://review.coreboot.org/26664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9135d253083d363872c7cf0b3e2b5b69ba0831f Gerrit-Change-Number: 26664 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma hsw: Enable Power Down Well for scaling on DDI A
by Nico Huber (Code Review) 29 May '18

29 May '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26663 Change subject: gma hsw: Enable Power Down Well for scaling on DDI A ...................................................................... gma hsw: Enable Power Down Well for scaling on DDI A The primary pipe can drive DDI A (eDP) without the Power Down Well (PDW). The scalers are inside the PDW, though. To enable scaling for DDI A, ensure the PDW is active. When switching between scaled / unscaled modes, we'll have to reconfigure the whole pipe. Change-Id: I46318bb74d00a584d268a9d76787f8b26249264d Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/haswell_shared/hw-gfx-gma-power_and_clocks_haswell.adb M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads 4 files changed, 35 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/63/26663/1 diff --git a/common/haswell_shared/hw-gfx-gma-power_and_clocks_haswell.adb b/common/haswell_shared/hw-gfx-gma-power_and_clocks_haswell.adb index c0d1e78..1c23254 100644 --- a/common/haswell_shared/hw-gfx-gma-power_and_clocks_haswell.adb +++ b/common/haswell_shared/hw-gfx-gma-power_and_clocks_haswell.adb @@ -1,5 +1,5 @@ -- --- Copyright (C) 2014-2016 secunet Security Networks AG +-- Copyright (C) 2014-2018 secunet Security Networks AG -- -- This program is free software; you can redistribute it and/or modify -- it under the terms of the GNU General Public License as published by @@ -185,12 +185,19 @@ end if; end PDW_On; - function Need_PDW (Checked_Configs : Pipe_Configs) return Boolean is + function Need_PDW (Checked_Configs : Pipe_Configs) return Boolean + is + Primary : Pipe_Config renames Checked_Configs (GMA.Primary); begin - return (Checked_Configs (Primary).Port /= Disabled and - Checked_Configs (Primary).Port /= Internal) or - Checked_Configs (Secondary).Port /= Disabled or - Checked_Configs (Tertiary).Port /= Disabled; + return + (Config.Use_PDW_For_EDP_Scaling and then + (Primary.Port = Internal and Requires_Scaling (Primary))) + or + (Primary.Port /= Disabled and Primary.Port /= Internal) + or + Checked_Configs (Secondary).Port /= Disabled + or + Checked_Configs (Tertiary).Port /= Disabled; end Need_PDW; ---------------------------------------------------------------------------- diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 049f473..688113b 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -1,5 +1,5 @@ -- --- Copyright (C) 2015-2017 secunet Security Networks AG +-- Copyright (C) 2015-2018 secunet Security Networks AG -- -- This program is free software; you can redistribute it and/or modify -- it under the terms of the GNU General Public License as published by @@ -47,6 +47,7 @@ (CPU in Haswell .. Broadwell); Pipe_Enabled_Workaround : constant Boolean := CPU = Broadwell; Has_EDP_Transcoder : constant Boolean := CPU >= Haswell; + Use_PDW_For_EDP_Scaling : constant Boolean := CPU = Haswell; Has_Pipe_DDI_Func : constant Boolean := CPU >= Haswell; Has_Trans_Clk_Sel : constant Boolean := CPU >= Haswell; Has_Pipe_MSA_Misc : constant Boolean := CPU >= Haswell; diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 809881a..2a8e843 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -1,5 +1,5 @@ -- --- Copyright (C) 2014-2017 secunet Security Networks AG +-- Copyright (C) 2014-2018 secunet Security Networks AG -- Copyright (C) 2017 Nico Huber <nico.h(a)gmx.de> -- -- This program is free software; you can redistribute it and/or modify @@ -231,6 +231,17 @@ Power_Changed := True; end if; end Update_Power; + + function Full_Update (Cur_Config, New_Config : Pipe_Config) return Boolean + is + begin + return + Cur_Config.Port /= New_Config.Port or else + Cur_Config.Mode /= New_Config.Mode or else + (Config.Use_PDW_For_EDP_Scaling and then + (Cur_Config.Port = Internal and + Requires_Scaling (Cur_Config) /= Requires_Scaling (New_Config))); + end Full_Update; begin Old_Configs := Cur_Configs; @@ -244,10 +255,7 @@ if Cur_Config.Port /= Disabled then Check_HPD (Cur_Config.Port, Unplug_Detected); - if Cur_Config.Port /= New_Config.Port or - Cur_Config.Mode /= New_Config.Mode or - Unplug_Detected - then + if Full_Update (Cur_Config, New_Config) or Unplug_Detected then Disable_Output (Pipe, Cur_Config); Cur_Config.Port := Disabled; Update_Power; @@ -263,9 +271,8 @@ Cur_Config : Pipe_Config renames Cur_Configs (Pipe); New_Config : Pipe_Config renames Configs (Pipe); begin - if New_Config.Port /= Disabled and then - (Cur_Config.Port /= New_Config.Port or - Cur_Config.Mode /= New_Config.Mode) + if New_Config.Port /= Disabled and + Full_Update (Cur_Config, New_Config) then if Wait_For_HPD (New_Config.Port) then Check_HPD (New_Config.Port, Success); diff --git a/common/hw-gfx-gma.ads b/common/hw-gfx-gma.ads index f66625e..877528c 100644 --- a/common/hw-gfx-gma.ads +++ b/common/hw-gfx-gma.ads @@ -1,5 +1,5 @@ -- --- Copyright (C) 2015-2017 secunet Security Networks AG +-- Copyright (C) 2015-2018 secunet Security Networks AG -- Copyright (C) 2017 Nico Huber <nico.h(a)gmx.de> -- -- This program is free software; you can redistribute it and/or modify @@ -129,6 +129,10 @@ Cur_Configs : Pipe_Configs with Part_Of => State; + function Requires_Scaling (Pipe_Cfg : Pipe_Config) return Boolean is + (Pipe_Cfg.Framebuffer.Width /= Pos32 (Pipe_Cfg.Mode.H_Visible) or + Pipe_Cfg.Framebuffer.Height /= Pos32 (Pipe_Cfg.Mode.V_Visible)); + ---------------------------------------------------------------------------- -- Internal representation of a single pipe's configuration -- To view, visit https://review.coreboot.org/26663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I46318bb74d00a584d268a9d76787f8b26249264d Gerrit-Change-Number: 26663 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018