coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage
by Bora Guvendik (Code Review) 28 Apr '18

28 Apr '18

Hello Subrata Banik, Maulik V Vaghela, build bot (Jenkins), Shaunak Saha, Hannah Williams, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25891 to look at the new patch set (#11). Change subject: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage ...................................................................... [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage Move pch_uart_init to common bootblock stage and let SOC just provide the port information. Change-Id: Id249b7c5449cbf37905e04376eef5d9086213235 Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/soc/intel/apollolake/bootblock/pch.c D src/soc/intel/apollolake/include/soc/pch.h M src/soc/intel/apollolake/include/soc/uart.h M src/soc/intel/apollolake/romstage.c M src/soc/intel/apollolake/uart.c M src/soc/intel/cannonlake/include/soc/pch.h M src/soc/intel/cannonlake/uart.c M src/soc/intel/common/basecode/bootblock/Makefile.inc M src/soc/intel/common/basecode/bootblock/bootblock.c A src/soc/intel/common/basecode/bootblock/uart.c A src/soc/intel/common/basecode/include/intelbasecode/uart.h 11 files changed, 136 insertions(+), 101 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/25891/11 -- To view, visit https://review.coreboot.org/25891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id249b7c5449cbf37905e04376eef5d9086213235 Gerrit-Change-Number: 25891 Gerrit-PatchSet: 11 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP] src/intel/common: Add support to enable UART in 16550 mode
by Bora Guvendik (Code Review) 28 Apr '18

28 Apr '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25902 to look at the new patch set (#8). Change subject: [WIP] src/intel/common: Add support to enable UART in 16550 mode ...................................................................... [WIP] src/intel/common: Add support to enable UART in 16550 mode Move the code to enable UART 16550 mode to common lpss driver. Change-Id: I7ee5f2f175984148cb448df5f82487155d15de8f Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/soc/intel/common/block/include/intelblocks/lpss.h M src/soc/intel/common/block/lpss/Kconfig M src/soc/intel/common/block/lpss/lpss.c 3 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/25902/8 -- To view, visit https://review.coreboot.org/25902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ee5f2f175984148cb448df5f82487155d15de8f Gerrit-Change-Number: 25902 Gerrit-PatchSet: 8 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP] src/intel/apollolake: Unify name for uart debug config flag
by Bora Guvendik (Code Review) 28 Apr '18

28 Apr '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25904 to look at the new patch set (#4). Change subject: [WIP] src/intel/apollolake: Unify name for uart debug config flag ...................................................................... [WIP] src/intel/apollolake: Unify name for uart debug config flag Big core defined CONFIG_UART_DEBUG and small core defined it as CONFIG_SOC_UART_DEBUG. Change small core to use CONFIG_UART_DEBUG as well so that common code for big/small cores can take advantage of it. Change-Id: I0db5b034fa8cf62141ab16e916df21f941e1c2ae Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/mainboard/intel/leafhill/Kconfig M src/mainboard/intel/minnow3/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/Makefile.inc M src/soc/intel/apollolake/bootblock/pch.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/apollolake/uart.c 7 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/25904/4 -- To view, visit https://review.coreboot.org/25904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0db5b034fa8cf62141ab16e916df21f941e1c2ae Gerrit-Change-Number: 25904 Gerrit-PatchSet: 4 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25891 ) Change subject: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25137/ : SUCCESS -- To view, visit https://review.coreboot.org/25891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id249b7c5449cbf37905e04376eef5d9086213235 Gerrit-Change-Number: 25891 Gerrit-PatchSet: 10 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 00:30:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25891 ) Change subject: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage ...................................................................... Patch Set 9: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70957/ : ABORTED -- To view, visit https://review.coreboot.org/25891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id249b7c5449cbf37905e04376eef5d9086213235 Gerrit-Change-Number: 25891 Gerrit-PatchSet: 9 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 00:30:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage
by Bora Guvendik (Code Review) 28 Apr '18

28 Apr '18

Hello Subrata Banik, Maulik V Vaghela, build bot (Jenkins), Shaunak Saha, Hannah Williams, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25891 to look at the new patch set (#10). Change subject: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage ...................................................................... [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage Move pch_uart_init to common bootblock stage and let SOC just provide the port information. Change-Id: Id249b7c5449cbf37905e04376eef5d9086213235 Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/soc/intel/apollolake/bootblock/pch.c D src/soc/intel/apollolake/include/soc/pch.h M src/soc/intel/apollolake/include/soc/uart.h M src/soc/intel/apollolake/romstage.c M src/soc/intel/apollolake/uart.c M src/soc/intel/cannonlake/include/soc/pch.h M src/soc/intel/cannonlake/uart.c M src/soc/intel/common/basecode/bootblock/Makefile.inc M src/soc/intel/common/basecode/bootblock/bootblock.c A src/soc/intel/common/basecode/bootblock/uart.c A src/soc/intel/common/basecode/include/intelbasecode/uart.h 11 files changed, 136 insertions(+), 101 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/25891/10 -- To view, visit https://review.coreboot.org/25891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id249b7c5449cbf37905e04376eef5d9086213235 Gerrit-Change-Number: 25891 Gerrit-PatchSet: 10 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP] src/intel/common: Add support to enable UART in 16550 mode
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25902 ) Change subject: [WIP] src/intel/common: Add support to enable UART in 16550 mode ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70956/ : SUCCESS -- To view, visit https://review.coreboot.org/25902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ee5f2f175984148cb448df5f82487155d15de8f Gerrit-Change-Number: 25902 Gerrit-PatchSet: 7 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 00:25:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] src/intel/common: Add support to enable UART in 16550 mode
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25902 ) Change subject: [WIP] src/intel/common: Add support to enable UART in 16550 mode ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25135/ : SUCCESS -- To view, visit https://review.coreboot.org/25902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ee5f2f175984148cb448df5f82487155d15de8f Gerrit-Change-Number: 25902 Gerrit-PatchSet: 7 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 00:19:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25891 ) Change subject: [WIP] soc/intel/common: Move pch_uart_init to common bootblock stage ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25136/ : SUCCESS -- To view, visit https://review.coreboot.org/25891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id249b7c5449cbf37905e04376eef5d9086213235 Gerrit-Change-Number: 25891 Gerrit-PatchSet: 9 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 00:19:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] src/intel/common: Add support to enable UART in 16550 mode
by Bora Guvendik (Code Review) 28 Apr '18

28 Apr '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25902 to look at the new patch set (#7). Change subject: [WIP] src/intel/common: Add support to enable UART in 16550 mode ...................................................................... [WIP] src/intel/common: Add support to enable UART in 16550 mode Move the code to enable UART 16550 mode to common lpss driver. Change-Id: I7ee5f2f175984148cb448df5f82487155d15de8f Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/soc/intel/common/block/include/intelblocks/lpss.h M src/soc/intel/common/block/lpss/Kconfig M src/soc/intel/common/block/lpss/lpss.c 3 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/25902/7 -- To view, visit https://review.coreboot.org/25902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ee5f2f175984148cb448df5f82487155d15de8f Gerrit-Change-Number: 25902 Gerrit-PatchSet: 7 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018