coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: x86/mpspec: order the I/O APICs by the APIC Id
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25799 ) Change subject: x86/mpspec: order the I/O APICs by the APIC Id ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25159/ : SUCCESS -- To view, visit https://review.coreboot.org/25799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf823eb5b3a29e4590cba915069cdfe5f780edcd Gerrit-Change-Number: 25799 Gerrit-PatchSet: 4 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 19:41:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: x86/mpspec: order the I/O APICs by the APIC Id
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25799 ) Change subject: x86/mpspec: order the I/O APICs by the APIC Id ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70982/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/25157/ : SUCCESS -- To view, visit https://review.coreboot.org/25799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf823eb5b3a29e4590cba915069cdfe5f780edcd Gerrit-Change-Number: 25799 Gerrit-PatchSet: 3 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 19:41:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Disable SMBUS in devicetree
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25911 ) Change subject: mb/google/octopus: Disable SMBUS in devicetree ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70981/ : SUCCESS -- To view, visit https://review.coreboot.org/25911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1940e6859e81d93f52967779139ee133cdf5ebc6 Gerrit-Change-Number: 25911 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 18:30:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Disable SMBUS in devicetree
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25911 ) Change subject: mb/google/octopus: Disable SMBUS in devicetree ...................................................................... Patch Set 1: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70980/ : SUCCESS -- To view, visit https://review.coreboot.org/25911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1940e6859e81d93f52967779139ee133cdf5ebc6 Gerrit-Change-Number: 25911 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 18:25:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Disable SMBUS in devicetree
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25911 ) Change subject: mb/google/octopus: Disable SMBUS in devicetree ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25156/ : SUCCESS -- To view, visit https://review.coreboot.org/25911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1940e6859e81d93f52967779139ee133cdf5ebc6 Gerrit-Change-Number: 25911 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 18:18:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Disable SMBUS in devicetree
by Hannah Williams (Code Review) 28 Apr '18

28 Apr '18

Hannah Williams has uploaded this change for review. ( https://review.coreboot.org/25911 Change subject: mb/google/octopus: Disable SMBUS in devicetree ...................................................................... mb/google/octopus: Disable SMBUS in devicetree There is no device connected in this interface Change-Id: I1940e6859e81d93f52967779139ee133cdf5ebc6 Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/25911/1 diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index 128feda..d341a8d 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -207,6 +207,6 @@ device pnp 0c09.0 on end end end # - ESPI - device pci 1f.1 on end # - SMBUS + device pci 1f.1 off end # - SMBUS end end -- To view, visit https://review.coreboot.org/25911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1940e6859e81d93f52967779139ee133cdf5ebc6 Gerrit-Change-Number: 25911 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: southbridge/broadcom: Remove spaces before/after parenthesis
by Felix Held (Code Review) 28 Apr '18

28 Apr '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/25875 ) Change subject: southbridge/broadcom: Remove spaces before/after parenthesis ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25875/1/src/southbridge/broadcom/bcm5785/bc… File src/southbridge/broadcom/bcm5785/bcm5785.c: https://review.coreboot.org/#/c/25875/1/src/southbridge/broadcom/bcm5785/bc… PS1, Line 39: ( add a space before the ( -- To view, visit https://review.coreboot.org/25875 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43b5ddaa395658ab7c34cdd004516884a20b005 Gerrit-Change-Number: 25875 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 28 Apr 2018 15:26:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/fizz: disable Apex power enable in S3 sleep
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25910 ) Change subject: google/fizz: disable Apex power enable in S3 sleep ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70979/ : FAILURE -- To view, visit https://review.coreboot.org/25910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaa798bcc90dbac4a9a4ee5b43b7a851358ee3c4 Gerrit-Change-Number: 25910 Gerrit-PatchSet: 1 Gerrit-Owner: Zhongze Hu <frankhu(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 13:36:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/fizz: disable Apex power enable in S3 sleep
by build bot (Jenkins) (Code Review) 28 Apr '18

28 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25910 ) Change subject: google/fizz: disable Apex power enable in S3 sleep ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25155/ : SUCCESS -- To view, visit https://review.coreboot.org/25910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaa798bcc90dbac4a9a4ee5b43b7a851358ee3c4 Gerrit-Change-Number: 25910 Gerrit-PatchSet: 1 Gerrit-Owner: Zhongze Hu <frankhu(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Apr 2018 13:36:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/fizz: disable Apex power enable in S3 sleep
by Zhongze Hu (Code Review) 28 Apr '18

28 Apr '18

Zhongze Hu has uploaded this change for review. ( https://review.coreboot.org/25910 Change subject: google/fizz: disable Apex power enable in S3 sleep ...................................................................... google/fizz: disable Apex power enable in S3 sleep CFM daughter card shares the 3.3V rail with SSD and is enabled by 3 GPIOs GPP_B20, GPP_C8 and GPP_C9. When entering S3 power state, these GPIOs will back bios the 3.3V rail to 1.5V, which sometimes casues SSD fail to resume. This CL disables these GPIOs in the sleep path. BUG=b:77931014 BRANCH=None TEST=Compiles successfully, will test on a device and update Change-Id: Ieaa798bcc90dbac4a9a4ee5b43b7a851358ee3c4 Signed-off-by: Zhongze Hu <frankhu(a)google.com> --- M src/mainboard/google/fizz/gpio.h M src/mainboard/google/fizz/smihandler.c 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/25910/1 diff --git a/src/mainboard/google/fizz/gpio.h b/src/mainboard/google/fizz/gpio.h index 9a94af4..a750edc 100644 --- a/src/mainboard/google/fizz/gpio.h +++ b/src/mainboard/google/fizz/gpio.h @@ -42,6 +42,11 @@ #define GPIO_OEM_ID2 GPP_D11 #define GPIO_OEM_ID3 GPP_D12 +/* CFM APEX chips enable GPIOs */ +#define GPIO_APEX_VCOM_EN GPP_B20 +#define GPIO_APEX0_VR_EN GPP_C8 +#define GPIO_APEX1_VR_EN GPP_C9 + #ifndef __ACPI__ /* Pad configuration in ramstage */ /* Leave eSPI pins untouched from default settings */ diff --git a/src/mainboard/google/fizz/smihandler.c b/src/mainboard/google/fizz/smihandler.c index 5f05b2e..8d5fd77 100644 --- a/src/mainboard/google/fizz/smihandler.c +++ b/src/mainboard/google/fizz/smihandler.c @@ -24,10 +24,28 @@ chromeec_smi_process_events(); } +static void mainboard_gpio_smi_sleep(u8 slp_typ) +{ + int i; + + gpio_t active_high_signals[] = { + GPIO_APEX_VCOM_EN, + GPIO_APEX0_VR_EN, + GPIO_APEX1_VR_EN, + }; + + for (i = 0; i < ARRAY_SIZE(active_high_signals); i++) + gpio_set(active_high_signals[i], 0); +} + void mainboard_smi_sleep(u8 slp_typ) { chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); + + /* Disable the Apex enable signals on S3 state. */ + if (slp_typ == ACPI_S3) + mainboard_gpio_smi_sleep(slp_typ); } int mainboard_smi_apmc(u8 apmc) -- To view, visit https://review.coreboot.org/25910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieaa798bcc90dbac4a9a4ee5b43b7a851358ee3c4 Gerrit-Change-Number: 25910 Gerrit-PatchSet: 1 Gerrit-Owner: Zhongze Hu <frankhu(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018