coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: src/soc/stoneyridge: Add a check for CMOS failure
by Martin Roth (Code Review) 01 Apr '18

01 Apr '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25468 Change subject: src/soc/stoneyridge: Add a check for CMOS failure ...................................................................... src/soc/stoneyridge: Add a check for CMOS failure BUG=b:77345148 TEST=Pull power from grunt, verify CMOS power failure is detected. Reboot and verify that CMOS power failure is not detected. Change-Id: Idbf0254e197a6d282e618a98bced52ea5a44917f Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/soc/amd/stoneyridge/pmutil.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/25468/1 diff --git a/src/soc/amd/stoneyridge/pmutil.c b/src/soc/amd/stoneyridge/pmutil.c index 25c9ec1..baabba5 100644 --- a/src/soc/amd/stoneyridge/pmutil.c +++ b/src/soc/amd/stoneyridge/pmutil.c @@ -17,11 +17,12 @@ #include <soc/southbridge.h> #include <security/vboot/vboot_common.h> #include <security/vboot/vbnv.h> +#include <pc80/mc146818rtc.h> int vbnv_cmos_failed(void) { - /* FIXME: RTC failure checking not supported. */ - return 0; + /* If CMOS power has failed, the century will be set to 0xff */ + return cmos_read(RTC_CLK_ALTCENTURY) == 0xff; } int vboot_platform_is_resuming(void) -- To view, visit https://review.coreboot.org/25468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idbf0254e197a6d282e618a98bced52ea5a44917f Gerrit-Change-Number: 25468 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mb/google/octopus: Make PMC I2C pads IOSTANDBY_IGNORE
by build bot (Jenkins) (Code Review) 01 Apr '18

01 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25467 ) Change subject: mb/google/octopus: Make PMC I2C pads IOSTANDBY_IGNORE ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69341/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23679/ : SUCCESS -- To view, visit https://review.coreboot.org/25467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b340deafccbf909ec1f4b11ba9a77c6b13a89fd Gerrit-Change-Number: 25467 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Apr 2018 01:01:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Make PMC I2C pads IOSTANDBY_IGNORE
by Hannah Williams (Code Review) 01 Apr '18

01 Apr '18

Hannah Williams has uploaded this change for review. ( https://review.coreboot.org/25467 Change subject: mb/google/octopus: Make PMC I2C pads IOSTANDBY_IGNORE ...................................................................... mb/google/octopus: Make PMC I2C pads IOSTANDBY_IGNORE This fixes wake from S0ix Change-Id: I3b340deafccbf909ec1f4b11ba9a77c6b13a89fd Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/google/octopus/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/25467/1 diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c index 1570223..9a0554a 100644 --- a/src/mainboard/google/octopus/variants/baseboard/gpio.c +++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c @@ -72,8 +72,8 @@ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* USB_OC1_B */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_46, 0, DEEP, DN_20K, HIZCRx0, DISPUPD), /* DSI_I2C_SDA */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_47, 0, DEEP, DN_20K, HIZCRx0, DISPUPD), /* DSI_I2C_SCL */ - PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_48, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* PMC_I2C_SDA */ - PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_49, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* PMC_I2C_SCL */ + PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_48, NONE, DEEP, NF1), /* PMC_I2C_SDA */ + PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_49, NONE, DEEP, NF1), /* PMC_I2C_SCL */ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_50, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C0_SDA */ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_51, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C0_SCL */ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_52, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C1_SDA */ -- To view, visit https://review.coreboot.org/25467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3b340deafccbf909ec1f4b11ba9a77c6b13a89fd Gerrit-Change-Number: 25467 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Hook up libgfxinit
by build bot (Jenkins) (Code Review) 01 Apr '18

01 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20113 ) Change subject: soc/intel/skylake: Hook up libgfxinit ...................................................................... Patch Set 10: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69339/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/23677/ : SUCCESS -- To view, visit https://review.coreboot.org/20113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79fbfed7732cf02d054530ea7ec0d34de32836ba Gerrit-Change-Number: 20113 Gerrit-PatchSet: 10 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Apr 2018 00:05:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake/graphics: Ensure intel_gma_restore_opregion() is ca...
by build bot (Jenkins) (Code Review) 01 Apr '18

01 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25466 ) Change subject: soc/intel/skylake/graphics: Ensure intel_gma_restore_opregion() is called ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69340/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23678/ : SUCCESS -- To view, visit https://review.coreboot.org/25466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If981fa3db12b3a4fe1411f4cce9bac8564697769 Gerrit-Change-Number: 25466 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Apr 2018 00:05:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/intel/gma: Amend stride calculation of linear fb
by build bot (Jenkins) (Code Review) 01 Apr '18

01 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25451 ) Change subject: drivers/intel/gma: Amend stride calculation of linear fb ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69336/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23674/ : SUCCESS -- To view, visit https://review.coreboot.org/25451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f824ffd7d12835935e4e4bde29fe82dc3e16f9d Gerrit-Change-Number: 25451 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Apr 2018 00:00:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: 3rdparty/libgfxinit: Update submodule pointer
by build bot (Jenkins) (Code Review) 01 Apr '18

01 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25453 ) Change subject: 3rdparty/libgfxinit: Update submodule pointer ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69338/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/23675/ : SUCCESS -- To view, visit https://review.coreboot.org/25453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a3c35c60b9edf8775f3a489df7577092910e127 Gerrit-Change-Number: 25453 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Apr 2018 00:00:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/intel/gma: Depend less on default fb values
by build bot (Jenkins) (Code Review) 01 Apr '18

01 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25452 ) Change subject: drivers/intel/gma: Depend less on default fb values ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69337/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/23676/ : SUCCESS -- To view, visit https://review.coreboot.org/25452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I121bbd926532c27321446282aa334cc45cdbeef1 Gerrit-Change-Number: 25452 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Apr 2018 00:00:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018