April 2018 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: mb/google/kahlee: Update i2c timings
by build bot (Jenkins) (Code Review) April 30, 2018

April 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25942 ) Change subject: mb/google/kahlee: Update i2c timings ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71062/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25238/ : SUCCESS -- To view, visit https://review.coreboot.org/25942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib961ec7c2b0a677d9cacdb7d91e5c78173d42017 Gerrit-Change-Number: 25942 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 19:41:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Update i2c timings
by Martin Roth (Code Review) April 30, 2018

April 30, 2018

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25942 Change subject: mb/google/kahlee: Update i2c timings ...................................................................... mb/google/kahlee: Update i2c timings Change the I2c timings to the latest measurements. BUG=b:72442912 TEST=Boot grunt Change-Id: Ib961ec7c2b0a677d9cacdb7d91e5c78173d42017 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/variants/grunt/devicetree.cb 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/25942/1 diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb index cfc3198..65e9ae8 100644 --- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb @@ -24,30 +24,30 @@ # Enable I2C0 for audio, USB3 hub at 400kHz register "i2c[0]" = "{ .speed = I2C_SPEED_FAST, - .rise_time_ns = 95, - .fall_time_ns = 3, + .rise_time_ns = 300, + .fall_time_ns = 34, }" # Enable I2C1 for H1 at 400kHz register "i2c[1]" = "{ .early_init = 1, .speed = I2C_SPEED_FAST, - .rise_time_ns = 84, + .rise_time_ns = 140, .fall_time_ns = 4, }" # Enable I2C2 for trackpad, pen at 400kHz register "i2c[2]" = "{ .speed = I2C_SPEED_FAST, - .rise_time_ns = 117, - .fall_time_ns = 113, + .rise_time_ns = 320, + .fall_time_ns = 34, }" # Enable I2C3 for touchscreen at 400kHz register "i2c[3]" = "{ .speed = I2C_SPEED_FAST, - .rise_time_ns = 82, - .fall_time_ns = 67, + .rise_time_ns = 320, + .fall_time_ns = 34, }" device cpu_cluster 0 on -- To view, visit https://review.coreboot.org/25942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib961ec7c2b0a677d9cacdb7d91e5c78173d42017 Gerrit-Change-Number: 25942 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: src/drivers: Add reset/enable/stop_off_ms variables to ACPI devices
by build bot (Jenkins) (Code Review) April 30, 2018

April 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25882 ) Change subject: src/drivers: Add reset/enable/stop_off_ms variables to ACPI devices ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71060/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25236/ : SUCCESS -- To view, visit https://review.coreboot.org/25882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb4a5dbe56eee4749d2f2b514e92c28fb2c6078f Gerrit-Change-Number: 25882 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 18:02:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Enable touchscreen through ACPI
by build bot (Jenkins) (Code Review) April 30, 2018

April 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25754 ) Change subject: mb/google/poppy/variants/nami: Enable touchscreen through ACPI ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71061/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25237/ : SUCCESS -- To view, visit https://review.coreboot.org/25754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1543f41f24cbe8c33aeb02e6aa43fd3dd977ed4 Gerrit-Change-Number: 25754 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 17:38:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lenovo: Add various vbt.bin
by Nico Huber (Code Review) April 30, 2018

April 30, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25926 ) Change subject: lenovo: Add various vbt.bin ...................................................................... Patch Set 1: > While I have no overall objection to the inclusion of these files, > could we change the filename for all of the current vbts to > something like data.vbt? This could also help with makefiles, > since .bin is pretty generic, where as .vbt is specific as to the > file type. How about <boardname>.vbt to have something that doesn't look too weird? Maybe <boardname>-ccfl.vbt, <boardname>-led.vbt for those older ThinkPads? > > Since the data is documented, is it possible to save it as a text > file and turn it into a binary with bincfg? In theory, yes. But the spec is platform dependent and loooooong, also see [1]. [1] https://mail.coreboot.org/pipermail/coreboot/2018-April/086531.html -- To view, visit https://review.coreboot.org/25926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15573ddd37ee9738df1f7178f967131687a50f48 Gerrit-Change-Number: 25926 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Mon, 30 Apr 2018 17:08:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/hp/dl145_g3: Fix coding style
by build bot (Jenkins) (Code Review) April 30, 2018

April 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23532 ) Change subject: mainboard/hp/dl145_g3: Fix coding style ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71059/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25235/ : SUCCESS -- To view, visit https://review.coreboot.org/23532 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78b43cbc052e6d243d67ca8cdd86b242e477a2c7 Gerrit-Change-Number: 23532 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 16:45:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Add support to configure top swap feature
by build bot (Jenkins) (Code Review) April 30, 2018

April 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25805 ) Change subject: soc/intel/common: Add support to configure top swap feature ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71053/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25229/ : SUCCESS -- To view, visit https://review.coreboot.org/25805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea31b891f81e76d4d623fcb68183c3ad3dcadbad Gerrit-Change-Number: 25805 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Mon, 30 Apr 2018 16:44:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lenovo: Add various vbt.bin
by Martin Roth (Code Review) April 30, 2018

April 30, 2018

Martin Roth has posted comments on this change. ( https://review.coreboot.org/25926 ) Change subject: lenovo: Add various vbt.bin ...................................................................... Patch Set 1: While I have no overall objection to the inclusion of these files, could we change the filename for all of the current vbts to something like data.vbt? This could also help with makefiles, since .bin is pretty generic, where as .vbt is specific as to the file type. Since the data is documented, is it possible to save it as a text file and turn it into a binary with bincfg? -- To view, visit https://review.coreboot.org/25926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15573ddd37ee9738df1f7178f967131687a50f48 Gerrit-Change-Number: 25926 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Mon, 30 Apr 2018 16:32:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: gitignore: Remove .bin
by Martin Roth (Code Review) April 30, 2018

April 30, 2018

Martin Roth has posted comments on this change. ( https://review.coreboot.org/25925 ) Change subject: gitignore: Remove .bin ...................................................................... Patch Set 1: I'd rather we didn't open this up. I'll make some further suggestions in the next patch. -- To view, visit https://review.coreboot.org/25925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bd5890a3f79c5e0e589772789cc30ec51b2b3b Gerrit-Change-Number: 25925 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Mon, 30 Apr 2018 16:27:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: gitignore: Remove .bin
by Marc Jones (Code Review) April 30, 2018

April 30, 2018

Marc Jones has removed Patrick Rudolph from this change. ( https://review.coreboot.org/25925 ) Change subject: gitignore: Remove .bin ...................................................................... Removed reviewer Patrick Rudolph. -- To view, visit https://review.coreboot.org/25925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I27bd5890a3f79c5e0e589772789cc30ec51b2b3b Gerrit-Change-Number: 25925 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com>

1 0