April 2018 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: 3rdparty/libgfxinit: Update submodule pointer
by build bot (Jenkins) (Code Review) April 2, 2018

April 2, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25453 ) Change subject: 3rdparty/libgfxinit: Update submodule pointer ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23675/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69360/ : SUCCESS -- To view, visit https://review.coreboot.org/25453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a3c35c60b9edf8775f3a489df7577092910e127 Gerrit-Change-Number: 25453 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 08:46:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/x86/mtrr: Use single code path with/without holes
by build bot (Jenkins) (Code Review) April 2, 2018

April 2, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21916 ) Change subject: cpu/x86/mtrr: Use single code path with/without holes ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23672/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69358/ : SUCCESS -- To view, visit https://review.coreboot.org/21916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedf7dfad61d6baac91973062e2688ad866f05afd Gerrit-Change-Number: 21916 Gerrit-PatchSet: 10 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 08:46:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/intel/gma: Depend less on default fb values
by build bot (Jenkins) (Code Review) April 2, 2018

April 2, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25452 ) Change subject: drivers/intel/gma: Depend less on default fb values ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23676/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69359/ : SUCCESS -- To view, visit https://review.coreboot.org/25452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I121bbd926532c27321446282aa334cc45cdbeef1 Gerrit-Change-Number: 25452 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 08:46:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/x86/mtrr: Optimize hole carving strategy
by build bot (Jenkins) (Code Review) April 2, 2018

April 2, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21915 ) Change subject: cpu/x86/mtrr: Optimize hole carving strategy ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23670/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69357/ : SUCCESS -- To view, visit https://review.coreboot.org/21915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefb064ce8c4f293490a19dd46054b966c63bde44 Gerrit-Change-Number: 21915 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 08:40:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Let mainboard override SPI opmenu
by build bot (Jenkins) (Code Review) April 2, 2018

April 2, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23587 ) Change subject: sb/intel/bd82x6x: Let mainboard override SPI opmenu ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23669/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69356/ : SUCCESS -- To view, visit https://review.coreboot.org/23587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ceaf5b2d11365e21a2bebc9c5def1fcf0be8aad Gerrit-Change-Number: 23587 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 08:40:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable Keyboard backlight for Grunt
by build bot (Jenkins) (Code Review) April 1, 2018

April 1, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25470 ) Change subject: mainboard/google/kahlee: Enable Keyboard backlight for Grunt ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69354/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23685/ : SUCCESS -- To view, visit https://review.coreboot.org/25470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf0f23581bcba0b035c126c68fb167274d7c698a Gerrit-Change-Number: 25470 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 06:45:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable Keyboard backlight for Grunt
by Martin Roth (Code Review) April 1, 2018

April 1, 2018

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25470 Change subject: mainboard/google/kahlee: Enable Keyboard backlight for Grunt ...................................................................... mainboard/google/kahlee: Enable Keyboard backlight for Grunt Grunt supports a keyboard backlight, so enable the ASL code. BUG=b:77455525 Test=Boot Grunt, verify that the string 'KBLT' is in the DSDT. Change-Id: Idf0f23581bcba0b035c126c68fb167274d7c698a Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/25470/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h index e93c2dd..eefcd4d 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h @@ -64,6 +64,9 @@ /* Enable EC backed PD MCU device in ACPI */ #define EC_ENABLE_PD_MCU_DEVICE +/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ -- To view, visit https://review.coreboot.org/25470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idf0f23581bcba0b035c126c68fb167274d7c698a Gerrit-Change-Number: 25470 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update WP to active low
by build bot (Jenkins) (Code Review) April 1, 2018

April 1, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25469 ) Change subject: mainboard/google/kahlee: Update WP to active low ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69353/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23684/ : SUCCESS -- To view, visit https://review.coreboot.org/25469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1369dbda609e34b308af308880449643be6af39 Gerrit-Change-Number: 25469 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 05:23:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update WP to active low
by Martin Roth (Code Review) April 1, 2018

April 1, 2018

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25469 Change subject: mainboard/google/kahlee: Update WP to active low ...................................................................... mainboard/google/kahlee: Update WP to active low The WP signal to the AP isn't inverted as it is on other platforms, so it was reporting incorrectly. Change the ACPI table to be active low, and invert the signal when reporting it to everything else. BUG=b:74946358 TEST=Boot grunt with battery inserted, WP signals both report 1. Remove battery, WP_CUR reports 0, WP_BOOT still reports 1. Change-Id: Ic1369dbda609e34b308af308880449643be6af39 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/chromeos.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/25469/1 diff --git a/src/mainboard/google/kahlee/chromeos.c b/src/mainboard/google/kahlee/chromeos.c index e74e3b9..4b0f9a2 100644 --- a/src/mainboard/google/kahlee/chromeos.c +++ b/src/mainboard/google/kahlee/chromeos.c @@ -37,12 +37,13 @@ int get_write_protect_state(void) { - return gpio_get(CROS_WP_GPIO); + /* Write protect is active low, so invert it here */ + return !gpio_get(CROS_WP_GPIO); } static const struct cros_gpio cros_gpios[] = { CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, GPIO_DEVICE_NAME), - CROS_GPIO_WP_AH(CROS_WP_GPIO, GPIO_DEVICE_NAME), + CROS_GPIO_WP_AL(CROS_WP_GPIO, GPIO_DEVICE_NAME), }; void mainboard_chromeos_acpi_generate(void) -- To view, visit https://review.coreboot.org/25469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic1369dbda609e34b308af308880449643be6af39 Gerrit-Change-Number: 25469 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: model_206ax: Use parallel mp init
by build bot (Jenkins) (Code Review) April 1, 2018

April 1, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23432 ) Change subject: model_206ax: Use parallel mp init ...................................................................... Patch Set 13: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23681/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69351/ : SUCCESS -- To view, visit https://review.coreboot.org/23432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacd7bfedfccbc09057e1b7ca3bd03d44a888871d Gerrit-Change-Number: 23432 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 02:07:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0