coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: gigabyte/ga-h61m-s2pv: Add new mainboard
by Arthur Heymans (Code Review) 29 Apr '18

29 Apr '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/25912 ) Change subject: gigabyte/ga-h61m-s2pv: Add new mainboard ...................................................................... Patch Set 1: (5 comments) Looks good. A few very minor nits though. https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv… File src/mainboard/gigabyte/ga-h61m-s2pv/devicetree.cb: https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv… PS1, Line 114: io 0x62 = 0xa20 usually put about irq 0x70 = ... https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv… PS1, Line 119: io 0x62 = 0x64 same https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv… File src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c: https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv… PS1, Line 16: #define SUPERIO_BASE 0x2e : #define SUPERIO_DEV PNP_DEV(SUPERIO_BASE, 0) : #define SUPERIO_GPIO PNP_DEV(SUPERIO_BASE, IT8728F_GPIO) : #define SERIAL_DEV PNP_DEV(SUPERIO_BASE, 0x01) usually put below the #include macros. https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv… PS1, Line 62: ite_reg_write(IT8728F_EC, 0xf1, 0xc0); : ite_reg_write(IT8728F_EC, 0xf6, 0xf0); : ite_reg_write(IT8728F_EC, 0xf9, 0x48); : ite_reg_write(IT8728F_EC, 0x60, 0x0a); : ite_reg_write(IT8728F_EC, 0x61, 0x30); : ite_reg_write(IT8728F_EC, 0x62, 0x0a); : ite_reg_write(IT8728F_EC, 0x63, 0x20); : ite_reg_write(IT8728F_EC, 0x30, 0x01); you could probably set most of these in the devicetree/ramstage or is the fan not working in romstage if you don't do this? https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv… PS1, Line 84: pci_write_config32(PCH_LPC_DEV, LPC_GEN1_DEC, 0x3c0a01); might not be needed to be set in romstage. -- To view, visit https://review.coreboot.org/25912 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I598a0b75093a0f1aef2ac615035d66786a8c22cb Gerrit-Change-Number: 25912 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:32:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Add DDR3 rcomp
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19875 ) Change subject: nb/intel/x4x: Add DDR3 rcomp ...................................................................... Patch Set 19: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25173/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70998/ : SUCCESS -- To view, visit https://review.coreboot.org/19875 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifef905f5115ffc826b1a355e54c4b1ca818e56fa Gerrit-Change-Number: 19875 Gerrit-PatchSet: 19 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:31:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Implement write leveling
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22995 ) Change subject: nb/intel/x4x: Implement write leveling ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25176/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70999/ : SUCCESS -- To view, visit https://review.coreboot.org/22995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695969868b4534f87dd1f37244fdfac891a417f0 Gerrit-Change-Number: 22995 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:31:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Support programming initials DD3 DLL setting
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22993 ) Change subject: nb/intel/x4x/raminit: Support programming initials DD3 DLL setting ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25172/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70997/ : SUCCESS -- To view, visit https://review.coreboot.org/22993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67e48b4ae6f2076399133ba7b98ab1dfc0e0ab08 Gerrit-Change-Number: 22993 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:31:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Support programming DDR3 timings
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19873 ) Change subject: nb/intel/x4x/raminit: Support programming DDR3 timings ...................................................................... Patch Set 19: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25171/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70996/ : SUCCESS -- To view, visit https://review.coreboot.org/19873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2494684ec66d84d4dc27c6a6b425a33ace6e827 Gerrit-Change-Number: 19873 Gerrit-PatchSet: 19 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:26:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Change memory layout to improve MTRR
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21634 ) Change subject: nb/intel/x4x: Change memory layout to improve MTRR ...................................................................... Patch Set 25: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70989/ : SUCCESS -- To view, visit https://review.coreboot.org/21634 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b5ea04d9b7d5494a30aa7156d8c17170e77b8ad Gerrit-Change-Number: 21634 Gerrit-PatchSet: 25 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:26:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/x4x/raminit: Decode ddr3 dimms
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19869 ) Change subject: nb/x4x/raminit: Decode ddr3 dimms ...................................................................... Patch Set 19: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25167/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70991/ : SUCCESS -- To view, visit https://review.coreboot.org/19869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dba19ca1e6e6b0a03b56c8de9633f9c1a2eb7d7 Gerrit-Change-Number: 19869 Gerrit-PatchSet: 19 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:26:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Make programming launch ddr3 specific
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19872 ) Change subject: nb/intel/x4x/raminit: Make programming launch ddr3 specific ...................................................................... Patch Set 19: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25170/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70995/ : SUCCESS -- To view, visit https://review.coreboot.org/19872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2ca4a200a1c813b2133eb1004fbe248fa3de9ce Gerrit-Change-Number: 19872 Gerrit-PatchSet: 19 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:26:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Implement both read and write training
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22329 ) Change subject: nb/intel/x4x: Implement both read and write training ...................................................................... Patch Set 23: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/25181/ : SUCCESS -- To view, visit https://review.coreboot.org/22329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdc63b91b4705d1a80437314bfe55385ea5b6c1 Gerrit-Change-Number: 22329 Gerrit-PatchSet: 23 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:21:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/x4x: Implement both read and write training
by build bot (Jenkins) (Code Review) 29 Apr '18

29 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22329 ) Change subject: nb/intel/x4x: Implement both read and write training ...................................................................... Patch Set 24: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25183/ : SUCCESS -- To view, visit https://review.coreboot.org/22329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdc63b91b4705d1a80437314bfe55385ea5b6c1 Gerrit-Change-Number: 22329 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:21:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
217
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018