build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 )
Change subject: ifdtool: Port the feature to jail ME from me_cleaner
......................................................................
Patch Set 36:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/70986/ : SUCCESS
--
To view, visit https://review.coreboot.org/21607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564
Gerrit-Change-Number: 21607
Gerrit-PatchSet: 36
Gerrit-Owner: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 29 Apr 2018 03:53:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 )
Change subject: ifdtool: Port the feature to jail ME from me_cleaner
......................................................................
Patch Set 36:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/25161/ : SUCCESS
--
To view, visit https://review.coreboot.org/21607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564
Gerrit-Change-Number: 21607
Gerrit-PatchSet: 36
Gerrit-Owner: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 29 Apr 2018 03:48:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Felix Held has posted comments on this change. ( https://review.coreboot.org/22260 )
Change subject: nb/intel/sandybridge/raminit: Fix PDWN_mode on desktops
......................................................................
Patch Set 1:
(1 comment)
I'd suggest adding a #define PM_PDWN_Config 0x4cb0 and then using that constant in the code instead of the magic offset
https://review.coreboot.org/#/c/22260/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/22260/1//COMMIT_MSG@11
PS1, Line 11: 2.14.1.
2.17.1 on the datasheet I have
--
To view, visit https://review.coreboot.org/22260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic42f2ff3e719636be67b00fa37155939cd2e17de
Gerrit-Change-Number: 22260
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 28 Apr 2018 19:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Felix Held has posted comments on this change. ( https://review.coreboot.org/22261 )
Change subject: nb/intel/sandybridge/raminit: Fix SMBIOS 17 bus width
......................................................................
Patch Set 2:
is this only valid for non-ECC memory? for non-ECC DDR3 this is true, but I'm not sure about the ECC case
--
To view, visit https://review.coreboot.org/22261
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b83a098205455b1c820d0436c6984938f261466
Gerrit-Change-Number: 22261
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 28 Apr 2018 19:51:58 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No