coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: buildgcc: Add missing '\'
by Anonymous Coward (Code Review) 27 Apr '18

27 Apr '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25901 to look at the new patch set (#2). Change subject: buildgcc: Add missing '\' ...................................................................... buildgcc: Add missing '\' That caused the CFLAGS, CXXFLAGS, and '|| touch .failed' to not be taken into account when building binutils. Change-Id: I94521eb73cefdc5ed01fbf10122966a54cc28166 Signed-off-by: Vivia Nikolaidou <vivia.nikolaidou(a)puri.sm> --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/25901/2 -- To view, visit https://review.coreboot.org/25901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I94521eb73cefdc5ed01fbf10122966a54cc28166 Gerrit-Change-Number: 25901 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward #1001977 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: buildgcc: Add missing '\'
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25901 ) Change subject: buildgcc: Add missing '\' ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25129/ : SUCCESS -- To view, visit https://review.coreboot.org/25901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94521eb73cefdc5ed01fbf10122966a54cc28166 Gerrit-Change-Number: 25901 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward #1001977 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 22:19:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: buildgcc: Add missing '\'
by Anonymous Coward (Code Review) 27 Apr '18

27 Apr '18

Anonymous Coward #1001977 has uploaded this change for review. ( https://review.coreboot.org/25901 Change subject: buildgcc: Add missing '\' ...................................................................... buildgcc: Add missing '\' That caused the CFLAGS, CXXFLAGS, and '|| true' to not be taken into account when building binutils. Change-Id: I94521eb73cefdc5ed01fbf10122966a54cc28166 --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/25901/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 743937a..edcea7a 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -681,7 +681,7 @@ --target=${TARGETARCH} --enable-targets=${TARGETARCH}${ADDITIONALTARGET} \ --disable-werror --disable-nls --enable-lto --enable-gold \ --enable-interwork --enable-multilib \ - --enable-plugins --enable-multilibs + --enable-plugins --enable-multilibs \ CFLAGS="$HOSTCFLAGS" \ CXXFLAGS="$HOSTCFLAGS" \ || touch .failed -- To view, visit https://review.coreboot.org/25901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I94521eb73cefdc5ed01fbf10122966a54cc28166 Gerrit-Change-Number: 25901 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward #1001977

1 0

Change in coreboot[master]: util/docker: Add docker container that builds the sphinx documentation
by Philipp Deppenwiese (Code Review) 27 Apr '18

27 Apr '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/25869 ) Change subject: util/docker: Add docker container that builds the sphinx documentation ...................................................................... util/docker: Add docker container that builds the sphinx documentation It's what we use on coreboot.org to update www.coreboot.org/Documentation Change-Id: I6e5457d2e39a10f14fabd68bbb231a05e2f66f1d Signed-off-by: Patrick Georgi <patrick(a)georgi.software> Reviewed-on: https://review.coreboot.org/25869 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- A util/docker/docs.coreboot.org/Dockerfile A util/docker/docs.coreboot.org/README.md 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Philipp Deppenwiese: Looks good to me, approved Jonathan Neuschäfer: Looks good to me, but someone else must approve diff --git a/util/docker/docs.coreboot.org/Dockerfile b/util/docker/docs.coreboot.org/Dockerfile new file mode 100644 index 0000000..fa2313c --- /dev/null +++ b/util/docker/docs.coreboot.org/Dockerfile @@ -0,0 +1,5 @@ +FROM debian:sid +RUN apt-get update && apt-get install -y make python-sphinx python-recommonmark python-sphinx-rtd-theme +USER nobody +VOLUME /data-in /data-out +ENTRYPOINT bash -c "cd /data-in/Documentation && make sphinx BUILDDIR=/tmp/build && rm -rf /data-out/* && mv /tmp/build/html/* /data-out/" diff --git a/util/docker/docs.coreboot.org/README.md b/util/docker/docs.coreboot.org/README.md new file mode 100644 index 0000000..11c095d --- /dev/null +++ b/util/docker/docs.coreboot.org/README.md @@ -0,0 +1,3 @@ +How to use: + +docker run --rm -v $path-to-coreboot.git:/data-in:ro -v $path-to-html-output:/data-out $image -- To view, visit https://review.coreboot.org/25869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6e5457d2e39a10f14fabd68bbb231a05e2f66f1d Gerrit-Change-Number: 25869 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus: Enable pull on ESPI_IO1 line
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25900 ) Change subject: mb/google/octopus: Enable pull on ESPI_IO1 line ...................................................................... Patch Set 1: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70925/ : SUCCESS -- To view, visit https://review.coreboot.org/25900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic494aa7397b94bfd233ce10da8287660997b3377 Gerrit-Change-Number: 25900 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.corp-partner.google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 19:18:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy: Add variant for nocturne
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25803 ) Change subject: mb/google/poppy: Add variant for nocturne ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70924/ : SUCCESS -- To view, visit https://review.coreboot.org/25803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c7829041b3c45407c17f71b08cc7fc17f717e8 Gerrit-Change-Number: 25803 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 19:18:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Enable pull on ESPI_IO1 line
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25900 ) Change subject: mb/google/octopus: Enable pull on ESPI_IO1 line ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25107/ : SUCCESS -- To view, visit https://review.coreboot.org/25900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic494aa7397b94bfd233ce10da8287660997b3377 Gerrit-Change-Number: 25900 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.corp-partner.google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 19:11:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Enable pull on ESPI_IO1 line
by Furquan Shaikh (Code Review) 27 Apr '18

27 Apr '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25900 Change subject: mb/google/octopus: Enable pull on ESPI_IO1 line ...................................................................... mb/google/octopus: Enable pull on ESPI_IO1 line This change configures a weak internal pull-up on ESPI_IO1 line for octopus baseboard and variant bip. ESPI_IO1 is used as ALERT# line and is expected to be open-drain. However, there is no external pull on this line and so an internal pull-up is required to ensure proper eSPI communication. BUG=b:78497502 TEST=Verified that there is no eSPI communication failure between AP and EC during boot-up and on suspend/resume. Change-Id: Ic494aa7397b94bfd233ce10da8287660997b3377 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bip/gpio.c 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/25900/1 diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c index 8863bbb..732653a 100644 --- a/src/mainboard/google/octopus/variants/baseboard/gpio.c +++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c @@ -279,6 +279,14 @@ /* Enable power to wifi early in bootblock and de-assert PERST#. */ PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */ PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */ + + /* + * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak + * pull-up for proper operation. Since there is no external pull present + * on this platform, configure an internal weak pull-up. + */ + PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1, + ENPU), /* ESPI_IO1 */ }; const struct pad_config *__weak diff --git a/src/mainboard/google/octopus/variants/bip/gpio.c b/src/mainboard/google/octopus/variants/bip/gpio.c index fe7a2e2..84285d7 100644 --- a/src/mainboard/google/octopus/variants/bip/gpio.c +++ b/src/mainboard/google/octopus/variants/bip/gpio.c @@ -278,6 +278,14 @@ /* Enable power to wifi early in bootblock and de-assert PERST#. */ PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */ PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */ + + /* + * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak + * pull-up for proper operation. Since there is no external pull present + * on this platform, configure an internal weak pull-up. + */ + PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1, + ENPU), /* ESPI_IO1 */ }; const struct pad_config *variant_early_gpio_table(size_t *num) -- To view, visit https://review.coreboot.org/25900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic494aa7397b94bfd233ce10da8287660997b3377 Gerrit-Change-Number: 25900 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy: Add variant for nocturne
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25803 ) Change subject: mb/google/poppy: Add variant for nocturne ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25106/ : SUCCESS -- To view, visit https://review.coreboot.org/25803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c7829041b3c45407c17f71b08cc7fc17f717e8 Gerrit-Change-Number: 25803 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 18:55:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/crossgcc: Build Linux toolchain
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25151 ) Change subject: util/crossgcc: Build Linux toolchain ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-toolchain/402/ : UNSTABLE https://qa.coreboot.org/job/coreboot-gerrit/70920/ : UNSTABLE -- To view, visit https://review.coreboot.org/25151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bb0c39077859551568f2945f6475f9b241f7ccc Gerrit-Change-Number: 25151 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 27 Apr 2018 18:17:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018