Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25103
Change subject: mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4
......................................................................
mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4
Since nami proto did not have any external pull on MEM_CONFIG_4, use a
weak internal pull down before reading it.
BUG=b:74420123
TEST=Verified that the value read for MEM_CONFIG_4 is correct on nami.
Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/mainboard/google/poppy/variants/nami/memory.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/25103/1
diff --git a/src/mainboard/google/poppy/variants/nami/memory.c b/src/mainboard/google/poppy/variants/nami/memory.c
index 6aa0e76..082b9a4 100644
--- a/src/mainboard/google/poppy/variants/nami/memory.c
+++ b/src/mainboard/google/poppy/variants/nami/memory.c
@@ -82,7 +82,7 @@
void variant_memory_params(struct memory_params *p)
{
memset(p, 0, sizeof(*p));
- gpio_input(GPIO_MEM_CONFIG_4);
+ gpio_input_pulldown(GPIO_MEM_CONFIG_4);
if (gpio_get(GPIO_MEM_CONFIG_4))
/* set to LPDDR3 */
fill_lpddr3_memory_params(p);
--
To view, visit https://review.coreboot.org/25103
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4
Gerrit-Change-Number: 25103
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24912 )
Change subject: mb/scaleway/tagada: Set DIMM slot information from mainboard
......................................................................
Patch Set 3:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/22884/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/68464/ : SUCCESS
--
To view, visit https://review.coreboot.org/24912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fdf3520da62336a5c654575ed8d1f33eb4f4dc5
Gerrit-Change-Number: 24912
Gerrit-PatchSet: 3
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Mar 2018 09:57:48 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23851 )
Change subject: soc/intel/denverton_ns: Fill dimm info for SMBIOS table 17
......................................................................
Patch Set 5:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/22883/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/68465/ : SUCCESS
--
To view, visit https://review.coreboot.org/23851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5c4ceaf4e65359f72ec764f0914b5daa82f257e
Gerrit-Change-Number: 23851
Gerrit-PatchSet: 5
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert(a)online.net>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Shine Liu <shine.liu(a)intel.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Mar 2018 09:54:43 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/25102 )
Change subject: soc/intel/baytrail: add support for Intel GMA OpRegion
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/25102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab15e1de2bb7d8fbec2e8705a621cfca0f255d4b
Gerrit-Change-Number: 25102
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Mar 2018 08:33:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes