coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mb/google/nautilus: Add cio2 parameters per camera sensor
by build bot (Jenkins) (Code Review) 12 Mar '18

12 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25111 ) Change subject: mb/google/nautilus: Add cio2 parameters per camera sensor ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22902/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68485/ : SUCCESS -- To view, visit https://review.coreboot.org/25111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Gerrit-Change-Number: 25111 Gerrit-PatchSet: 2 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Yeh Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 16:44:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/nautilus: Add cio2 parameters per camera sensor
by Furquan Shaikh (Code Review) 12 Mar '18

12 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25111 ) Change subject: mb/google/nautilus: Add cio2 parameters per camera sensor ...................................................................... Patch Set 2: > Patch Set 1: > > (1 comment) > > It is under review together with kernel driver chnage. Marked as WIP. (no "WIP button" is in my UI though. ) SG. Please post an update once this is ready for review. -- To view, visit https://review.coreboot.org/25111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Gerrit-Change-Number: 25111 Gerrit-PatchSet: 2 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Yeh Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 16:41:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/nautilus: Add cio2 parameters per camera sensor
by Andy Yeh (Code Review) 12 Mar '18

12 Mar '18

Andy Yeh has posted comments on this change. ( https://review.coreboot.org/25111 ) Change subject: mb/google/nautilus: Add cio2 parameters per camera sensor ...................................................................... Patch Set 1: (1 comment) It is under review together with kernel driver chnage. Marked as WIP. (no "WIP button" is in my UI though. ) https://review.coreboot.org/#/c/25111/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl: https://review.coreboot.org/#/c/25111/1/src/mainboard/google/poppy/variants… PS1, Line 53: } > }, Okay -- To view, visit https://review.coreboot.org/25111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Gerrit-Change-Number: 25111 Gerrit-PatchSet: 1 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Yeh Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 16:40:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/nautilus: Add cio2 parameters per camera sensor
by Andy Yeh (Code Review) 12 Mar '18

12 Mar '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25111 to look at the new patch set (#2). Change subject: mb/google/nautilus: Add cio2 parameters per camera sensor ...................................................................... mb/google/nautilus: Add cio2 parameters per camera sensor Add several cio2 and pm_qos parameters in cam0.asl. The values will be loaded in kernel cio2 driver and replace the default value defined in CIO2_WMCTRL2_HWM_2CK, CIO2_LTRVAL0_VAL, CIO2_PM_QOS_LATENCY TEST=Verified with MIPI camera on DUT for long time streaming on test Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Signed-off-by: Andy Yeh <andy.yeh(a)intel.com> --- M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/25111/2 -- To view, visit https://review.coreboot.org/25111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Gerrit-Change-Number: 25111 Gerrit-PatchSet: 2 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/nautilus: Add cio2 parameterms per camera sensor
by Furquan Shaikh (Code Review) 12 Mar '18

12 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25111 ) Change subject: mb/google/nautilus: Add cio2 parameterms per camera sensor ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25111/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl: https://review.coreboot.org/#/c/25111/1/src/mainboard/google/poppy/variants… PS1, Line 53: } }, -- To view, visit https://review.coreboot.org/25111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Gerrit-Change-Number: 25111 Gerrit-PatchSet: 1 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 16:16:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/nautilus: Add cio2 parameterms per camera sensor
by build bot (Jenkins) (Code Review) 12 Mar '18

12 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25111 ) Change subject: mb/google/nautilus: Add cio2 parameterms per camera sensor ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68484/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22901/ : SUCCESS -- To view, visit https://review.coreboot.org/25111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Gerrit-Change-Number: 25111 Gerrit-PatchSet: 1 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Mar 2018 16:13:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/zoombini/variants/meowth: FPMCU interrupt is level-triggered
by build bot (Jenkins) (Code Review) 12 Mar '18

12 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25110 ) Change subject: mb/google/zoombini/variants/meowth: FPMCU interrupt is level-triggered ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22900/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68483/ : SUCCESS -- To view, visit https://review.coreboot.org/25110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba8cff21d637fe6bf4ef5152fc01aaf98906477d Gerrit-Change-Number: 25110 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Mar 2018 16:12:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/nautilus: Add cio2 parameterms per camera sensor
by Andy Yeh (Code Review) 12 Mar '18

12 Mar '18

Andy Yeh has uploaded this change for review. ( https://review.coreboot.org/25111 Change subject: mb/google/nautilus: Add cio2 parameterms per camera sensor ...................................................................... mb/google/nautilus: Add cio2 parameterms per camera sensor Add several cio2 and pm_qos parameters in cam0.asl. The values will be loaded in kernel cio2 driver and replace the default value defined in CIO2_WMCTRL2_HWM_2CK, CIO2_LTRVAL0_VAL, CIO2_PM_QOS_LATENCY TEST=Verified the MIPI camera for long time streaming on test Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Signed-off-by: Andy Yeh <andy.yeh(a)intel.com> --- M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/25111/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl index 4c2143a..9d33a86 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl @@ -51,6 +51,12 @@ Package () { "lens-focus", Package () { \_SB.PCI0.I2C2.VCM0 } } + /* + * loaded as cio2 params per sensor/project + */ + Package () { "wmctrl2_hwm", 20 }, + Package () { "ltr_value", 80 }, + Package () { "pm_qos_latency", 50 }, } }) -- To view, visit https://review.coreboot.org/25111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I80b577d004a6bda9b941b5f95d34c4b36e0ccd87 Gerrit-Change-Number: 25111 Gerrit-PatchSet: 1 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com>

1 0

Change in coreboot[master]: mb/google/zoombini/variants/meowth: FPMCU interrupt is level-triggered
by Vincent Palatin (Code Review) 12 Mar '18

12 Mar '18

Vincent Palatin has uploaded this change for review. ( https://review.coreboot.org/25110 Change subject: mb/google/zoombini/variants/meowth: FPMCU interrupt is level-triggered ...................................................................... mb/google/zoombini/variants/meowth: FPMCU interrupt is level-triggered Fix the IRQ configuration: it must be level-sensitive not edge-sensitive (and match the GPIO configuration). BUG=b:71986991 BRANCH=none TEST=on Meowth, /proc/interrupts shows 'IO-APIC 46-fasteoi chromeos-ec' then run 'ectool --name=cros_fp fpmode fingerup' and see the number of interrupts incrementing and the MKBP event happening. Signed-off-by: Vincent Palatin <vpalatin(a)chromium.org> Change-Id: Iba8cff21d637fe6bf4ef5152fc01aaf98906477d --- M src/mainboard/google/zoombini/variants/meowth/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/25110/1 diff --git a/src/mainboard/google/zoombini/variants/meowth/devicetree.cb b/src/mainboard/google/zoombini/variants/meowth/devicetree.cb index 2d15c97..7db51be 100644 --- a/src/mainboard/google/zoombini/variants/meowth/devicetree.cb +++ b/src/mainboard/google/zoombini/variants/meowth/devicetree.cb @@ -174,7 +174,7 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "uid" = "1" register "compat_string" = ""google,cros-ec-spi"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A22_IRQ)" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A22_IRQ)" device spi 0 on end end end # GSPI #1 -- To view, visit https://review.coreboot.org/25110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iba8cff21d637fe6bf4ef5152fc01aaf98906477d Gerrit-Change-Number: 25110 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org>

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Add vboot support
by build bot (Jenkins) (Code Review) 12 Mar '18

12 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25109 ) Change subject: mb/cavium/cn8100_sff_evb: Add vboot support ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68481/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22899/ : SUCCESS -- To view, visit https://review.coreboot.org/25109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb5395e56203fca4a03f2e9a47c21e772ad9ae79 Gerrit-Change-Number: 25109 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Mar 2018 16:00:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018