coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mb/google/poppy/variant/nautilus: Enable CABC feature as default
by Seunghwan Kim (Code Review) 13 Mar '18

13 Mar '18

Seunghwan Kim has uploaded a new patch set (#2). ( https://review.coreboot.org/25120 ) Change subject: mb/google/poppy/variant/nautilus: Enable CABC feature as default ...................................................................... mb/google/poppy/variant/nautilus: Enable CABC feature as default This change configures GPP_E22 to GPO_HIGH to enable CABC feature on nautilus board. BUG=b:68789889 BRANCH=master TEST=emerge-nautilus coreboot Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> Change-Id: Ifed0d37bf8147aa1b580f594f36f186051c2eb52 --- M src/mainboard/google/poppy/variants/nautilus/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/25120/2 -- To view, visit https://review.coreboot.org/25120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifed0d37bf8147aa1b580f594f36f186051c2eb52 Gerrit-Change-Number: 25120 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com>

1 0

Change in coreboot[master]: mb/google/poppy/variant/nautilus: Enable CABC feature as default
by Seunghwan Kim (Code Review) 13 Mar '18

13 Mar '18

Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/25120 Change subject: mb/google/poppy/variant/nautilus: Enable CABC feature as default ...................................................................... mb/google/poppy/variant/nautilus: Enable CABC feature as default This change configures GPP_E22 to GPO_HIGH to enable CABC feature on nautilus board. BUG=b:68789889 BRANCH=master TEST=emerge-nautilus coreboot Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> Change-Id: Ifed0d37bf8147aa1b580f594f36f186051c2eb52 --- M src/mainboard/google/poppy/variants/nautilus/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/25120/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c index e0b8b7d..839f425 100644 --- a/src/mainboard/google/poppy/variants/nautilus/gpio.c +++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c @@ -253,8 +253,8 @@ PAD_CFG_NC(GPP_E20), /* E21 : DDPC_CTRLDATA ==> NC */ PAD_CFG_NC(GPP_E21), - /* E22 : DDPD_CTRLCLK ==> NC */ - PAD_CFG_NC(GPP_E22), + /* E22 : DDPD_CTRLCLK ==> CHP1_CABC */ + PAD_CFG_GPO(GPP_E22, 1, DEEP), /* E23 : DDPD_CTRLDATA ==> NC */ PAD_CFG_NC(GPP_E23), -- To view, visit https://review.coreboot.org/25120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifed0d37bf8147aa1b580f594f36f186051c2eb52 Gerrit-Change-Number: 25120 Gerrit-PatchSet: 1 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com>

1 0

Change in coreboot[master]: mainboard: Add ASUS Maximus IV GENE-Z
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24971 ) Change subject: mainboard: Add ASUS Maximus IV GENE-Z ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22912/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68498/ : SUCCESS -- To view, visit https://review.coreboot.org/24971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fc7940bb139623a5a0fde984c023deca9b551f2 Gerrit-Change-Number: 24971 Gerrit-PatchSet: 3 Gerrit-Owner: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 07:30:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Documentation/Intel: Add build setup documentation for Intel RVP boards
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25043 ) Change subject: Documentation/Intel: Add build setup documentation for Intel RVP boards ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22911/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68497/ : SUCCESS -- To view, visit https://review.coreboot.org/25043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f31b12b03b8b0662fd4fda0afa7c1c634a39dfe Gerrit-Change-Number: 25043 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 06:22:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/Intel: Add build setup documentation for Intel RVP boards
by V Sowmya (Code Review) 13 Mar '18

13 Mar '18

Hello Naresh Solanki, Balaji Manigandan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25043 to look at the new patch set (#3). Change subject: Documentation/Intel: Add build setup documentation for Intel RVP boards ...................................................................... Documentation/Intel: Add build setup documentation for Intel RVP boards Add documentation which describes how to build coreboot image for Intel RVP boards from coreboot.org source code. TEST=None Signed-off-by: V Sowmya <v.sowmya(a)intel.com> Change-Id: I8f31b12b03b8b0662fd4fda0afa7c1c634a39dfe --- A Documentation/Intel/Board/intel_rvp.html M Documentation/Intel/index.html 2 files changed, 79 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/25043/3 -- To view, visit https://review.coreboot.org/25043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f31b12b03b8b0662fd4fda0afa7c1c634a39dfe Gerrit-Change-Number: 25043 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Documentation/Intel: Add build setup documentation for Intel RVP boards
by build bot (Jenkins) (Code Review) 12 Mar '18

12 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25043 ) Change subject: Documentation/Intel: Add build setup documentation for Intel RVP boards ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68496/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22910/ : SUCCESS -- To view, visit https://review.coreboot.org/25043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f31b12b03b8b0662fd4fda0afa7c1c634a39dfe Gerrit-Change-Number: 25043 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 03:37:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/Intel: Add build setup documentation for Intel RVP boards
by V Sowmya (Code Review) 12 Mar '18

12 Mar '18

Hello Naresh Solanki, Balaji Manigandan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25043 to look at the new patch set (#2). Change subject: Documentation/Intel: Add build setup documentation for Intel RVP boards ...................................................................... Documentation/Intel: Add build setup documentation for Intel RVP boards Add documentation which describes how to build coreboot image for Intel RVP boards from coreboot.org source code. TEST=None Signed-off-by: V Sowmya <v.sowmya(a)intel.com> Change-Id: I8f31b12b03b8b0662fd4fda0afa7c1c634a39dfe --- A Documentation/Intel/Board/intel_rvp.html M Documentation/Intel/index.html 2 files changed, 79 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/25043/2 -- To view, visit https://review.coreboot.org/25043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f31b12b03b8b0662fd4fda0afa7c1c634a39dfe Gerrit-Change-Number: 25043 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add VT-d and VMX programming
by build bot (Jenkins) (Code Review) 12 Mar '18

12 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25118 ) Change subject: soc/intel/cannonlake: Add VT-d and VMX programming ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22909/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68495/ : SUCCESS -- To view, visit https://review.coreboot.org/25118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I589590450aa4b9302ee2f9bb7b879a332f50b73e Gerrit-Change-Number: 25118 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 01:22:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add VT-d and VMX programming
by Lijian Zhao (Code Review) 12 Mar '18

12 Mar '18

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/25118 Change subject: soc/intel/cannonlake: Add VT-d and VMX programming ...................................................................... soc/intel/cannonlake: Add VT-d and VMX programming Add FSP option to enable/disable VT-d(Intel Virtualization Technology for Directed I/O) and VMX(Virtual Machine Extensions), VMX will be disabled once VT-d got disabled. Bug=b.73655383 TEST=Build and flash image on meowth board with debug build FSP, in serial log search for "VMXEnable" and "VtdDiable". Change-Id: I589590450aa4b9302ee2f9bb7b879a332f50b73e Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/chip.c M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/romstage/romstage.c 3 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/25118/1 diff --git a/src/soc/intel/cannonlake/chip.c b/src/soc/intel/cannonlake/chip.c index 2187f90..9c78b44 100644 --- a/src/soc/intel/cannonlake/chip.c +++ b/src/soc/intel/cannonlake/chip.c @@ -180,6 +180,7 @@ { int i; FSP_S_CONFIG *params = &supd->FspsConfig; + FSP_S_TEST_CONFIG *tconfig = &supd->FspsTestConfig; const struct device *dev = SA_DEV_ROOT; config_t *config = dev->chip_info; @@ -289,6 +290,9 @@ * 3 = GT unsliced, 4 = GT sliced */ for (i = 0; i < ARRAY_SIZE(config->domain_vr_config); i++) fill_vr_domain_config(params, i, &config->domain_vr_config[i]); + + /* Vt-D config */ + tconfig->VtdDisable = config->VtdDisable; } /* Mainboard GPIO Configuration */ diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h index 5e70fae..a9d82fb 100644 --- a/src/soc/intel/cannonlake/chip.h +++ b/src/soc/intel/cannonlake/chip.h @@ -275,6 +275,9 @@ /* Enable Pch iSCLK */ uint8_t pch_isclk; + + /* Vt-D Disable */ + uint8_t VtdDisable; }; typedef struct soc_intel_cannonlake_config config_t; diff --git a/src/soc/intel/cannonlake/romstage/romstage.c b/src/soc/intel/cannonlake/romstage/romstage.c index 759c2c9..a9027a7 100644 --- a/src/soc/intel/cannonlake/romstage/romstage.c +++ b/src/soc/intel/cannonlake/romstage/romstage.c @@ -169,6 +169,9 @@ /* Disable Cpu Ratio Override temporary. */ m_cfg->CpuRatio = 0; m_cfg->PcdSerialIoUartNumber = CONFIG_UART_FOR_CONSOLE; + /* Disable Vmx if Vt-d is already disabled */ + if (config->VtdDisable) + m_cfg->VmxEnable = 0; } void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) -- To view, visit https://review.coreboot.org/25118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I589590450aa4b9302ee2f9bb7b879a332f50b73e Gerrit-Change-Number: 25118 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: mb/google/kahlee: Fix IRQ routing
by build bot (Jenkins) (Code Review) 12 Mar '18

12 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25107 ) Change subject: mb/google/kahlee: Fix IRQ routing ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22908/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68494/ : SUCCESS -- To view, visit https://review.coreboot.org/25107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb048d3e728dc562cb31b9ddd50bfd8fb032017e Gerrit-Change-Number: 25107 Gerrit-PatchSet: 6 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Mar 2018 23:30:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018